Re: UI scaling issues when physical and logical screen resolutions differ on Linux

2024-02-20 Thread Christopher Schnick
So I tested this on my Asahi Fedora Linux KDE setup. So you were right about the scaling-factor being set to 1, but I'm still a little bit confused about this situation. If I go into the KDE settings, and change the display scaling to 150% for example, other (native) applications somehow get s

RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout

2024-02-20 Thread Martin Fox
On Linux getKeyCodeForChar does not consult the current keyboard layout. For example, it assumes the “+” character is on KeyCode.PLUS even on layouts which don’t generate KeyCode.PLUS. The result is that most KeyCharacterCombinations don’t work. This PR fixes this using the same approach that M

Re: Proposal: Bump minimum JDK version for JavaFX 23 to JDK 21

2024-02-20 Thread Kevin Rushforth
This is unrelated to the discussion of bumping the minimum version to JDK 21, since we can already use switch expressions (they were added in JDK 14, which is below the current minimum of JDK 17). I recommend starting a  new thread if you would like to discuss this. -- Kevin On 2/20/2024 8:1

Re: Proposal: Bump minimum JDK version for JavaFX 23 to JDK 21

2024-02-20 Thread Andy Goryachev
+1 I would like to put forth an opinion that we should NOT use non-comprehensive switch expressions over enums, as they introduce a major incompatibility when evolving that enum (i.e. when adding new values). Consider this: enum E { A, B } E e; switch(e) { case A -> "a"; case B -> "b"; } evo

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v11]

2024-02-20 Thread Andy Goryachev
On Mon, 19 Feb 2024 10:21:52 GMT, Karthik P K wrote: >> tests/system/src/test/java/test/robot/javafx/scene/RTLTextCharacterIndexTest.java >> line 107: >> >>> 105: */ >>> 106: >>> 107: public class RTLTextCharacterIndexTest { >> >> This is a system test, which don't run with the build system.

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-20 Thread Jose Pereda
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v4]

2024-02-20 Thread Jose Pereda
> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and > `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and > wrapped functions for GTK 3.20+ (so systems without it still run with GTK > 3.8+), and fixes the dragging issue on Wayland. Jose Pereda has u

[jfx21u] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-02-20 Thread Jose Pereda
Hi all, This pull request contains a clean backport of commit [90cbc663](https://github.com/openjdk/jfx/commit/90cbc66305d0a1380cf3a8cd99ad40db240e554c) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Kevin Rushforth on 15 Jan 2024 and