Re: Platform preferences theme detection

2024-02-10 Thread Christopher Schnick
Well, that is going to be a fun one to debug ... In my application I check for a headless environment with GraphicsEnvironment.getLocalGraphicsEnvironment().getScreenDevices(). If you call that one before you initialize your application, the preferences detection does no longer update. So if yo

Re: Detecting successful file drops on macOS

2024-02-10 Thread Martin Fox
Hi Christopher, This is a bug in the Mac platform code. I’ve created a JBS issue, see https://bugs.openjdk.org/browse/JDK-8325591. Unfortunately I haven’t found a work-around for it. Martin > On Feb 9, 2024, at 9:17 PM, Christopher Schnick wrote: > > Hello, > I'm using macOS Sonoma 14.3 aarc

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v5]

2024-02-10 Thread John Hendrikx
> The SimpleSelector and CompoundSelector classes are public classes in an > exported package, javafx.css, but they are not intended to be used by > applications. They are implementation details. They cannot be constructed > directly and no other JavaFX API accepts or returns a SimpleSelector or

Re: Platform preferences theme detection

2024-02-10 Thread Michael Strauß
Since I can't reproduce the error on macOS, it's hard to say what could be causing it. If you have the chance, maybe you could run the PlatformPreferencesChangedTest application: https://github.com/openjdk/jfx/blob/master/tests/manual/events/PlatformPreferencesChangedTest.java That might rule out

Re: RFR: JDK-8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]

2024-02-10 Thread John Hendrikx
On Thu, 8 Feb 2024 21:25:41 GMT, Marius Hanl wrote: > I completely forgot about this PR, but it looks very interesting, especially > about the nested events. If helpful, I can test this soon in a bigger > application, especially for any regressions. And of course also review the > code, but ne

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v14]

2024-02-10 Thread John Hendrikx
On Sat, 10 Feb 2024 14:40:45 GMT, Kevin Rushforth wrote: >>> And on Linux I get similar failures to my Windows system due to no Monaco >>> font. >> >> Was the Tahoma font available there (you can see from the `TextLayoutTest > >> fail()` test) ? >> >> If so, I could rewrite most of the tests

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v15]

2024-02-10 Thread John Hendrikx
> There are a number of tickets open related to text rendering: > > https://bugs.openjdk.org/browse/JDK-8314215 > > https://bugs.openjdk.org/browse/JDK-8145496 > > https://bugs.openjdk.org/browse/JDK-8129014 > > They have in common that wrapped text is taking the trailing spaces on each > wrap

Re: Platform preferences theme detection

2024-02-10 Thread Michael Strauß
Hi Christopher, the relevant preferences for color scheme detection are textColor=0x00ff and textBackgroundColor=0x on your system. That's pretty strange, I'm getting the following values on macOS Sonoma 14.3.1 M1: in light mode: textColor=0x00ff, textBackgroundColor=0xfff

Re: RFR: 8278021: Fix warnings in macOS glass native code and treat warnings as errors [v5]

2024-02-10 Thread Kevin Rushforth
On Mon, 5 Feb 2024 16:46:40 GMT, Martin Fox wrote: >> Turning on warnings-as-errors for the macOS glass native code. Deprecated >> declarations are excluded and still appear as warnings. >> >> In the code that tries to locate the application's dock icon there were >> three instances where `NO`

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v2]

2024-02-10 Thread Kevin Rushforth
On Mon, 5 Feb 2024 22:25:36 GMT, John Hendrikx wrote: >>> need 2 passes, because there already is a method named like that: >> >> oh yeah, sorry. >> `getStyleClassesSet()` ? > >> > need 2 passes, because there already is a method named like that: >> >> oh yeah, sorry. `getStyleClassesSet()` ? >

[jfx22u] Integrated: 8311492: FontSmoothingType LCD produces wrong color when transparency is used

2024-02-10 Thread Kevin Rushforth
On Fri, 9 Feb 2024 22:50:42 GMT, Kevin Rushforth wrote: > Clean backport to jfx22u. This pull request has now been integrated. Changeset: d4328d96 Author:Kevin Rushforth URL: https://git.openjdk.org/jfx22u/commit/d4328d969aa69751e9171918c14bacf294c45e46 Stats: 276 lines in 3 fil

Re: [jfx22u] RFR: 8311492: FontSmoothingType LCD produces wrong color when transparency is used

2024-02-10 Thread Kevin Rushforth
On Fri, 9 Feb 2024 22:50:42 GMT, Kevin Rushforth wrote: > Clean backport to jfx22u. Thanks. - PR Comment: https://git.openjdk.org/jfx22u/pull/10#issuecomment-1937026198

Re: [jfx22u] RFR: 8311492: FontSmoothingType LCD produces wrong color when transparency is used

2024-02-10 Thread Kevin Rushforth
On Fri, 9 Feb 2024 22:50:42 GMT, Kevin Rushforth wrote: > Clean backport to jfx22u. @johanvos Presuming you have no concerns, can you do the maintainer approval (`/approve yes`) when you get a chance? - PR Comment: https://git.openjdk.org/jfx22u/pull/10#issuecomment-1937025067

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v14]

2024-02-10 Thread Kevin Rushforth
On Sat, 10 Feb 2024 03:58:24 GMT, John Hendrikx wrote: > > And on Linux I get similar failures to my Windows system due to no Monaco > > font. > > Was the Tahoma font available there (you can see from the `TextLayoutTest > > fail()` test) ? It doesn't look like it: org.opentest4j.AssertionF