On Fri, 19 Jan 2024 16:07:31 GMT, Michael Strauß wrote:
> The `Animation` class states in the documentation of various methods that the
> method call would be asynchronous, using language similar to:
>
>
> {@code stop()} is an asynchronous call, the {@code Animation} may not stop
> immediatel
On Tue, 16 Jan 2024 10:16:08 GMT, Florian Kirmaier
wrote:
>> A few things about the latest commit:
>>
>> 1. The usage of the `active` property caused regression: the memoryLeak test
>> that was introduced in the fix for JDK-8318841 now failed. A number of
>> listeners were hard referenced fro
> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for
> https://bugs.openjdk.org/browse/JDK-8319779
Johan Vos has updated the pull request incrementally with one additional commit
since the last revision:
Add additional test
On Sat, 20 Jan 2024 14:52:19 GMT, Kevin Rushforth wrote:
> Simple fix of a typo in a code comment.
Trivial but important fix (it is correct in line 72). Great to improve in-code
doc quality.
-
Marked as reviewed by jvos (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1343
Hi Jurgen,
What I'm confused about the most is what it is you are actually trying to
do that necessitates the use of animations outside of the FX thread. You
said that you need to initialize controls on another thread, and that you
are using Task (both of which are fine), but how does playing anim
Simple fix of a typo in a code comment.
-
Commit messages:
- 8324237: Typo in comment in GlassApplication.m
Changes: https://git.openjdk.org/jfx/pull/1343/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1343&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8324237
Sta
On Sat, 20 Jan 2024 01:08:23 GMT, Martin Fox wrote:
>> modules/javafx.swing/src/main/java/javafx/embed/swing/InputMethodSupport.java
>> line 132:
>>
>>> 130: }
>>> 131: if (selected[0] == null) selected[0] = "";
>>> 132: return new AttributedString(selected[0
On Fri, 19 Jan 2024 16:15:10 GMT, Martin Fox wrote:
>> On Windows we need to ensure InputMethodRequests coming from JFXPanel are
>> processed on the JavaFX application thread instead of the AWT EventQueue
>> thread. This PR adds the runAndWait() calls to do that.
>>
>> This would be difficult
