On Tue, 16 Jan 2024 15:42:28 GMT, Andy Goryachev wrote:
>> Added comment and used bit logic in the condition.
>> Do you think we should create a method in TextRun? I believe it is out of
>> scope of this PR as it will be used in other functions as well.
>
> Yes, creating such a new method in Tex
On Mon, 15 Jan 2024 15:09:45 GMT, Kevin Rushforth wrote:
> Release notes for JavaFX 21.0.2.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=45268
>
> The original filter, with the backport IDs, is here:
>
> https://bugs.
On Tue, 16 Jan 2024 22:29:01 GMT, Kevin Rushforth wrote:
> Merge changes from `jfx:jfx22` --> `jfx22u`.
This pull request has now been integrated.
Changeset: dcf4e6a2
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx22u/commit/dcf4e6a2417b72050baa831ade2931a3b18915c7
Stats:
Merge changes from `jfx:jfx22` --> `jfx22u`.
-
Commit messages:
- Merge remote-tracking branch 'jfx/jfx22' into merge-jfx22-2024-01-16
- 8221261: Deadlock on macOS in JFXPanel app when handling IME calls
- Merge
- Merge
- Merge
- Merge
- Merge
- Merge
- Merge
- Merge
- ...
On Tue, 16 Jan 2024 20:30:01 GMT, Johan Vos wrote:
> Start work on 21.0.3
Marked as reviewed by kcr (Lead).
-
PR Review: https://git.openjdk.org/jfx21u/pull/41#pullrequestreview-1824990450
Start work on 21.0.3
-
Commit messages:
- Increase JavaFX version to 21.0.3 before any other commits go in.
Changes: https://git.openjdk.org/jfx21u/pull/41/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=41&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8323830
S
Increase the release version to JavaFX 17.0.11
-
Commit messages:
- Increase version to 17.0.11
Changes: https://git.openjdk.org/jfx17u/pull/176/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=176&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8323829
Stats: 2 li
On Fri, 12 Jan 2024 00:00:43 GMT, Kevin Rushforth wrote:
> Backport the changes to the README and CONTTRIBUTING guidelines for update
> releases. There are two commits: the first is a clean backport of the fix
> that went into jfx21u. The second is a simple substitution changing 21 to 22
> in
On Mon, 15 Jan 2024 16:11:08 GMT, Kevin Rushforth wrote:
> Clean backport of a safe fix for this critical deadlock bug to the jfx22
> stabilization branch during RDP1.
This pull request has now been integrated.
Changeset: 0a566990
Author:Kevin Rushforth
URL:
https://git.openjdk.org
On Tue, 16 Jan 2024 15:45:54 GMT, Kevin Rushforth wrote:
> Merge the just-release CPU content for the January 2024 CPU release into the
> `master` branch for JavaFX 21.0.2.
This pull request has now been integrated.
Changeset: e6bad3fd
Author:Kevin Rushforth
URL:
https://git.openjd
> Merge the just-release CPU content for the January 2024 CPU release into the
> `master` branch for JavaFX 21.0.2.
Kevin Rushforth has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebas
On Tue, 16 Jan 2024 15:44:19 GMT, Kevin Rushforth wrote:
> Merge the just-release CPU content for the January 2024 CPU release into the
> `master` branch for JavaFX 23.
This pull request has now been integrated.
Changeset: e2bc52da
Author:Kevin Rushforth
URL:
https://git.openjdk.or
On Tue, 16 Jan 2024 15:45:27 GMT, Kevin Rushforth wrote:
> Merge the just-release CPU content for the January 2024 CPU release into the
> `jfx22` branch for JavaFX 22.
This pull request has now been integrated.
Changeset: c0f8fe66
Author:Kevin Rushforth
URL:
https://git.openjdk.org
> Merge the just-release CPU content for the January 2024 CPU release into the
> `jfx22` branch for JavaFX 22.
Kevin Rushforth has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. Th
On Windows we need to ensure InputMethodRequests coming from JFXPanel are
processed on the JavaFX application thread instead of the AWT EventQueue
thread. This PR adds the runAndWait() calls to do that.
This would be difficult to test on Windows without a fix for
[JDK-8090267](https://bugs.open
On Mon, 15 Jan 2024 15:09:45 GMT, Kevin Rushforth wrote:
> Release notes for JavaFX 21.0.2.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=45268
>
> The original filter, with the backport IDs, is here:
>
> https://bugs.
On Mon, 15 Jan 2024 15:09:45 GMT, Kevin Rushforth wrote:
> Release notes for JavaFX 21.0.2.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=45268
>
> The original filter, with the backport IDs, is here:
>
> https://bugs.
Release notes for JavaFX 21.0.2.
Notes to reviewers:
I used the following filter to pick the issues:
https://bugs.openjdk.org/issues/?filter=45268
The original filter, with the backport IDs, is here:
https://bugs.openjdk.org/issues/?filter=45267
As usual, I excluded test bugs, cleanup bugs, e
On Tue, 16 Jan 2024 15:45:27 GMT, Kevin Rushforth wrote:
> Merge the just-release CPU content for the January 2024 CPU release into the
> `jfx22` branch for JavaFX 22.
Marked as reviewed by jvos (Reviewer).
-
PR Review: https://git.openjdk.org/jfx/pull/1336#pullrequestreview-18241
On Tue, 16 Jan 2024 15:45:54 GMT, Kevin Rushforth wrote:
> Merge the just-release CPU content for the January 2024 CPU release into the
> `master` branch for JavaFX 21.0.2.
Marked as reviewed by jvos (Reviewer).
-
PR Review: https://git.openjdk.org/jfx21u/pull/40#pullrequestreview
On Tue, 16 Jan 2024 15:44:19 GMT, Kevin Rushforth wrote:
> Merge the just-release CPU content for the January 2024 CPU release into the
> `master` branch for JavaFX 23.
Marked as reviewed by jvos (Reviewer).
-
PR Review: https://git.openjdk.org/jfx/pull/1335#pullrequestreview-1824
On Sun, 14 Jan 2024 16:06:42 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show d
On Tue, 16 Jan 2024 15:45:54 GMT, Kevin Rushforth wrote:
> Merge the just-release CPU content for the January 2024 CPU release into the
> `master` branch for JavaFX 21.0.2.
Reviewer: @johanvos
-
PR Comment: https://git.openjdk.org/jfx21u/pull/40#issuecomment-1894011870
Merge the just-release CPU content for the January 2024 CPU release into the
`master` branch for JavaFX 21.0.2.
-
Commit messages:
- Merge branch 'jfx21.0.2' into merge-jfx21.0.2
- Merge
- Merge
- Merge
- Merge
- Merge
- Merge
- Merge
- 8313105: Improved media framing
- 831
Merge the just-release CPU content for the January 2024 CPU release into the
`jfx22` branch for JavaFX 22.
-
Commit messages:
- Merge branch 'jfx22-cpu-2401' into merge-jfx22-cpu-2401
- Merge
- Merge
- Merge
- Merge
- Merge
- Merge
- Merge
- Merge
- 8313105: Improved media
On Tue, 16 Jan 2024 15:44:19 GMT, Kevin Rushforth wrote:
> Merge the just-release CPU content for the January 2024 CPU release into the
> `master` branch for JavaFX 23.
Reviewer: @johanvos
-
PR Comment: https://git.openjdk.org/jfx/pull/1335#issuecomment-1894009626
Merge the just-release CPU content for the January 2024 CPU release into the
`master` branch for JavaFX 23.
-
Commit messages:
- Merge branch 'jfx23-cpu-2401' into merge-jfx23-cpu-2401
- Merge
- Merge
- Merge
- Merge
- Merge
- Merge
- Merge
- Merge
- 8313105: Improved media
On Tue, 16 Jan 2024 15:45:27 GMT, Kevin Rushforth wrote:
> Merge the just-release CPU content for the January 2024 CPU release into the
> `jfx22` branch for JavaFX 22.
Reviewer: @johanvos
-
PR Comment: https://git.openjdk.org/jfx/pull/1336#issuecomment-1894011010
On Tue, 16 Jan 2024 10:34:42 GMT, Karthik P K wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java
>> line 562:
>>
>>> 560: charIndex += textWidthPrevLine;
>>> 561: charIndex += relIndex;
>>> 562: if
On Tue, 16 Jan 2024 13:54:00 GMT, Kevin Rushforth wrote:
>> As noted in the JBS bug, this is a follow-on to
>> [JDK-8196011](https://bugs.openjdk.org/browse/JDK-8196011) that I discovered
>> while testing the fix for
>> [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) (a deadlock in
On Wed, 10 Jan 2024 17:53:46 GMT, Hima Bindu Meda wrote:
> This PR updates webkit to v617.1. Verified build on Mac,Windows and linux.
> Sanity testing looks fine. No issues observed in HelloWebView as well
This pull request has now been integrated.
Changeset: ba79e081
Author:Hima Bindu Meda
> As noted in the JBS bug, this is a follow-on to
> [JDK-8196011](https://bugs.openjdk.org/browse/JDK-8196011) that I discovered
> while testing the fix for
> [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) (a deadlock in the
> IME code when using WebView in a JFXPanel on macOS).
>
On Fri, 12 Jan 2024 16:58:55 GMT, Andy Goryachev wrote:
> There seems to be a weird problem with Text (tested on macOS) in the Monkey
> Tester. 'Writing Systems' is a multi-line text with a tricky font (which does
> not get rendered correctly in LTR mode for some reason, but does in RTL). So
>
On Thu, 21 Dec 2023 12:57:01 GMT, Florian Kirmaier
wrote:
>> In some situations, a part of the SG is no longer rendered.
>> I created a test program that showcases this problem.
>>
>> Explanation:
>>
>> This can happen, when a part of the SG, is covered by another Node.
>> In this part, one no
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
> conditions were not considered, hence hit test values such as character index
> and insertion index values were incorrect.
>
> Added checks for RTL orientation of nodes and fixed the issue in
> `getHitInfo()` to calculat
On Fri, 12 Jan 2024 15:50:24 GMT, Andy Goryachev wrote:
>> Are you suggesting to pass boolean as parameter in addition to textRunStart
>> and curRunStart? If that is the case then yes I think it would be better.
>
> that's right, something like this:
>
>
> public Hit getHitInfo(float x, float
On Fri, 12 Jan 2024 16:14:20 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Code review changes
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java
> line 480:
>
On Thu, 11 Jan 2024 14:04:36 GMT, Johan Vos wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert some of the conditional bindings.
>> Clear menu construction when an menuitem that is a menu needs to be removed
>>
On Sun, 14 Jan 2024 16:06:42 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show d
39 matches
Mail list logo
