On Mon, 15 Jan 2024 16:11:08 GMT, Kevin Rushforth wrote:
> Clean backport of a safe fix for this critical deadlock bug to the jfx22
> stabilization branch during RDP1.
Marked as reviewed by psadhukhan (Reviewer).
-
PR Review: https://git.openjdk.org/jfx/pull/1334#pullrequestreview
On Fri, 12 Jan 2024 14:11:14 GMT, Lukasz Kostyra wrote:
> Originally this issue showed the problem of Node being incorrectly rendered
> (clipped) when snapshotting, compared to a snapshot of the whole Scene. Later
> on there was another problem added - lights not being taken into account if
>
On Sun, 14 Jan 2024 15:14:36 GMT, John Hendrikx wrote:
>> If this method is not used anywhere, why do we need to expose
>> `getStyleClassNames()` as new API to replace this one? I'm a bit puzzled by
>> that, especially since you're saying that the API shouldn't be used. Why
>> create something
On Sun, 14 Jan 2024 14:54:36 GMT, John Hendrikx wrote:
> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>
> This can be done with only a minor API break, as `SimpleSelector` and
> `CompoundSelector` were public before. However, these classes could not be
> constructed by
On Mon, 15 Jan 2024 16:11:08 GMT, Kevin Rushforth wrote:
> Clean backport of a safe fix for this critical deadlock bug to the jfx22
> stabilization branch during RDP1.
Reviewer: @prrace or @prsadhuk
-
PR Comment: https://git.openjdk.org/jfx/pull/1334#issuecomment-1892451896
Clean backport of a safe fix for this critical deadlock bug to the jfx22
stabilization branch during RDP1.
-
Commit messages:
- Backport 90cbc66305d0a1380cf3a8cd99ad40db240e554c
Changes: https://git.openjdk.org/jfx/pull/1334/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1
On Wed, 10 Jan 2024 14:54:47 GMT, Kevin Rushforth wrote:
> As described in the JBS bug, there is a long-standing deadlock that happens
> on macOS between the AWT EDT and the JavaFX Application thread (which on
> macOS is the AppKit thread) when processing Input Method Events (IME) in a
> WebVi
On Fri, 12 Jan 2024 23:24:19 GMT, Andy Goryachev wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511
>> reverted accidental indentation chang
>
> modules/javafx.controls/src/main/java/javafx/scene/con
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
> the other cases, the assumed default cell height is used.
>
