On Thu, 11 Jan 2024 23:11:12 GMT, Kevin Rushforth wrote:
> Updates for the beginning of the 22.0.1 release.
This pull request has now been integrated.
Changeset: 5817ac0d
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx22u/commit/5817ac0d6b1abc8bac9e2e8c14f1cc0f3cbaf06f
Stats
On Wed, 10 Jan 2024 12:31:20 GMT, Florian Kirmaier
wrote:
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
>
Interesting. I reran our headful test job after updating to macOS 14.2.1
and it didn't make a difference -- the SystemMenuBarTest passes on both
the Intel and M2 systems. Not sure what to make of this, but you might
be right about there being an aspect of this that's timing related.
I can take
On Thu, 11 Jan 2024 20:13:09 GMT, Marius Hanl wrote:
> For some reason the `skinProperty` did not allow to set a new skin when it is
> the same class as the previous one.
> This leads to multiple issues:
> 1. When creating a new skin (same class as previous), the skin will likely
> install list
On Thu, 11 Jan 2024 10:15:01 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of
On Thu, 11 Jan 2024 10:15:01 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of
So that does strongly suggest that this was an OS bug on earlier macOS
14.0.x and 14.1.x now fixed in 14.2. FYI, here are four Swing / AWT bugs
that point to problems with native events, all of which are fixed in
macOS 14.2:
https://bugs.openjdk.org/browse/JDK-8320056
https://bugs.openjdk.org/
I updated (my M2) from 14.1 to 14.2.1 and now the test correctly fails
(after reverting my last commit).
Since it passed before (14.1) and failed after (14.2.1) updating, it is
indeed more likely to be related to OS version rather than CPU arch (which
I would find very weird).
- Johan
On Fri, Jan
On Fri, 12 Jan 2024 06:29:44 GMT, Karthik P K wrote:
> Do you think it is better to address that issue after we complete JDK-8318095?
I think the solution for JDK-8318095 is just to trigger a layout, so we could
do all these in parallel (as long as we don't resize the container).
I was hoping t
On Fri, 12 Jan 2024 05:16:33 GMT, Karthik P K wrote:
>> @karthikpandelu , the more I think about it, the less I like the idea of
>> overloading (textRunStart and curRunStart).
>> what if things will change in the future?
>>
>> I think it'll be much cleaner to pass a boolean forTextFlow (or forT
I ran the version of your fix+test from before yesterday's fix. It fails
on most of the systems (meaning the window was activated), but passes
unexpectedly on two of them, one Intel and one M2:
Local systems:
Intel MacBook macOS 13.6.3 -- test failed
M1 MacBook macOS 14.2.1 -- test failed
Jen
Originally this issue showed the problem of Node being incorrectly rendered
(clipped) when snapshotting, compared to a snapshot of the whole Scene. Later
on there was another problem added - lights not being taken into account if
they are added to a SubScene.
As it later turned out, the origina
On Fri, 12 Jan 2024 12:20:22 GMT, Marius Hanl wrote:
>> Thanks for having a look, it's good to have some more use cases from other
>> applications! The sets are used both for the style classes on `Node`s but
>> also the set of style classes in CSS selectors (multiple style classes in
>> sele
Yeah, I just realized that you had fixed it prior to my running the
tests yesterday afternoon. I reverted your most recent commit and it now
fails for me, as expected, on my Intel Mac running macOS 13. I'll try
now on my M1 and M2.
-- Kevin
On 1/12/2024 5:48 AM, Johan Vos wrote:
Hi Kevin,
Hi Kevin,
Thanks for testing.
With the latest version of the PR, all tests should pass on all platforms
(I believe the PR is ready now). Excluding my last commit, the tests
should fail on all platforms. However, they pass for me (and Martin) on M2,
because the app does not get activated.
- Johan
On Wed, 10 Jan 2024 22:39:22 GMT, Andy Goryachev wrote:
>> This PR fixes the border glitch/gap as explained in both linked tickets.
>>
>> I noted that the `ScrollPane` control does not suffer from this problem,
>> although the code is mostly the same as in `VirtualFlow`. The `ScrollPane`
>> sn
On Fri, 12 Jan 2024 00:00:43 GMT, Kevin Rushforth wrote:
> Backport the changes to the README and CONTTRIBUTING guidelines for update
> releases. There are two commits: the first is a clean backport of the fix
> that went into jfx21u. The second is a simple substitution changing 21 to 22
> in
On Fri, 12 Jan 2024 07:23:56 GMT, Johan Vos wrote:
>> Updates for the beginning of the 22.0.1 release.
>
> Marked as reviewed by jvos (Reviewer).
@johanvos Thanks for the review. Can you add the needed maintainer approval,
either using the Skara `/approve` command or directly in JBS? No hurry,
I ran the then latest version of the test from PR 1283 yesterday
afternoon, and for me it passed on both M1 and M2. I didn't try it on an
Intel Mac, but will do so this morning.
I hadn't noticed any problems with our other tests when getting things
running on macOS 14 (beyond the bugs we alrea
On Thu, 11 Jan 2024 22:36:58 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/FixedCapacitySet.java
>> line 94:
>>
>>> 92: return maximumCapacity == 0 ? empty()
>>> 93: : maximumCapacity == 1 ? new Single<>()
>>> 94: : maxim
On Thu, 11 Jan 2024 23:11:12 GMT, Kevin Rushforth wrote:
> Updates for the beginning of the 22.0.1 release.
Marked as reviewed by arapte (Reviewer).
-
PR Review: https://git.openjdk.org/jfx22u/pull/1#pullrequestreview-1817662768
Hi Martin,
Great analysis, and that sounds very well possible. Indeed, there is a
specific launch approach for the systemtests where the launch command is
created (in tests/system/src/test/java/test/util/Util).
It is still unclear to me why this would happen on M2 only (and not on M1
or Intel), bu
22 matches
Mail list logo
