Re: The crisp fonts saga

2023-12-13 Thread John Neffenger
On 12/13/23 3:29 AM, Mark Raynsford wrote: I would love to live in a world where everyone has such a high resolution display that we can turn off AA entirely, but we don't live in that one yet. Anti-aliasing is still widely in use, but the various operating systems and application frameworks h

RFR: 8301219: JavaFX crash when closing with the escape key

2023-12-13 Thread Martin Fox
While processing a key down event the Glass GTK code sends out PRESSED and TYPED KeyEvents back to back. If the stage is closed during the PRESSED event the code will end up referencing freed memory while sending out the TYPED event. This can lead to intermittent crashes. In GlassApplication.cp

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v13]

2023-12-13 Thread Martin Fox
On Tue, 28 Nov 2023 22:09:37 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >>

Re: Unable to select row in TableView depending on stage height

2023-12-13 Thread Andy Goryachev
It seems the problem might be related to using a Scene with depthBuffer = true. Set it to false (or use a different constructor) and the problem goes away. Still, this looks like a bug. Created https://bugs.openjdk.org/browse/JDK-8322002 -andy From: openjfx-dev on behalf of Kroiß, Florian

Re: Converting a Color object to its string representation

2023-12-13 Thread Kevin Rushforth
Or the third option: 3. Do nothing I would go for option 1 or 3. I do not recommend option 2. I see some value in a minimal API (option 1), returning a fixed format, perhaps:     if alpha == 1 { "#rrggbb" } else { "#rrggbbaa" } -- Kevin On 12/12/2023 4:04 PM, Eran Leshem wrote: I can se

Re: The crisp fonts saga

2023-12-13 Thread Mark Raynsford
On Tue, 2023-12-12 at 12:38 -0800, Philip Race wrote: > Usage of hinting in UIs is on the way out. > macOS stopped applying hints ages ago. Apple also canned LCD text. > High DPI displays are obsoleting the raison d'etre of both of these. High DPI displays might be the future, but they're not the

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2023-12-13 Thread Jose Pereda
On Mon, 20 Nov 2023 08:00:58 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one addition

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2023-12-13 Thread Jose Pereda
On Mon, 20 Nov 2023 08:00:58 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one addition