On Thu, 30 Nov 2023 23:24:40 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/CssUtil.java line
>> 75:
>>
>>> 73:
>>> 74: /** immutable list with random access backed by an array */
>>> 75: private static class ImmutableArrayList extends AbstractLi
Hi Andy,
Let me start to say that I had no problem with this PR being merged as I
already agreed with one of the first versions.
Sometimes then on the same PR there can be some discussions on what else
can be done in this area, potentially maybe even alleviating the need
for the change (X/Y
Dear colleagues:
there were a couple of comments after I withdrew
https://github.com/openjdk/jfx/pull/1296for reasons of frustration, so I wanted
to respond to those in the openjfx list.
> I pondered that back when I was working on replacing these static
> initializers with the .of collection
On Thu, 30 Nov 2023 01:38:13 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Fri, 24 Nov 2023 19:26:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
On Thu, 30 Nov 2023 23:02:10 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> save 8 bytes
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/CssUtil.java line 75:
>
>> 73:
>> 74:
On Thu, 30 Nov 2023 19:03:38 GMT, Andy Goryachev wrote:
>> Adding missing styleable properties to ImageView:
>>
>>
>> -fx-preserve-ratio
>> -fx-smooth
>> -fx-fit-width
>> -fx-fit-height
>>
>>
>> Updated CSS Reference.
>
> Andy Goryachev has updated the pull request incrementally with one addi
On Thu, 30 Nov 2023 19:03:38 GMT, Andy Goryachev wrote:
>> Adding missing styleable properties to ImageView:
>>
>>
>> -fx-preserve-ratio
>> -fx-smooth
>> -fx-fit-width
>> -fx-fit-height
>>
>>
>> Updated CSS Reference.
>
> Andy Goryachev has updated the pull request incrementally with one addi
Thanks for having a look!
On 30/11/2023 19:47, Andy Goryachev wrote:
I think BehaviorContext looks suspiciously like a (skin) input map, so
I would rather see that.
Invention of State class is a way to work around the stateless
behavior which, though it adds (in my opinion) very little, mig
On Fri, 30 Jun 2023 05:38:35 GMT, Karthik P K wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> Left a inline comment.
> Otherwise looks good to me
@karthikpandelu @hjohn @kevinrushforth could
> Adding missing styleable properties to ImageView:
>
>
> -fx-preserve-ratio
> -fx-smooth
> -fx-fit-width
> -fx-fit-height
>
>
> Updated CSS Reference.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
save 8 bytes
-
On Mon, 7 Aug 2023 10:53:06 GMT, Jose Pereda wrote:
> So far, BorderPane does the calculation for the children min/pref
> width/height taken into account only the margin applied to them, if any, but
> not the total padding that could be applied as well to the BorderPane itself.
>
> However, th
I think BehaviorContext looks suspiciously like a (skin) input map, so I would
rather see that.
Invention of State class is a way to work around the stateless behavior which,
though it adds (in my opinion) very little, might still be a feature that app
developers want to exploit - at least in t
On Thu, 16 Nov 2023 06:54:04 GMT, Karthik P K wrote:
>> The change listener on caretPositionProperty() was not getting invoked on
>> replacing the content with same text as there was no change in caret
>> position. Since the textProperty invalidation sets the forward bias to true
>> by default
On Thu, 30 Nov 2023 17:53:40 GMT, Andy Goryachev wrote:
>> Adding missing styleable properties to ImageView:
>>
>>
>> -fx-preserve-ratio
>> -fx-smooth
>> -fx-fit-width
>> -fx-fit-height
>>
>>
>> Updated CSS Reference.
>
> Andy Goryachev has updated the pull request incrementally with one addi
On Thu, 16 Nov 2023 06:50:36 GMT, Karthik P K wrote:
>> Yes, right now it is a bit magic. At least the first if can be simplified
>> still, as `!= 4` will also handle `== 0`.
>
> I agree with Andy here. However the first condition can be simplified without
> any side effects but I had seen some
> Adding missing styleable properties to ImageView:
>
>
> -fx-preserve-ratio
> -fx-smooth
> -fx-fit-width
> -fx-fit-height
>
>
> Updated CSS Reference.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
review comments
---
On Thu, 30 Nov 2023 07:44:13 GMT, Karthik P K wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Code review
>
> @andy-goryachev-oracle and @Maran23 please re-review when you get a chance.
@karthikpandelu I think this
On Thu, 30 Nov 2023 16:50:53 GMT, Michael Strauß wrote:
>> Adding missing styleable properties to ImageView:
>>
>>
>> -fx-preserve-ratio
>> -fx-smooth
>> -fx-fit-width
>> -fx-fit-height
>>
>>
>> Updated CSS Reference.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/CssUtil.java l
On Tue, 21 Nov 2023 00:01:14 GMT, Andy Goryachev wrote:
> Adding missing styleable properties to ImageView:
>
>
> -fx-preserve-ratio
> -fx-smooth
> -fx-fit-width
> -fx-fit-height
>
>
> Updated CSS Reference.
Marked as reviewed by mstrauss (Committer).
modules/javafx.graphics/src/main/java/c
On Wed, 22 Nov 2023 02:23:08 GMT, Michael Strauß wrote:
>> Adding missing styleable properties to ImageView:
>>
>>
>> -fx-preserve-ratio
>> -fx-smooth
>> -fx-fit-width
>> -fx-fit-height
>>
>>
>> Updated CSS Reference.
>
> modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line
Voting for Martin Fox [1] to OpenJFX Committer [2] is now closed.
Yes: 9
Veto: 0
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this is sufficient
to approve the nomination.
-- Kevin
[1] https://openjdk.java.net/census#mfox
[2] https://mail.openjdk.org/pipermail/openjfx-de
Voting for Florian Kirmaier [1] to OpenJFX Committer [2] is now closed.
Yes: 9
Veto: 0
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this is sufficient
to approve the nomination.
-- Kevin
[1] https://openjdk.java.net/census#fkirmaier
[2] https://mail.openjdk.org/pipermail
On Tue, 21 Nov 2023 00:01:14 GMT, Andy Goryachev wrote:
> Adding missing styleable properties to ImageView:
>
>
> -fx-preserve-ratio
> -fx-smooth
> -fx-fit-width
> -fx-fit-height
>
>
> Updated CSS Reference.
modules/javafx.graphics/src/main/java/javafx/css/CssMetaData.java line 341:
> 339:
Adding missing styleable properties to ImageView:
-fx-preserve-ratio
-fx-smooth
-fx-fit-width
-fx-fit-height
Updated CSS Reference.
-
Commit messages:
- cleanup
- cleanup
- css util
- Merge remote-tracking branch 'origin/master' into 8320359.image.view.css
- Merge remote-trac
On Thu, 30 Nov 2023 12:46:46 GMT, Kevin Rushforth wrote:
> Clean backport of fix for macOS 11 WebKit crash to jfx21u.
This pull request has now been integrated.
Changeset: 55ac7f07
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx21u/commit/55ac7f077adca3cee32add7a1050482272ac
On Tue, 6 Jul 2021 14:53:24 GMT, Florian Kirmaier wrote:
> It's "a bit" complicated.
> In some situations, getRuns get's called because listeners on bounds are set.
> This causes TextFlow to layout to compute the runs.
> Afterward, the bounds of the parents get updated.
> This triggers a call to
Clean backport of fix for macOS 11 WebKit crash to jfx21u.
-
Commit messages:
- Backport 0d3341704c1ced4f61b5f7f7618e23ec182ae379
Changes: https://git.openjdk.org/jfx21u/pull/35/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=35&range=00
Issue: https://bugs.openjdk.org/
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote:
> With the help of debug build which pinpointed the crash, I found the commit
> in upstream WebKit core that caused the crash. That commit was subsequently
> reverted not long after it was initially committed. This reverted commit
> wasn
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote:
> With the help of debug build which pinpointed the crash, I found the commit
> in upstream WebKit core that caused the crash. That commit was subsequently
> reverted not long after it was initially committed. This reverted commit
> wasn
> Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen.
Hima Bindu Meda has updated the pull request incrementally with two additional
commits since the last revision:
- update license for libxslt
- update libxslt.md
-
Changes:
- all: https://git.openjdk.or
31 matches
Mail list logo
