Re: javafx.base and java.desktop

2023-11-18 Thread Nir Lisker
> > Perhaps this is the right time to move this forward? I don't see why not. Except for changing the `requires` declaration in the module-info and mentioning it in the docs, is there anything else that needs to be changed? On Sat, Nov 18, 2023 at 7:48 PM Kevin Rushforth wrote: > We would need

Re: RFR: 8301302: Platform preferences API [v26]

2023-11-18 Thread Michael Strauß
On Sat, 18 Nov 2023 17:07:43 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove Preferences.getPaint > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java > line

Re: RFR: 8301302: Platform preferences API [v27]

2023-11-18 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request incrementally wi

RE: My JavaFX Christmas Wishlist

2023-11-18 Thread Pedro Duque Vieira
In the spirit of Christmas and of this thread here is my wish list 😊 1 - The number one thing I’d change would be to make JavaFX “more extendable”. By this I mean having more hooks to extend core areas of JavaFX (CSS parser, 3D, etc). The reason I ask for this is because it’s much easier for an

Re: RFR: 8301302: Platform preferences API [v26]

2023-11-18 Thread Kevin Rushforth
On Sat, 18 Nov 2023 16:31:58 GMT, Michael Strauß wrote: > I've updated the CSR. I reviewed the CSR. You might wait a couple days to see if anyone else has further comments on the API docs before finalizing it, but it is otherwise ready. - PR Comment: https://git.openjdk.org/jfx/p

Re: RFR: 8301302: Platform preferences API [v26]

2023-11-18 Thread Nir Lisker
On Sat, 18 Nov 2023 05:50:35 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: RFR: 8301302: Platform preferences API [v26]

2023-11-18 Thread Michael Strauß
On Sat, 18 Nov 2023 15:22:10 GMT, Kevin Rushforth wrote: > The latest API changes looks good. If you update the CSR, I'll formally > review it. > > In parallel, I'll finish my review and testing of the implementation. I've updated the CSR. - PR Comment: https://git.openjdk.org/jf

Re: javafx.base and java.desktop

2023-11-18 Thread Kevin Rushforth
We would need to validate the assertion that an app can't doing anything useful without the app itself importing and using java.beans from the java.desktop module. At a minimum this would need a CSR specifying this additional requirement that the app must depend on java.desktop in order to use

Re: RFR: 8301302: Platform preferences API [v26]

2023-11-18 Thread Kevin Rushforth
On Sat, 18 Nov 2023 05:50:35 GMT, Michael Strauß wrote: >> Please read [this >> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) >> for an introduction to the Platform Preferences API, and how it interacts >> with the proposed style theme and stage appearance features.

Re: javafx.base and java.desktop

2023-11-18 Thread Kevin Rushforth
Perhaps the module can be declared 'requires static'. That was my thinking as well, which is captured in https://bugs.openjdk.org/browse/JDK-8240844 Perhaps this is the right time to move this forward? -- Kevin On 11/17/2023 4:06 PM, Nir Lisker wrote: Hi, A previous discussion mentioned