RFR: 8319079: Missing range checks in decora

2023-10-29 Thread Jayathirth D V
In SW pipeline path of Box/Gaussian Blur/Shadow effects we are not checking for range when we read data from the source/destination buffers in native code. We need to add appropriate range checks in native JNI code also apart from range checks in Java side to make sure that wherever these JNI me

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text

2023-10-29 Thread Michael Strauß
On Sun, 10 Sep 2023 20:50:18 GMT, John Hendrikx wrote: > There are a number of tickets open related to text rendering: > > https://bugs.openjdk.org/browse/JDK-8314215 > > https://bugs.openjdk.org/browse/JDK-8145496 > > https://bugs.openjdk.org/browse/JDK-8129014 > > They have in common that w

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v12]

2023-10-29 Thread Michael Strauß
On Mon, 30 Oct 2023 01:16:58 GMT, Sai Pradeep Dandem wrote: >> **Issue:** >> Using pseudo classes in programmatic query using Node.lookupAll() or >> Node.lookup() gives unexpected results. >> >> **Cause:** >> There is no check for checking the psuedo states matching in the applies() >> method

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v12]

2023-10-29 Thread Sai Pradeep Dandem
> **Issue:** > Using pseudo classes in programmatic query using Node.lookupAll() or > Node.lookup() gives unexpected results. > > **Cause:** > There is no check for checking the psuedo states matching in the applies() > method of SimpleSelector.java. So checking for "applies()" alone is not > s

Re: RFR: 8301302: Platform preferences API [v17]

2023-10-29 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request incrementally wi

Re: RFR: 8301302: Platform preferences API [v16]

2023-10-29 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request with a new targe

Re: Prioritized event handlers

2023-10-29 Thread John Hendrikx
Hi Michael, What you describe in the generalization sounds excellent, and would go a step further and avoids the registration mechanism by instead doing multiple dispatch/bubbling phases.  The registration mechanism is more a system to avoid doing that multiple times, but it could also be enfo