Re: RFR: 8316419: [macos] Setting X/Y makes Stage maximization not work before show [v2]

2023-10-20 Thread Martin Fox
On Sat, 21 Oct 2023 00:10:50 GMT, Martin Fox wrote: >> When a window is visible the maximized, iconified, and fullscreen properties >> are two-way streets; changes made in Java are sent on to the platform window >> and changes in the platform window are sent back into Java. >> >> When a window

Re: RFR: 8316419: [macos] Setting X/Y makes Stage maximization not work before show [v2]

2023-10-20 Thread Martin Fox
> When a window is visible the maximized, iconified, and fullscreen properties > are two-way streets; changes made in Java are sent on to the platform window > and changes in the platform window are sent back into Java. > > When a window is hidden these properties (and others, like location and

Re: RFR: 8306083: Text.hitTest is incorrect when more than one Text node in TextFlow [v10]

2023-10-20 Thread Phil Race
On Fri, 13 Oct 2023 07:01:51 GMT, Karthik P K wrote: >> The text run selected in `PrismTextLayout::getHitInfo()` method for >> character index calculation was not correct when hitTest was invoked for >> Text node in a TextFlow with more than one Text child. Hence wrong character >> index value

Proof of concept pull request for Behavior API (PR 1265)

2023-10-20 Thread John Hendrikx
Hi list, I've made a proof of concept for possibly exposing Behaviors as a first class API in JavaFX.  It's by no means complete, and there will be some significant hurdles still no doubt, but this proof of concept does replace the internal ButtonBehavior completely with a newly implemented p

[jfx21u] Integrated: 8317508: Provide media support for libavcodec version 60

2023-10-20 Thread Alexander Matveev
On Fri, 20 Oct 2023 21:29:03 GMT, Alexander Matveev wrote: > Clean backport of JDK-8317508. This pull request has now been integrated. Changeset: 5958b044 Author:Alexander Matveev URL: https://git.openjdk.org/jfx21u/commit/5958b044064127c92e0776a741f4341931e3ac23 Stats: 12 line

[jfx21u] RFR: 8317508: Provide media support for libavcodec version 60

2023-10-20 Thread Alexander Matveev
Clean backport of JDK-8317508. - Commit messages: - Backport de456dad193f295a8bd93b72bb9b71960e6afd18 Changes: https://git.openjdk.org/jfx21u/pull/21/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=21&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317508 Stats:

Exploring the prism es2 land - couple of questions

2023-10-20 Thread Thiago Milczarek Sayão
Hi, I have some questions on prism es2. 1) Why is a Context created on each platform GLFactory if there is a GLContext? 2) What is the use of the Dummy Window? I'm working on using EGL instead of GLX, so it will work on Wayland. Thanks.

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu

2023-10-20 Thread Martin Fox
On Mon, 2 Oct 2023 12:51:52 GMT, vlaaad wrote: > This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). > > Context: the warning might be more important than it seems. Our JavaFX-based > desktop app has [an issue](https://github.com/defold/defold/issues/7845) — > when th

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu

2023-10-20 Thread Martin Fox
On Mon, 2 Oct 2023 12:51:52 GMT, vlaaad wrote: > This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). > > Context: the warning might be more important than it seems. Our JavaFX-based > desktop app has [an issue](https://github.com/defold/defold/issues/7845) — > when th

Re: Alternative approach for behaviors, leveraging existing event system

2023-10-20 Thread Martin Fox
John, >> >> You’re proposing using a similar mechanism to enable behaviors to >> communicate with their controls. That seems like a different problem that >> deserves a different discussion. In particular I don’t think these two >> problems need to be solved at the same time even if they both

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu

2023-10-20 Thread Andy Goryachev
On Wed, 18 Oct 2023 13:06:49 GMT, vlaaad wrote: >> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). >> >> Context: the warning might be more important than it seems. Our JavaFX-based >> desktop app has [an issue](https://github.com/defold/defold/issues/7845) — >> w

RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu

2023-10-20 Thread vlaaad
This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). Context: the warning might be more important than it seems. Our JavaFX-based desktop app has [an issue](https://github.com/defold/defold/issues/7845) — when the user opens 2 instances of the app, one of the instances h

Re: RFR: JDK-8284445: macOS 12 prints a warning when a function key shortcut is assigned to a menu

2023-10-20 Thread vlaaad
On Mon, 2 Oct 2023 12:51:52 GMT, vlaaad wrote: > This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445). > > Context: the warning might be more important than it seems. Our JavaFX-based > desktop app has [an issue](https://github.com/defold/defold/issues/7845) — > when th

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v7]

2023-10-20 Thread Andy Goryachev
On Fri, 20 Oct 2023 03:26:51 GMT, Sai Pradeep Dandem wrote: >> modules/javafx.graphics/src/test/java/test/javafx/scene/Node_lookup_Test.java >> line 202: >> >>> 200: */ >>> 201: @Test >>> 202: public void lookupPseudoTest3() { >> >> Consider naming the test methods according to wh

Re: RFR: JDK-8187314: All Cells: must show backing data always

2023-10-20 Thread Andy Goryachev
On Fri, 20 Oct 2023 07:12:03 GMT, Marius Hanl wrote: > Sure, but why? The first column in tree table is different from subsequent columns. I just want to make sure it works there as well. - PR Comment: https://git.openjdk.org/jfx/pull/1197#issuecomment-1772845089

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v2]

2023-10-20 Thread Andy Goryachev
On Wed, 18 Oct 2023 12:32:37 GMT, John Hendrikx wrote: >> Sai Pradeep Dandem has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8185831: Fixed test failing issues and code review comments > > This looks more reasonable now. I agree with @h

Re: [External] : Re: Alternative approach for behaviors, leveraging existing event system

2023-10-20 Thread John Hendrikx
On 18/10/2023 22:49, Andy Goryachev wrote: Dear John, thank you for clarifications.  Sorry for my delayed response. I think we need more meat for question #1 - it is not yet clear.  All event handlers end up in the control’s list, and we know that the ordering may be undetermined (or, rather

[jfx21u] Integrated: 8313321: Set minimum python version in WebKit cmake scripts

2023-10-20 Thread Hima Bindu Meda
On Fri, 20 Oct 2023 12:40:58 GMT, Hima Bindu Meda wrote: > Set minimum python version for all platforms. This pull request has now been integrated. Changeset: 8c2c9ca4 Author:Hima Bindu Meda URL: https://git.openjdk.org/jfx21u/commit/8c2c9ca4ca6bb72e5fbe97d002757d267b7c0882 Stats:

[jfx21u] Integrated: 8313321: Set minimum python version in WebKit cmake scripts

2023-10-20 Thread Hima Bindu Meda
Set minimum python version for all platforms. - Commit messages: - Backport bb07bcf7eb60cb772e6d4f135893ff6915c5aa0d Changes: https://git.openjdk.org/jfx21u/pull/20/files Webrev: https://webrevs.openjdk.org/?repo=jfx21u&pr=20&range=00 Issue: https://bugs.openjdk.org/browse/JDK-83

Re: Alternative approach for behaviors, leveraging existing event system

2023-10-20 Thread John Hendrikx
Hi Martin, I missed your initial mail again somehow; I will look into what's going with my mailing list setup, but I'll respond here inline. On 18/10/2023 22:20, Andy Goryachev wrote: I wonder if this might encroach upon application-specific requirements/logic (that is, does not belong to the

Re: RFR: 8185831: Pseudo selectors do not appear to work in Node.lookupAll() [v8]

2023-10-20 Thread John Hendrikx
On Fri, 20 Oct 2023 03:28:08 GMT, Sai Pradeep Dandem wrote: >> **Issue:** >> Using pseudo classes in programmatic query using Node.lookupAll() or >> Node.lookup() gives unexpected results. >> >> **Cause:** >> There is no check for checking the psuedo states matching in the applies() >> method

Re: RFR: JDK-8187314: All Cells: must show backing data always

2023-10-20 Thread Marius Hanl
On Fri, 20 Oct 2023 00:12:02 GMT, Andy Goryachev wrote: > Also, would it be possible to extend the tree table view test to include a > second column with the same logic? Sure, but why? I mean, a test should usually consist of as few components as are needed for testing, since we want to test