On Tue, 17 Oct 2023 19:14:48 GMT, Andy Goryachev wrote:
> @karthikpandelu there seems to much flicker. Try placing the caret not at the
> end of the text, but a few characters before the end.
I see the issue. It always keeps the caret at the right edge if we increase the
size. This creates fl
> **Issue:**
> Using pseudo classes in programmatic query using Node.lookupAll() or
> Node.lookup() gives unexpected results.
>
> **Cause:**
> There is no check for checking the psuedo states matching in the applies()
> method of SimpleSelector.java.
>
> **Fix:**
> Included the check for the st
Dear John:
Based on what I understand about your proposal now, I think it’s a variant of
the same thing, not fully developed and in some places based on the incorrect
assumptions (S/B separation, stateless B). But you know I am biased :-)
A more detailed proposal - up to you; there are literal
On Mon, 14 Aug 2023 16:28:20 GMT, Martin Fox wrote:
> A KeyCharacterCombination should match a key if the target character is
> printed on that key. For example, the user should be able to invoke the
> `Shortcut+'+' ` combination by holding down the Shortcut key and pressing a
> key that has '
Hi Andy,
I mean this in the most respectful way possible, but my feeling is that
most of the arguments presented in favor of this enhancement seem to be
driven by an existing implementation, and not a "first-principles" analysis.
I've seen many proposals on this mailing list shot down with exactl
Hi Andy,
On 17/10/2023 20:07, Andy Goryachev wrote:
Dear John:
It looks like we have different views on the subject, so perhaps we
should invite other people to weigh in.
I would be interested to hear from others on this subject as well.
I feel however that I may need to make a more forma
After finding the Window virtual key code for a character getKeyCodeForChar was
using a mapping table that only works correctly for U.S. English to retrieve
the Java key code. This caused getKeyCodeForChar to encode keys differently
than the original key event handling machinery.
With this fix
On Tue, 17 Oct 2023 12:15:14 GMT, Karthik P K wrote:
> Because of a missing conditional check in the `updateTextPos()`, the
> `textTranslateX` value was not getting updated when TextField size was
> changed as a result of resizing window.
>
> Updated the CENTER and LEFT cases in the `updateTe
Thank you!
We probably should extract the skinning discussion into a separate thread.
-andy
From: Pedro Duque Vieira
Date: Tuesday, October 17, 2023 at 05:57
To: Andy Goryachev
Cc: openjfx-dev@openjdk.org
Subject: Re: [External] : Re: [Request for Comments] Behavior / InputMap
Yes Input Map
From: Pedro Duque Vieira
Talking about the Skin discussion:
Right now, I think Skins do both the Controller and View part of a Control,
making it really difficult to replace, extend, etc a Control's Skin...
I would have to think much more about this but I could see some kind of View
class that S
On Tue, 17 Oct 2023 04:46:12 GMT, Michael Strauß wrote:
> As of OpenJFX 21, `EventTarget` has methods to add and remove event listeners.
> The `instanceof` checks in `com.sun.javafx.scene.control.ListenerHelper`
> should be removed and replaced by a simple call to the respective interface
> met
On Tue, 10 Oct 2023 23:24:05 GMT, Kevin Rushforth wrote:
> Release notes for JavaFX 21.0.1.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=44663
>
> The original filter, with the backport IDs, is here:
>
> https://bugs.
Dear Nir:
Thank you so much for the information. I spoke to several people none of whom,
unfortunately, use an environment configured for RTL mode (but who have
keyboard settings for RTL languages). Based on the very small sample, it
appears that logical navigation is a way to go - which mean
Thanks. To answer the one outstanding question from your earlier reply:
It would be a great future feature if we can somehow automatically
remove the issues that are introduced in the same version.
Yes, it would. As of now, we don't have a robust way to do it, but I'll
give it some thought.
On Tue, 10 Oct 2023 23:24:05 GMT, Kevin Rushforth wrote:
> Release notes for JavaFX 21.0.1.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=44663
>
> The original filter, with the backport IDs, is here:
>
> https://bugs.
No, you are right.
All good, I approved.
- Johan
On Tue, Oct 17, 2023 at 4:50 PM Kevin Rushforth
wrote:
> We need to exclude from the release notes any backport with a fix version
> of 21.0.1 and an hgupdate-sync label. Those bugs were fixed in 21 and are
> already in the release notes for 21.
We need to exclude from the release notes any backport with a fix
version of 21.0.1 and an hgupdate-sync label. Those bugs were fixed in
21 and are already in the release notes for 21.
Do you have an example where you think the JBS filter excluded something
it should not have?
-- Kevin
On
There were no security fixes for the just-released October CPU,
including JavaFX 21.0.1. I pushed the 21.0.1 tags to openjdk/jfx21u,
including the 21.0.1-ga tag.
-- Kevin
Hi Kevin,
After a second look, I'm not sure about excluding the issues with a
hgupdate-sync label. From a previous mail, I understood that those have to
be removed in the release notes of jfx22, but from the backports?
- Johan
On Tue, Oct 17, 2023 at 4:10 PM Kevin Rushforth wrote:
> Release no
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
Looks good, I'm double checking and will approve.
It would be a great future feature if we can somehow automatically remove
the issues that are introduced in the same version.
- Johan
Op di 17 okt 2023 om 16:10 schreef Kevin Rushforth :
> Release notes for JavaFX 21.0.1.
>
> Notes to reviewers:
On Tue, 17 Oct 2023 04:46:12 GMT, Michael Strauß wrote:
> As of OpenJFX 21, `EventTarget` has methods to add and remove event listeners.
> The `instanceof` checks in `com.sun.javafx.scene.control.ListenerHelper`
> should be removed and replaced by a simple call to the respective interface
> met
On Tue, 17 Oct 2023 11:04:03 GMT, Nir Lisker wrote:
> By the way, isn't `IDisconnectable` just a `Subscription` with less gadgets?
it's a functional interface, so no gadgets at all.
-
PR Comment: https://git.openjdk.org/jfx/pull/1262#issuecomment-1766533941
Release notes for JavaFX 21.0.1.
Notes to reviewers:
I used the following filter to pick the issues:
https://bugs.openjdk.org/issues/?filter=44663
The original filter, with the backport IDs, is here:
https://bugs.openjdk.org/issues/?filter=44662
As usual, I excluded test bugs, cleanup bugs, e
On Tue, 10 Oct 2023 23:24:05 GMT, Kevin Rushforth wrote:
> Release notes for JavaFX 21.0.1.
>
> Notes to reviewers:
>
> I used the following filter to pick the issues:
>
> https://bugs.openjdk.org/issues/?filter=44663
>
> The original filter, with the backport IDs, is here:
>
> https://bugs.
On Tue, 5 Sep 2023 07:17:57 GMT, Johan Vos wrote:
>> Hima Bindu Meda has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> change minimum version for mac to 3.6
>
> I think that should be ok for now, and I don't want to make the PR more
> com
Yes Input Map would be a welcome addition.
--
Talking about the Skin discussion:
Right now, I think Skins do both the Controller and View part of a Control,
making it really difficult to replace, extend, etc a Control's Skin...
I would have to think much more about this but I could see some kind
Yes please keep this open.
Having adequate Theme development support would be great and I think
wouldn't require much effort (right now custom theme support in JavaFX is
faulty IMO).
Looking forward to the StyleTheme API so you can define multiple
stylesheets as user agent stylesheets.
(sorry to
Because of a missing conditional check in the `updateTextPos()`, the
`textTranslateX` value was not getting updated when TextField size was changed
as a result of resizing window.
Updated the CENTER and LEFT cases in the `updateTextPos()` method to fix the
issue.
The fix can be validated usin
On Thu, 12 Oct 2023 05:52:04 GMT, Martin Fox wrote:
> When a window is visible the maximized, iconified, and fullscreen properties
> are two-way streets; changes made in Java are sent on to the platform window
> and changes in the platform window are sent back into Java.
>
> When a window is h
On Tue, 17 Oct 2023 04:46:12 GMT, Michael Strauß wrote:
> As of OpenJFX 21, `EventTarget` has methods to add and remove event listeners.
> The `instanceof` checks in `com.sun.javafx.scene.control.ListenerHelper`
> should be removed and replaced by a simple call to the respective interface
> met
I have just tested on Win10: Notepad, Wordpad, MSWord 2021, Discord
desktop, WhatsApp desktop, Opera, Eclipse, Gimp 2, Audacity 2.1.3, and MS
VisualStudio 2022 all use logical. Edge uses logical in text areas and text
fields, but visual in the address bar (seems like a bug, but you can't have
space
On Tue, 17 Oct 2023 09:23:16 GMT, Florian Kirmaier
wrote:
> It would be nice if something could be decided here.
>
> Another option would be, to rename the current method to something like
> getWidthInPoints() which then can be used internally. But the old - now
> correct methods - can be exp
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the conc
Hi all,
As mentioned to Kevin and Johan at Devoxx: I was wondering how hard it would be
to add CDI support for custom controls that are added via FXML. At the moment
we always have to set various fields on custom controls inside the controller
class. It would be great if this could be streamlin
Replying here, for some reason I did not receive your original message
Martin.
In reply to Martin's comments:
Thanks for looking into the event handling system already; I'm certain
there are some solutions here that can keep internals and user event
handlers seperated, and you found a few alt
On Tue, 17 Oct 2023 04:46:12 GMT, Michael Strauß wrote:
> As of OpenJFX 21, `EventTarget` has methods to add and remove event listeners.
> The `instanceof` checks in `com.sun.javafx.scene.control.ListenerHelper`
> should be removed and replaced by a simple call to the respective interface
> met
37 matches
Mail list logo
