On Fri, 4 Aug 2023 18:13:34 GMT, Marius Hanl wrote:
> Before, the `updateItem` method was called with the new value that was
> committed via `commitEdit()`.
> This is problematic as developers may setup a commit handler via
> `setOnEditCommit`, which may reject the edit (or change the value oth
> Minimum version of python ,to run webkit build , on linux is set to 3.6 and
> for other platforms, minimum version of python is set to 3.8.
>
> Verified build on all platforms. No issue seen
Hima Bindu Meda has updated the pull request with a new target base due to a
merge or a rebase. The in
Dear John:
Thanks again for a detailed response!
I noticed a theme that perhaps we should discuss first. It looks like there is
a desire to have:
1. stateless, shared behavior
2. behavior separated from the skin
3. input map as a separate entity (or entity that can be used by any Nod
On Tue, 10 Oct 2023 17:39:53 GMT, Ambarish Rapte wrote:
> Upgrade gradle to version 8.4.
> It also includes a change for adding task dependency for windows platform
> that was missed in [JDK-8314486](https://bugs.openjdk.org/browse/JDK-8314486)
Looks good. I tested on Windows and confirm that i
On Tue, 10 Oct 2023 17:39:53 GMT, Ambarish Rapte wrote:
> Upgrade gradle to version 8.4.
> It also includes a change for adding task dependency for windows platform
> that was missed in [JDK-8314486](https://bugs.openjdk.org/browse/JDK-8314486)
@johanvos or @tiainen can one of you be the second
Upgrade gradle to version 8.4.
It also includes a change for adding task dependency for windows platform that
was missed in [JDK-8314486](https://bugs.openjdk.org/browse/JDK-8314486)
-
Commit messages:
- chmod 644 gradlew
- fix win task dependency
- upgrade gradle to 8.4
Changes:
> Yes, one of the features the new design provides is ability to modify key
> mappings by the user at runtime. So yes, not only it needs to be mutable,
> but it also adds some APIs for exactly that.
>
I struggle to see a use case for this feature. I can imagine that
there might be some use case
On Tue, 10 Oct 2023 16:24:42 GMT, John Neffenger wrote:
>> Please review these changes to the build timestamp and to the JavaFX runtime
>> version available in the system properties.
>
> John Neffenger has updated the pull request incrementally with one additional
> commit since the last revisi
> Please review these changes to the build timestamp and to the JavaFX runtime
> version available in the system properties.
John Neffenger has updated the pull request incrementally with one additional
commit since the last revision:
Update the documentation in UPDATING-VERSION.md
-
On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote:
> Please review these changes to the build timestamp and to the JavaFX runtime
> version available in the system properties.
Thanks, Kevin. I'll fix that.
To all reviewers: I added tests of the method
[VersionInfo.setupSystemProperties][1
On 09/10/2023 22:24, Andy Goryachev wrote:
Dear John:
Thank you for a very thoughtful analysis! I wanted to initiate a
discussion, with the goal of making FX better. Let me try to respond
to your comments.
The main odd thing that jumps out immediately is the fact that
Behaviors and Input
On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote:
> Please review these changes to the build timestamp and to the JavaFX runtime
> version available in the system properties.
The fix and new test both look good. Testing is green.
Can you also change the following in
[`UPDATING-VERSION.md
On Mon, 14 Aug 2023 15:52:03 GMT, Hima Bindu Meda wrote:
>> I tested this on my MacBook Pro running macOS 13.3.1 and discovered that it
>> has python 3.7.x:
>>
>>
>> Could NOT find Python3: Found unsuitable version "3.7.3", but required is
>> at least "3.8.0" (found /usr/bin/python3, found
On Mon, 9 Oct 2023 14:56:39 GMT, Ambarish Rapte wrote:
> This is gradle only change, which fixes few warnings that are observed with
> gradle 7.6 and which eventually result to an error with gradle 8.3
> With this change the warnings get fixed and no error is observed with gradle
> 8.3
> Verifi
On Mon, 9 Oct 2023 21:06:36 GMT, Ambarish Rapte wrote:
>> This is gradle only change, which fixes few warnings that are observed with
>> gradle 7.6 and which eventually result to an error with gradle 8.3
>> With this change the warnings get fixed and no error is observed with gradle
>> 8.3
>> V
On Mon, 9 Oct 2023 21:06:36 GMT, Ambarish Rapte wrote:
>> This is gradle only change, which fixes few warnings that are observed with
>> gradle 7.6 and which eventually result to an error with gradle 8.3
>> With this change the warnings get fixed and no error is observed with gradle
>> 8.3
>> V
On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote:
> Please review these changes to the build timestamp and to the JavaFX runtime
> version available in the system properties.
@tiainen can you review?
-
PR Comment: https://git.openjdk.org/jfx/pull/1253#issuecomment-1754743752
17 matches
Mail list logo
