Re: RFR: 8296266: TextArea: Navigation breaks with RTL text

2023-10-04 Thread Andy Goryachev
On Tue, 22 Aug 2023 20:46:21 GMT, Andy Goryachev wrote: > The fix uses character BreakIterator instead of the logic that relies on > caretBounds/hitTest/rangeShape in TextInputControl.nextCharacterVisually(). > > I believe this is a more reliable method of navigation, as it behaves in sync > w

Re: [Request for Comments] Behavior / InputMap

2023-10-04 Thread Andy Goryachev
This pull request https://github.com/openjdk/jfx/pull/1254 demonstrates migration to public InputMap for a subset of controls: * ColorPicker * ComboBox * DatePicker * PasswordField * TextArea * TextField These controls were selected to migrate first based on them being

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-10-04 Thread John Neffenger
On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. This pull request makes three changes: 1. The ISO 8601 extended format of the build date and time is now used only

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-10-04 Thread Kevin Rushforth
On Mon, 2 Oct 2023 22:06:38 GMT, John Neffenger wrote: > Please review these changes to the build timestamp and to the JavaFX runtime > version available in the system properties. I'll take a closer look, and also test this, when I can. This looks like the right approach to me. It should not c

RFR: 8317370: JavaFX runtime version is wrong at runtime

2023-10-04 Thread John Neffenger
Please review these changes to the build timestamp and to the JavaFX runtime version available in the system properties. - Commit messages: - 8317370: JavaFX runtime version is wrong at runtime Changes: https://git.openjdk.org/jfx/pull/1253/files Webrev: https://webrevs.openjdk.or

Re: 5s Sonoma delay - patches planned?

2023-10-04 Thread Kevin Rushforth
The fix for this bug will be in the quarterly update release of 21.x and 17.x, which will ship on Oct 17th. In the most extreme of circumstances, we could do a patch release, but a non-fatal bug such as this that manifests only on a brand new OS doesn't warrant the effort of a patch release.

Re: 5s Sonoma delay - patches planned?

2023-10-04 Thread Abhinay Agarwal
Hi Florian, It has already been backported to 17 and 21. Please check the issue JDK-8315657 for more information. BR, Abhinay On 04-Oct-2023, at 4:13 PM, Florian Kirmaier wrote: Hi everyone, There is this bug that causes Mac to take another 5s to start. It's already fixed: https://github.com

5s Sonoma delay - patches planned?

2023-10-04 Thread Florian Kirmaier
Hi everyone, There is this bug that causes Mac to take another 5s to start. It's already fixed: https://github.com/openjdk/jfx/pull/1247 Is it planned to make hotfix-versions, for 21 and 17? This bug is actually quite critical. Greetings Florian

Re: RFR: 8296266: TextArea: Navigation breaks with RTL text

2023-10-04 Thread Karthik P K
On Tue, 22 Aug 2023 20:46:21 GMT, Andy Goryachev wrote: > The fix uses character BreakIterator instead of the logic that relies on > caretBounds/hitTest/rangeShape in TextInputControl.nextCharacterVisually(). > > I believe this is a more reliable method of navigation, as it behaves in sync > w

Re: RFR: 8296266: TextArea: Navigation breaks with RTL text

2023-10-04 Thread Ajit Ghaisas
On Tue, 22 Aug 2023 20:46:21 GMT, Andy Goryachev wrote: > The fix uses character BreakIterator instead of the logic that relies on > caretBounds/hitTest/rangeShape in TextInputControl.nextCharacterVisually(). > > I believe this is a more reliable method of navigation, as it behaves in sync > w