> This replaces obsolete XIM and uses gtk api for IME.
> Gtk uses [ibus](https://github.com/ibus/ibus)
>
> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
> positioning on `InputMethodRequest`.
>
> [Screencast from 17-09-2023
> 21:59:04.webm](https://github.com/openj
> This replaces obsolete XIM and uses gtk api for IME.
> Gtk uses [ibus](https://github.com/ibus/ibus)
>
> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
> positioning on `InputMethodRequest`.
>
> [Screencast from 17-09-2023
> 21:59:04.webm](https://github.com/openj
It looks like a condition between calls from `set_visible` to `request_focus`.
When `request_focus` is called, the window is not yet mapped (map is requested
on `set_visible`).
200x200 is the default gtk window size if none is specified. Since the window
is presented at the requested size and
On Wed, 27 Sep 2023 15:32:17 GMT, Phil Race wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> Changes requested by prr (Reviewer).
> @prrace could you please take a look at this?
Hmm. I did last
On Mon, 21 Aug 2023 18:25:08 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when hitTest was invoked for
>> Text node in a TextFlow with more than one Text child. Hence wrong character
>> index value
On Wed, 27 Sep 2023 15:18:31 GMT, Andy Goryachev wrote:
>> I copied it from `getTextLocation`, but you're right.
>
> the null is in the @param block
Ah, I see. Oops. I suspect it was intended on the `@return`, but now I'm not
sure.
-
PR Review Comment: https://git.openjdk.org/jfx/
On Wed, 27 Sep 2023 15:15:15 GMT, Thiago Milczarek Sayao
wrote:
>> The return type is Point2D, not int.
>>
>> But I'm glad you commented on it. I hadn't looked at this PR at all. Adding
>> a method to a public interface is an API change, so at a minimum needs a
>> CSR. More problematic is tha
On Wed, 27 Sep 2023 15:19:47 GMT, Andy Goryachev wrote:
> I was also having second thoughts - 2 reviewers might be insufficient. 3 is
> better. thanks!
My comment crossed yours in the ether (I responded too quickly before seeing
that you had bumped the reviewers and requested a CSR). I put it
On Wed, 27 Sep 2023 15:12:58 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/input/InputMethodRequests.java
>> line 61:
>>
>>> 59: * inserted.
>>> 60: *
>>> 61: * @param offset the offset within the composed text, if there is
>>
>> how can an in
On Wed, 20 Sep 2023 23:02:32 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
On Wed, 20 Sep 2023 23:02:32 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
On Wed, 20 Sep 2023 23:02:32 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
On Wed, 20 Sep 2023 23:02:32 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
On Mon, 28 Aug 2023 11:22:56 GMT, Karthik P K wrote:
>> The old logic for cursor movement was buggy when both RTL and LTR text was
>> present in the TextField. Used character BreakIterator instead of finding
>> the character index using hitTest.
>>
>> Added system test to validate the fix.
>
>
On Mon, 21 Aug 2023 18:25:08 GMT, Karthik P K wrote:
>> The text run selected in `PrismTextLayout::getHitInfo()` method for
>> character index calculation was not correct when hitTest was invoked for
>> Text node in a TextFlow with more than one Text child. Hence wrong character
>> index value
On Wed, 20 Sep 2023 23:02:32 GMT, Thiago Milczarek Sayao
wrote:
>> This replaces obsolete XIM and uses gtk api for IME.
>> Gtk uses [ibus](https://github.com/ibus/ibus)
>>
>> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative
>> positioning on `InputMethodRequest`.
>>
On Tue, 26 Sep 2023 19:11:22 GMT, Jose Pereda wrote:
> Clean backport of 8315657: Application window not activated in macOS 14 Sonoma
> Reviewed-by: jpereda, aghaisas
This pull request has now been integrated.
Changeset: 7b3027a7
Author:Jose Pereda
URL:
https://git.openjdk.org/jfx17
17 matches
Mail list logo
