Withdrawn: 8311216: DataURI can lose information in some charset environments

2023-09-04 Thread duke
On Sat, 1 Jul 2023 22:24:09 GMT, Michael Strauß wrote: > DataURI uses the following implementation to decode the percent-encoded > payload of a "data" URI: > > > ... > String data = uri.substring(dataSeparator + 1); > Charset charset = Charset.defaultCharset(); > ... > URLDecoder.decode(data.r

Re: RFR: 8301302: Platform preferences API [v4]

2023-09-04 Thread Michael Strauß
On Thu, 24 Aug 2023 21:32:18 GMT, Andy Goryachev wrote: > It looks like the discussion in the mailing list resolved some of the > questions the group posed, perhaps we could move forward. > > Would it be possible to extract read-only platform preferences into a > separate PR in order to integr

Re: RFR: 8301302: Platform preferences API [v5]

2023-09-04 Thread Michael Strauß
> Please read [this > document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for > an introduction to the Platform Preferences API, and how it interacts with > the proposed style theme and stage appearance features. Michael Strauß has updated the pull request incrementally wi

Re: RFR: JDK-8199216: Quadratic layout time with nested nodes and pseudo-class in style sheet [v8]

2023-09-04 Thread Johan Vos
On Wed, 16 Aug 2023 14:16:23 GMT, John Hendrikx wrote: >> Thanks for that test, actually it could be used as part of a test in >> PseudoClassTest, to verify that the old implementation failed and the new >> one worked? >> >> And this brings up another issue: the constructor `PseudoClassState(L

RFR: 8314779: [testbug] Add test to all the XYCharts to check if chart components are removed when series is cleared

2023-09-04 Thread Karthik P K
Added test: `testChartLineAndAreaRemovedOnClearingSeries()` for `StackedAreaChart` to check if the line and fill elements gets removed from the series on clearing the series. This test is added similar to the tests added to `LineChart` and `AreaChart`. This test is not required for `BarChart`, `

RFR: 8308608: [testbug] Use Util::waitForIdle instead of Toolkit::firePulse in system tests

2023-09-04 Thread Karthik P K
Made changes to use Util::waitForIdle instead of Toolkit::firePulse in system tests. The test will wait for default value of 10 pulses to complete in the scene before executing the subsequent statements. - Commit messages: - Use Util::waitForIdle instead of Toolkit::firePulse Chan

Re: [jfx-tests] RFR: JDK-8315409: Fix jfx-tests so they work with latest jfx build [v2]

2023-09-04 Thread Ajit Ghaisas
On Sat, 2 Sep 2023 00:31:26 GMT, Alexandre Iline wrote: >> JDK-8315409: Fix jfx-tests so they work with latest jfx build > > Alexandre Iline has updated the pull request incrementally with one > additional commit since the last revision: > > Addressing copyright issues. I verified that the f

Re: RFR: JDK-8199216: Quadratic layout time with nested nodes and pseudo-class in style sheet [v8]

2023-09-04 Thread Johan Vos
On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote: >> This fix introduces immutable sets of `PseudoClass` almost everywhere, as >> they are rarely modified. These are re-used by caching them in a new class >> `ImmutablePseudoClassSetsCache`. >> >> In order to make this work, `BitSet` had t

Re: RFR: JDK-8199216: Quadratic layout time with nested nodes and pseudo-class in style sheet [v8]

2023-09-04 Thread Johan Vos
On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote: >> This fix introduces immutable sets of `PseudoClass` almost everywhere, as >> they are rarely modified. These are re-used by caching them in a new class >> `ImmutablePseudoClassSetsCache`. >> >> In order to make this work, `BitSet` had t

[jfx17u] RFR: 8089280: horizontal scrollbar should never become visible in TableView with constrained resize policy

2023-09-04 Thread Jose Pereda
Almost clean backport of 8089280: horizontal scrollbar should never become visible in TableView with constrained resize policy Reviewed-by: kcr, aghaisas It had some minor conflicts from JDK-8089280 (TableViewSkinBase: copyright year, and TableViewTest, TreeTableViewTest: wrong insertion point

Re: RFR: 8251240: Menus inaccessible on Linux with i3 wm

2023-09-04 Thread Johan Vos
On Sun, 9 Jul 2023 17:43:05 GMT, Thiago Milczarek Sayao wrote: > The bug happens because `gdk_window_get_frame_extents` is not returning the > correct position when o i3-wm, probably by some bug on the wm itself. > > Te fix replaces the usage of the function for already known extents value >