Re: RFR: 8313556: Create implementation of NSAccessibilitySlider protocol [v3]

> Create implementation for Slider and Stepper accessibility protocols. > Fix mapping. > Fix performAction parameter type in declaration. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Fixing warnings during build - C

Re: RFR: 8315074: Possible null pointer access in native glass [v2]

On Tue, 29 Aug 2023 07:03:32 GMT, Marius Hanl wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix typo > > modules/javafx.graphics/src/main/native-glass/gtk/GlassApplication.cpp line > 270: > >> 268: //

Re: RFR: 8315074: Possible null pointer access in native glass [v2]

> At multiple places in native glass code we don't have appropriate NULL checks > which might result in null pointer access. > > Added appropriate checks and all test run is green. Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: F

Re: RFR: 8311097: Synchron XMLHttpRequest not receiving data

On Wed, 30 Aug 2023 14:32:37 GMT, Andrew Brygin wrote: > This issue is a regression from 7e48413eb0 8285881: Update WebKit to 614.1. > For synchronous requests, we have an additional buffer to collect data, and > the appending data into this buffer is doing in a wrong way: we use > Vector::a

RFR: 8311097: Synchron XMLHttpRequest not receiving data

This issue is a regression from 7e48413eb0 8285881: Update WebKit to 614.1. For synchronous requests, we have an additional buffer to collect data, and the appending data into this buffer is doing in a wrong way: we use Vector::append(U&& u), which adds only the first data element. Instead, we

Re: RFR: 8313556: Create implementation of NSAccessibilitySlider protocol [v2]

On Tue, 29 Aug 2023 20:14:44 GMT, Alexander Zuev wrote: >> Create implementation for Slider and Stepper accessibility protocols. >> Fix mapping. >> Fix performAction parameter type in declaration. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since th

Re: RFR: 8296266: TextArea: Navigation breaks with RTL text

On Tue, 22 Aug 2023 20:46:21 GMT, Andy Goryachev wrote: > The fix uses character BreakIterator instead of the logic that relies on > caretBounds/hitTest/rangeShape in TextInputControl.nextCharacterVisually(). > > I believe this is a more reliable method of navigation, as it behaves in sync > w

Re: [jfx21u] RFR: Merge jfx:jfx21 [v2]

> Merge `jfx:jfx21` branch into `jfx21u:master` (21.0.1 is a superset of 21). Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additio

[jfx21u] Integrated: Merge jfx:jfx21

On Wed, 30 Aug 2023 11:15:53 GMT, Kevin Rushforth wrote: > Merge `jfx:jfx21` branch into `jfx21u:master` (21.0.1 is a superset of 21). This pull request has now been integrated. Changeset: 08f2f877 Author:Kevin Rushforth URL: https://git.openjdk.org/jfx21u/commit/08f2f8773fb6d05ad8a

[jfx21u] RFR: Merge jfx:jfx21

Merge `jfx:jfx21` branch into `jfx21u:master` (21.0.1 is a superset of 21). - Commit messages: - Merge remote-tracking branch 'jfx/jfx21' into merge-2023-08-30 - 8312058: Documentation improvements for subscription based listeners The merge commit only contains trivial merges, so n

Re: RFR: 8262518: SwingNode.setContent does not close previous content, resulting in memory leak [v5]

On Fri, 25 Aug 2023 03:36:53 GMT, Prasanta Sadhukhan wrote: >> Issue is when setting the content of a SwingNode, the old content is not >> garbage collected owing to the fact >> JLightweightFrame is never being released by SwingNodeDisposer >> >> The SwingNodeDisposer holds an hard pointer to