Re: [External] : Re: Preload fxml to avoid slow show()

2023-08-25 Thread Andy Goryachev
1. which version of jdk/jfx are you using? 2. have you tried profiling your application during FXML loading? 3. have you tried looking at the heap allocation (using VisualVM or a similar tool), to see where the bulk of memory consumption is? -andy From: Davide Perini Date: Friday, August 25, 20

Re: [External] : Re: Preload fxml to avoid slow show()

2023-08-25 Thread Davide Perini
I tried it, 99% of the heavy lift comes from FXML load. I have 80Kb of FXML files, nothing particularly big, I measured the laoding time on a 13900K CPU and it requires 1.8s. Once loaded, I don't know how this is possible, my apps sucks 100MB more RAM but after the first load, opening/closing t

Re: [JavaFX 3D ( | Feature Request)] Setting Texture Nearest-Sampling on PhongMaterial

2023-08-25 Thread Nir Lisker
I've done a preliminary study and assessment for changes in regards to textures. Texture metadata (addressing, filtering, wrapping, blending...) is supported by both OpenGL and D3D in a similar enough way that makes a uniform API possible and not convoluted. This metadata can be added to Texture,

Re: [External] : Re: Preload fxml to avoid slow show()

2023-08-25 Thread Andy Goryachev
Another suggestion might be to load tabs lazily. I don't think FXML "pre-loading" is possible. -andy From: Davide Perini Date: Friday, August 25, 2023 at 14:31 To: Andy Goryachev , openjfx-dev@openjdk.org Subject: [External] : Re: Preload fxml to avoid slow show() My tab pane is very compl

RFR: 8296266: TextArea: Navigation breaks with RTL text

2023-08-25 Thread Andy Goryachev
The fix uses character BreakIterator instead of the logic that relies on caretBounds/hitTest/rangeShape in TextInputControl.nextCharacterVisually(). I believe this is a more reliable method of navigation, as it behaves in sync with the jdk break iterator, thought it might work differently around

Re: Preload fxml to avoid slow show()

2023-08-25 Thread Davide Perini
My tab pane is very complex with a lot of tabs, having an FXML is very welcomed. Thanks Davide Il 25/08/2023 16:45, Andy Goryachev ha scritto: You can try creating the scene graph programmatically, thus avoiding FXML entirely. -andy *From: *openjfx-dev on behalf of Davide Perini *Date:

Re: RFR: 8242616: Regression: RTL - TextField Cursor Movement Via Keyboard

2023-08-25 Thread Andy Goryachev
On Fri, 25 Aug 2023 11:41:22 GMT, Karthik P K wrote: > The old logic for cursor movement was buggy when both RTL and LTR text was > present in the TextField. Used character BreakIterator instead of finding the > character index using hitTest. > > Added system test to validate the fix. tests/s

Re: RFR: 8242616: Regression: RTL - TextField Cursor Movement Via Keyboard

2023-08-25 Thread Andy Goryachev
On Fri, 25 Aug 2023 11:41:22 GMT, Karthik P K wrote: > The old logic for cursor movement was buggy when both RTL and LTR text was > present in the TextField. Used character BreakIterator instead of finding the > character index using hitTest. > > Added system test to validate the fix. modules

Re: Preload fxml to avoid slow show()

2023-08-25 Thread Andy Goryachev
You can try creating the scene graph programmatically, thus avoiding FXML entirely. -andy From: openjfx-dev on behalf of Davide Perini Date: Friday, August 25, 2023 at 00:45 To: openjfx-dev@openjdk.org Subject: Preload fxml to avoid slow show() Hi, I have a tabpane with 15 tabs, every tab h

Re: RFR: 8242616: Regression: RTL - TextField Cursor Movement Via Keyboard

2023-08-25 Thread Karthik P K
On Fri, 25 Aug 2023 11:41:22 GMT, Karthik P K wrote: > The old logic for cursor movement was buggy when both RTL and LTR text was > present in the TextField. Used character BreakIterator instead of finding the > character index using hitTest. > > Added system test to validate the fix. The fix

RFR: 8242616: Regression: RTL - TextField Cursor Movement Via Keyboard

2023-08-25 Thread Karthik P K
The old logic for cursor movement was buggy when both RTL and LTR text was present in the TextField. Used character BreakIterator instead of finding the character index using hitTest. Added system test to validate the fix. - Commit messages: - Fix TextField cursor movement issue

Preload fxml to avoid slow show()

2023-08-25 Thread Davide Perini
Hi, I have a tabpane with 15 tabs, every tab has his own controller and it's pretty crowded. On a 13900K CPU, show() method requires more than 750ms, this feels laggy... After the first show() call, loading the tab pane is much faster... Is there a way to "preload" an fxml? I tried to show()