On Mon, 3 Jul 2023 15:49:31 GMT, Jose Pereda wrote:
> This PR adds a check to the Animation and AnimationTimer public methods to
> verify that these are called from the JavaFX Application thread. If the call
> is done from any other thread, an IllegalStateException will be thrown.
>
> This wil
On Mon, 14 Aug 2023 18:38:39 GMT, Alexander Zuev wrote:
>> also
>> 8309629: Create implementation of NSAccessibilityRadioButton protocol
>>
>> Create implementation of NSAccessibilityCheckBox and
>> NSAccessibilityRadioButton protocols
>> Add workaround for the wrong focus owner announcement wi
On Mon, 7 Aug 2023 14:10:09 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line
>> 174:
>>
>>> 172: jobject jresult = NULL;
>>> 173: GET_MAIN_JENV;
>>> 174: if (env == NULL) return NULL;
>>
>> This generates a warning:
>> `war
On Fri, 4 Aug 2023 07:36:08 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TableViewSkinTest.java
>> line 79:
>>
>>> 77: @Test
>>> 78: void testInitialColumnResizeNodePositions() {
>>> 79: TableView tableView = new TableView<>();
> also
> 8309629: Create implementation of NSAccessibilityRadioButton protocol
>
> Create implementation of NSAccessibilityCheckBox and
> NSAccessibilityRadioButton protocols
> Add workaround for the wrong focus owner announcement with radio buttons
> Add workaround for wrong magnifier text on bu
On Mon, 14 Aug 2023 16:46:33 GMT, Andy Goryachev wrote:
>> - Fixed by checking for `NULL` pointer after memory allocation.
>> - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint`
>> array, so `new` will return `NULL` instead of throwing exception. This done
>> for consistenc
On Mon, 7 Aug 2023 23:33:37 GMT, Alexander Matveev wrote:
> - Fixed by checking for `NULL` pointer after memory allocation.
> - In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint`
> array, so `new` will return `NULL` instead of throwing exception. This done
> for consistency
A KeyCharacterCombination should match a key if the target character is printed
on that key. For example, the user should be able to invoke the `Shortcut+'+' `
combination by holding down the Shortcut key and pressing a key that has '+'
printed on it. This should work even if '+' is a shifted sy
On Thu, 10 Aug 2023 23:00:11 GMT, Kevin Rushforth wrote:
> I tested this on my MacBook Pro running macOS 13.3.1 and discovered that it
> has python 3.7.x:
>
> ```
> Could NOT find Python3: Found unsuitable version "3.7.3", but required is
> at least "3.8.0" (found /usr/bin/python3, found co
> Minimum version of python ,to run webkit build , on linux is set to 3.6 and
> for other platforms, minimum version of python is set to 3.8.
>
> Verified build on all platforms. No issue seen
Hima Bindu Meda has updated the pull request incrementally with one additional
commit since the last r
On Mon, 14 Aug 2023 13:16:06 GMT, Johan Vos wrote:
> > Yes, it would do. In this case, I presume that this PR is dependent on PR
> > #1070, which will have a CSR. Once that is integrated, and the updated
> > master is merged into this PR branch, I expect that all changes to public
> > API in t
On Mon, 31 Jul 2023 17:47:06 GMT, Jose Pereda wrote:
>> This PR adds a check to the Animation and AnimationTimer public methods to
>> verify that these are called from the JavaFX Application thread. If the call
>> is done from any other thread, an IllegalStateException will be thrown.
>>
>> Th
On Mon, 14 Aug 2023 15:04:28 GMT, Jose Pereda wrote:
> Makes sense, I've updated the title of both JBS issue and CSR.
@jperedadnr You also need to update this PR title. Also, please "Finalize" the
CSR when ready, since that will trigger the final review of the CSR.
-
PR Comment: h
On Mon, 31 Jul 2023 17:47:06 GMT, Jose Pereda wrote:
>> This PR adds a check to the Animation and AnimationTimer public methods to
>> verify that these are called from the JavaFX Application thread. If the call
>> is done from any other thread, an IllegalStateException will be thrown.
>>
>> Th
On Fri, 11 Aug 2023 22:03:28 GMT, John Hendrikx wrote:
>> Incorporates documentation review comments from #1069.
>>
>> This PR should be kept minimal so it can be backported to JFX21; it should
>> only contain documentation changes.
>
> John Hendrikx has updated the pull request incrementally w
On Mon, 31 Jul 2023 17:39:29 GMT, Jose Pereda wrote:
>> This PR adds a check to the Animation and AnimationTimer public methods to
>> verify that these are called from the JavaFX Application thread. If the call
>> is done from any other thread, an IllegalStateException will be thrown.
>>
>> Th
I answer my self for posters...
.table-view .table-cell {
-fx-alignment:center-left;
}
done the trick.
thanks
Davide
Il 14/08/2023 15:34, Davide Perini ha scritto:
Hi all,
hope that someone can help with this :)
I have a TableView like this:
If I add a remove button in the table like
Hi all,
hope that someone can help with this :)
I have a TableView like this:
If I add a remove button in the table like this:
private TableColumngetSatelliteVoidTableColumn() {
TableColumn colBtn =new TableColumn<>("");
colBtn.setMaxWidth(Constants.REMOVE_BTN_TABLE);
Callback, Ta
On Fri, 9 Jun 2023 12:45:02 GMT, John Hendrikx wrote:
>> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
>> they are rarely modified. These are re-used by caching them in a new class
>> `ImmutablePseudoClassSetsCache`.
>>
>> In order to make this work, `BitSet` had t
On Tue, 25 Apr 2023 05:36:32 GMT, John Hendrikx wrote:
> > Match is a public class, does this PR need a CSR?
>
> Yes, it would do. In this case, I presume that this PR is dependent on PR
> #1070, which will have a CSR. Once that is integrated, and the updated master
> is merged into this PR br
On Fri, 11 Aug 2023 12:10:01 GMT, Kevin Rushforth wrote:
> The code change looks good. However, the new test passes for me either with
> or without your fix.
Hi Kevin, I re-looked into the test. The test seems to be insufficient to test
the change.
That test and other test in the file Clipboar
> The mime name should be exactly same as the mime type supported by platform.
> Hence the comparison should not match partially similar names.
> Added an invalid unit test.
>
> @kevinrushforth @jayathirthrao please review
Ambarish Rapte has updated the pull request incrementally with one additio
22 matches
Mail list logo
