RFR: 8314141: Missing default for switch in CreateBitmap

2023-08-10 Thread Ambarish Rapte
This is a simple change to add a missing default statement. @kevinrushforth @jayathirthrao please review. - Commit messages: - default: return NULL; Changes: https://git.openjdk.org/jfx/pull/1206/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1206&range=00 Issue: https://

Re: RFR: 8307316: Let JavaFX be built on unknown architectures [v3]

2023-08-10 Thread John Neffenger
> Please review these changes to the Gradle build files and the dependency > verification file. The initial version of this pull request extends the > permitted build platforms for Linux to the Java architectures `arm`, > `ppc64le`, and `s390x` and adds an entry to the dependency verification fi

Re: RFR: 8307316: Let JavaFX be built on unknown architectures [v2]

2023-08-10 Thread Kevin Rushforth
On Wed, 14 Jun 2023 18:34:06 GMT, John Neffenger wrote: >> buildSrc/linux.gradle line 48: >> >>> 46: "-Wextra", "-Wall", "-Wformat-security", "-Wno-unused", >>> "-Wno-parentheses", "-Werror=trampolines"] // warning flags >>> 47: >>> 48: if (OS_ARCH == "i386") { >> >> Why was this chan

Re: RFR: 8307316: Let JavaFX be built on unknown architectures [v2]

2023-08-10 Thread Kevin Rushforth
On Tue, 13 Jun 2023 14:39:57 GMT, John Neffenger wrote: >> Please review these changes to the Gradle build files and the dependency >> verification file. The initial version of this pull request extends the >> permitted build platforms for Linux to the Java architectures `arm`, >> `ppc64le`, a

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts

2023-08-10 Thread Kevin Rushforth
On Wed, 9 Aug 2023 07:31:57 GMT, Hima Bindu Meda wrote: > Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen I tested this on my MacBook Pro running macOS

Re: RFR: 8307316: Let JavaFX be built on unknown architectures [v2]

2023-08-10 Thread John Neffenger
On Tue, 13 Jun 2023 14:39:57 GMT, John Neffenger wrote: >> Please review these changes to the Gradle build files and the dependency >> verification file. The initial version of this pull request extends the >> permitted build platforms for Linux to the Java architectures `arm`, >> `ppc64le`, a

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts

2023-08-10 Thread Kevin Rushforth
On Wed, 9 Aug 2023 07:31:57 GMT, Hima Bindu Meda wrote: > Minimum version of python ,to run webkit build , on linux is set to 3.6 and > for other platforms, minimum version of python is set to 3.8. > > Verified build on all platforms. No issue seen Reviewers: @kevinrushforth @johanvos @tiainen

Withdrawn: 8307316: Let JavaFX be built on unknown architectures

2023-08-10 Thread duke
On Wed, 3 May 2023 16:02:34 GMT, John Neffenger wrote: > Please review these changes to the Gradle build files and the dependency > verification file. The initial version of this pull request extends the > permitted build platforms for Linux to the Java architectures `arm`, > `ppc64le`, and `s