RFR: JDK-8313799: Remove lockItemOnEdit flag from (Tree)TableCell

2023-08-04 Thread Marius Hanl
The `lockItemOnEdit` only exists inside `TreeTableCell` and `TableCell` for the sake of testing. It is only changed by some JUnit tests to remove the need of setting up the whole table framework. This PR shifts this flag from those two classes to the shim classes, which are not inside the final

JavaFX 21 is in Rampdown Phase Two (RDP2)

2023-08-04 Thread Kevin Rushforth
To: JavaFX Developers As a reminder, JavaFX 21 is now in Rampdown Phase Two (RDP2). [1] P1-P2 bug fixes, and test or doc fixes of any priority, can be fixed during RDP2. Explicit approval is needed for all bug fixes and enhancements (except for doc and test fixes) to go in to the jfx21 branch

RFR: JDK-8187314: All Cells: must show backing data always

2023-08-04 Thread Marius Hanl
Before, the `updateItem` method was called with the new value that was committed via `commitEdit()`. This is problematic as developers may setup a commit handler via `setOnEditCommit`, which may reject the edit (or change the value otherwise). We therefore do call the `updateItem(-1)` which will

Re: RFR: 8276056: Control.skin.setSkin(Skin) fails to call dispose() on discarded Skin

2023-08-04 Thread Marius Hanl
On Wed, 29 Jun 2022 13:35:15 GMT, Marius Hanl wrote: > For some reason the `skinProperty` did not allow to set a new skin which is > the same class as the previous one. > This leads to multiple issues: > 1. When creating a new skin (same class as previous), the skin will likely > install some c

Re: RFR: 8091153: Customize the Table Button Menu [v5]

2023-08-04 Thread Marius Hanl
On Wed, 24 May 2023 16:55:11 GMT, Marius Hanl wrote: >> This PR implements a way to override the table column menu. >> When the `cornerRegion` is pressed, it will now call the `showColumnMenu` >> method. This new method is protected and therefore can be overidden by >> developers. If not overr

Re: RFR: 8313711: Cherry-pick WebKit 616.1 stabilization fixes

2023-08-04 Thread Kevin Rushforth
On Thu, 3 Aug 2023 17:54:48 GMT, Hima Bindu Meda wrote: > Cherry-picked commits from webkitgtk-2.40.5. > Verified build on windows, mac and linux. Sanity testing looks fine. No > issues seen Looks good. Testing is green. modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3DuplicateTa

Re: RFR: 8313711: Cherry-pick WebKit 616.1 stabilization fixes

2023-08-04 Thread Kevin Rushforth
On Fri, 4 Aug 2023 13:33:17 GMT, Kevin Rushforth wrote: >> Cherry-picked commits from webkitgtk-2.40.5. >> Verified build on windows, mac and linux. Sanity testing looks fine. No >> issues seen > > modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3DuplicateTails.cpp > line 89: > >>

Re: RFR: 8309558: Create implementation of NSAccessibilityCheckBox protocol [v2]

2023-08-04 Thread Kevin Rushforth
On Mon, 24 Jul 2023 18:34:22 GMT, Alexander Zuev wrote: >> also >> 8309629: Create implementation of NSAccessibilityRadioButton protocol >> >> Create implementation of NSAccessibilityCheckBox and >> NSAccessibilityRadioButton protocols >> Add workaround for the wrong focus owner announcement wi

Integrated: 8260342: FXMLLoader fails to load a sub layout using fx:include with the resources attribute

2023-08-04 Thread Guillaume Tâche
On Wed, 21 Jun 2023 10:43:39 GMT, Guillaume Tâche wrote: > This fixes ResourceBundle loading by calling `ResourceBundle.getBundle(value, > Locale.getDefault())` when the loader resources are null or their classloader > is null. > Apparently the original author of the bug report said they wo

Re: RFR: 8309558: Create implementation of NSAccessibilityCheckBox protocol [v2]

2023-08-04 Thread Kevin Rushforth
On Mon, 24 Jul 2023 18:34:22 GMT, Alexander Zuev wrote: >> also >> 8309629: Create implementation of NSAccessibilityRadioButton protocol >> >> Create implementation of NSAccessibilityCheckBox and >> NSAccessibilityRadioButton protocols >> Add workaround for the wrong focus owner announcement wi

Re: RFR: 8313711: Cherry-pick WebKit 616.1 stabilization fixes

2023-08-04 Thread Kevin Rushforth
On Thu, 3 Aug 2023 17:54:48 GMT, Hima Bindu Meda wrote: > Cherry-picked commits from webkitgtk-2.40.5. > Verified build on windows, mac and linux. Sanity testing looks fine. No > issues seen Note that this also contains cherry-picked commits from webkitgtk-2.40.4, since the WebKit 616.1 update

Re: RFR: JDK-8313628: Column drag header, overlay and line are not correctly aligned

2023-08-04 Thread Marius Hanl
On Thu, 3 Aug 2023 23:02:29 GMT, Andy Goryachev wrote: >> When a table has padding or the `layoutChildren` method inside the table >> skin is overridden (and x/y are modified), the drag drag header, column >> overlay and column line are not correctly aligned. >> >> The reason is that the posit