On Tue, 1 Aug 2023 10:25:33 GMT, John Hendrikx wrote:
> @prsadhuk @hjohn I'll take a closer look early next week, but I think the
> best way forward might be for Prasanta to evaluate #1189 and, if the modified
> fix in that PR is what we want to use, update _this_ PR to include the change
> th
> When the JavaFX scene is set before it is really shown, then the scale
> factors are not properly propagated to the EmbeddedWindow, resulting in
> showing wrong scales.
> Fix is made to update scales to EmbeddedWindow
Prasanta Sadhukhan has updated the pull request incrementally with one
addi
On Tue, 1 Aug 2023 17:02:33 GMT, Michael Strauß wrote:
>> Yeah, I figured as much. I just don't like code that you can't get covered
>> in a unit test, or that contradicts itself. As you can see, I was confused,
>> is it a bug or a feature? Perhaps a comment then to indicate that it's
>> in
On Tue, 1 Aug 2023 16:44:08 GMT, Michael Strauß wrote:
>> I'm not a native either, but it flows a bit better IMHO. I checked `String`
>> class, they do it like that there as well.
>
> In the `String` class, I find 10 usages of `{@code false} otherwise`, and 2
> usages of `otherwise {@code fals
On Tue, 1 Aug 2023 10:49:42 GMT, John Hendrikx wrote:
>> The constructor ensures that any spelling of "ALL" is converted to the
>> interned constant "all", which is important as we would otherwise need a
>> more computationally expensive case-insensitive string comparison in
>> `Node.Transitio
> Implementation of [CSS
> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>
> ### Example
>
> .button {
> -fx-background-color: dodgerblue;
> }
>
> .button:hover {
> -fx-background-color: red;
> -fx-scale-x: 1.1;
> -fx-scale-y: 1.1;
>
> transi
On Tue, 1 Aug 2023 13:46:15 GMT, John Hendrikx wrote:
>> That's true. However, `CssParser` is built around array-based sequences (see
>> `StringConverter.SequenceConverter`), and changing these arrays to lists
>> would seem out of place for this part of the codebase. What do you think?
>
> It d
On Tue, 1 Aug 2023 13:47:19 GMT, John Hendrikx wrote:
>> I don't see any real difference here, but then again I'm not a native
>> speaker. I'll defer to public opinion.
>
> I'm not a native either, but it flows a bit better IMHO. I checked `String`
> class, they do it like that there as well.
I have changed resouces.
DMS
--
David Smith
david.sm...@dms489.com
On Mon, 31 Jul 2023 18:20:34 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 8968:
>>
>>> 8966:
>>> 8967: for (TransitionTimer timer : transitionTimers) {
>>> 8968: if (timer.getProperty() == property) {
>>
>> minor: this prob
On Mon, 31 Jul 2023 18:16:19 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/TransitionEvent.java line
>> 88:
>>
>>> 86: * @param eventType the event type
>>> 87: * @param property the {@code StyleableProperty} that is targeted
>>> by the transition
>>>
On Mon, 31 Jul 2023 18:01:31 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/scenario/animation/StepInterpolator.java
>> line 73:
>>
>>> 71: }
>>> 72:
>>> 73: if (t >= 0 && step < 0) {
>>
>> `t >= 0` always holds, perhaps the original `t` was meant
On Mon, 31 Jul 2023 18:07:52 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/TransitionDefinitionCssMetaData.java
>> line 63:
>>
>>> 61: private static final Duration[] DURATION_ZERO = new Duration[] {
>>> Duration.ZERO };
>>> 62:
>>> 63: private
On Mon, 31 Jul 2023 06:03:58 GMT, Jay Bhaskar wrote:
> Issue: Some web worker tests fail to finish.
> Root Cause:
> sharedTimerFiredInternal function from ThreadTimers class does not require an
> isMainThread check, The check was introduced during the initial webkit
> stabilization.
This pull
On Tue, 1 Aug 2023 09:54:03 GMT, Jay Bhaskar wrote:
>> Issue: Some web worker tests fail to finish.
>> Root Cause:
>> sharedTimerFiredInternal function from ThreadTimers class does not require
>> an isMainThread check, The check was introduced during the initial webkit
>> stabilization.
>
> Jay
On Tue, 1 Aug 2023 06:59:59 GMT, Johan Vos wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/utils/NativeLibLoader.java
>> line 311:
>>
>>> 309: FileLock fileLock = fileChannel.lock()) {
>>> 310: try {
>>> 311: if (!Files.exists(p
On Tue, 1 Aug 2023 09:31:15 GMT, Marius Hanl wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/utils/NativeLibLoader.java
>> line 312:
>>
>>> 310: try {
>>> 311: if (!Files.exists(path)) {
>>> 312: Files.copy(is, path);
>>
On Tue, 1 Aug 2023 09:54:03 GMT, Jay Bhaskar wrote:
>> Issue: Some web worker tests fail to finish.
>> Root Cause:
>> sharedTimerFiredInternal function from ThreadTimers class does not require
>> an isMainThread check, The check was introduced during the initial webkit
>> stabilization.
>
> Jay
On Mon, 31 Jul 2023 18:29:19 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/TransitionDefinition.java
>> line 54:
>>
>>> 52: */
>>> 53: public TransitionDefinition(String propertyName, Duration duration,
>>> 54: Du
On Tue, 1 Aug 2023 04:46:31 GMT, Prasanta Sadhukhan
wrote:
> > @prsadhuk @hjohn I'll take a closer look early next week, but I think the
> > best way forward might be for Prasanta to evaluate #1189 and, if the
> > modified fix in that PR is what we want to use, update _this_ PR to include
> >
On Wed, 21 Jun 2023 13:34:28 GMT, Guillaume Tâche wrote:
>> This fixes ResourceBundle loading by calling
>> `ResourceBundle.getBundle(value, Locale.getDefault())` when the loader
>> resources are null or their classloader is null.
>> Apparently the original author of the bug report said the
On Mon, 31 Jul 2023 22:26:48 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add test case for worker timeout
>
> modules/javafx.web/src/test/java/test/javafx/scene/web/WebWorkerTest.java
> lin
> Issue: Some web worker tests fail to finish.
> Root Cause:
> sharedTimerFiredInternal function from ThreadTimers class does not require an
> isMainThread check, The check was introduced during the initial webkit
> stabilization.
Jay Bhaskar has updated the pull request incrementally with one a
On Mon, 31 Jul 2023 16:49:36 GMT, Andy Goryachev wrote:
>> This PR adds a file lock to the cache directory, allowing access from
>> multiple processes (that is, from more than one JVM) to that directory.
>>
>> This helps solving the issue where the cache is empty or doesn't exist yet,
>> and
On Mon, 31 Jul 2023 08:16:12 GMT, Jay Bhaskar wrote:
>> Issue: Some web worker tests fail to finish.
>> Root Cause:
>> sharedTimerFiredInternal function from ThreadTimers class does not require
>> an isMainThread check, The check was introduced during the initial webkit
>> stabilization.
>
> Ja
On Wed, 22 Feb 2023 01:11:55 GMT, Thiago Milczarek Sayao
wrote:
> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this
> scroll event type, deltas are sent to java with the value equal to zero.
>
> Here's whats happening:
>
> We include all event masks, so when using
On Mon, 31 Jul 2023 16:52:00 GMT, Andy Goryachev wrote:
>> This PR adds a file lock to the cache directory, allowing access from
>> multiple processes (that is, from more than one JVM) to that directory.
>>
>> This helps solving the issue where the cache is empty or doesn't exist yet,
>> and
27 matches
Mail list logo
