Re: RFR: 8313227: Correct attenuation indicator for removed lights

2023-07-26 Thread Nir Lisker
On Thu, 27 Jul 2023 03:39:06 GMT, Nir Lisker wrote: > A simple fix of changing the attenuation toggle from 1 to 0 for removed > lights. @kevinrushforth I think that this is simple enough to be able to get into RDP1. There is some performance improvement regained here that was lost in one of my

RFR: 8313227: Correct attenuation indicator for removed lights

2023-07-26 Thread Nir Lisker
A simple fix of changing the attenuation toggle from 1 to 0 for removed lights. - Commit messages: - Initial commit Changes: https://git.openjdk.org/jfx/pull/1186/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1186&range=00 Issue: https://bugs.openjdk.org/browse/JDK-83132

AW: JavaFX does not recover after graphic card driver crash

2023-07-26 Thread Thorsten Fischer
I now opened a bug report for my issue. But as I'm trying to figure out the implementation of the D3D pipeline I found two things: 1. Only somewhat related to my issue, but I found that the existing recovery method for D3DERR_DEVICELOST / D3DERR_DEVICENOTRESET is not working when a device lost

Re: RFR: 8311895: CSS Transitions

2023-07-26 Thread leewyatt
On Tue, 16 Aug 2022 03:01:23 GMT, Michael Strauß wrote: > Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; >

[jfx21] Integrated: 8312528: Move Subscription interface from javafx.beans to javafx.util

2023-07-26 Thread John Hendrikx
On Wed, 26 Jul 2023 11:52:04 GMT, John Hendrikx wrote: > Backport of https://bugs.openjdk.org/browse/JDK-8312529 This pull request has now been integrated. Changeset: 6095445a Author:John Hendrikx URL: https://git.openjdk.org/jfx/commit/6095445a8aeb6f9c5b1cd68ecf682b1734673a95 Stats

Re: [jfx21] RFR: 8312528: Move Subscription interface from javafx.beans to javafx.util

2023-07-26 Thread Kevin Rushforth
On Wed, 26 Jul 2023 11:52:04 GMT, John Hendrikx wrote: > Backport of https://bugs.openjdk.org/browse/JDK-8312529 Looks good. Skara marked it as `clean`. It is approved in JBS for a late Enhancement to `jfx21`, so you can integrate when ready. - Marked as reviewed by kcr (Lead). P

[jfx21] RFR: 8312528: Move Subscription interface from javafx.beans to javafx.util

2023-07-26 Thread John Hendrikx
Backport of https://bugs.openjdk.org/browse/JDK-8312529 - Commit messages: - Backport cc57fb51a9409f5d2a6d2ce8dcd3878d48f9cfc9 Changes: https://git.openjdk.org/jfx/pull/1185/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1185&range=00 Issue: https://bugs.openjdk.org/brows

Integrated: JDK-8312528: Move Subscription interface from javafx.beans to javafx.util

2023-07-26 Thread John Hendrikx
On Fri, 21 Jul 2023 22:15:03 GMT, John Hendrikx wrote: > The Subscription interface is independent from FX beans and has uses > unrelated to beans, it should therefore be placed in javafx.util. > > This should be fixed before > [JDK-8311123](https://bugs.openjdk.org/browse/JDK-8311123) is rele

Re: RFR: 8090267: JFXPanel Input Problem

2023-07-26 Thread ctipper
On Tue, 4 Jul 2023 05:54:54 GMT, Prasanta Sadhukhan wrote: > When Japanse (IME on) is inputted to the TextFIeld, which is on JFXPanel, > small window for inputting appears on top-left side of screen > > ![image](https://github.com/openjdk/jfx/assets/43534309/65833d59-528e-4087-9992-9f86b8b8c47

Re: RFR: JDK-8312528: Move Subscription interface from javafx.beans to javafx.util

2023-07-26 Thread Kevin Rushforth
On Fri, 21 Jul 2023 22:15:03 GMT, John Hendrikx wrote: > The Subscription interface is independent from FX beans and has uses > unrelated to beans, it should therefore be placed in javafx.util. > > This should be fixed before > [JDK-8311123](https://bugs.openjdk.org/browse/JDK-8311123) is rele

Re: CSS Transitions

2023-07-26 Thread Kevin Rushforth
inline On 7/24/2023 5:09 PM, Michael Strauß wrote: My comments below: On Tue, Jul 25, 2023 at 1:18 AM Kevin Rushforth wrote: This seems like it might be a useful feature, if enough applications would want to take advantage of it. If we proceed, I have a couple comments: * All of our existin

Re: RFR: JDK-8312528: Move Subscription interface from javafx.beans to javafx.util

2023-07-26 Thread John Hendrikx
On Fri, 21 Jul 2023 22:40:17 GMT, Kevin Rushforth wrote: >> The Subscription interface is independent from FX beans and has uses >> unrelated to beans, it should therefore be placed in javafx.util. >> >> This should be fixed before >> [JDK-8311123](https://bugs.openjdk.org/browse/JDK-8311123)

Withdrawn: (draf): ChangeListener events are incorrect or misleading when a nested change occurs

2023-07-26 Thread duke
On Sun, 17 Jul 2022 20:59:46 GMT, John Hendrikx wrote: > This contains the following: > - Nested changes or invalidations using ExpressionHelper are delayed until > the current emission completes > - This fixes odd change events being produced (with incorrect oldValue) > - Also fixes a bug i