Re: CSS heisenbug

2023-07-20 Thread Nir Lisker
I added the info to the ticket. On Fri, Jul 21, 2023 at 2:00 AM Alessandro Mercier < administra...@codedead.com> wrote: > Hello, > > I possibly have some new information in regards to: > https://bugs.openjdk.org/browse/JDK-8268657 > > It seems the bug is predominantly active on Linux Wayland syst

CSS heisenbug

2023-07-20 Thread Alessandro Mercier
Hello, I possibly have some new information in regards to: https://bugs.openjdk.org/browse/JDK-8268657 It seems the bug is predominantly active on Linux Wayland systems and definitely not fixed and reproducible: https://github.com/mkpaz/atlantafx/issues/65#issuecomment-1644214727 The bug doesn't

RFR: JDK-8310681: Update WebKit to 616.1

2023-07-20 Thread Hima Bindu Meda
Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). Verified the updated version build, sanity tests and stability. No issues have been observed. - Commit messages: - Update WebKit to 616.1 Changes: https://git.openjdk.org/jfx/pull/1180/files Webrev: https://webrevs.openjdk.org/?rep

Integrated: 8285700: [TreeTableView] graphic property of TreeItem is still visible after collapsing tree

2023-07-20 Thread Karthik P K
On Fri, 7 Jul 2023 05:25:34 GMT, Karthik P K wrote: > In `TreeTableRowSkin`, graphic was not updated along with tree item update. > > Made changes to update graphics of TreeTableView row in `updateTreeItem()` > method. > > Added options in monkey tester to add graphics and subnodes to > `Tree

Re: RFR: 8285700: [TreeTableView] graphic property of TreeItem is still visible after collapsing tree [v2]

2023-07-20 Thread Karthik P K
On Fri, 14 Jul 2023 16:37:27 GMT, Andy Goryachev wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add unit test > > github says it fails pre-submit check - probably some kind of spurious > failure, local build and h

Re: RFR: 8285700: [TreeTableView] graphic property of TreeItem is still visible after collapsing tree [v4]

2023-07-20 Thread Andy Goryachev
On Thu, 20 Jul 2023 06:54:14 GMT, Karthik P K wrote: >> In `TreeTableRowSkin`, graphic was not updated along with tree item update. >> >> Made changes to update graphics of TreeTableView row in `updateTreeItem()` >> method. >> >> Added options in monkey tester to add graphics and subnodes to

Re: RFR: 8255248: NullPointerException in JFXPanel due to race condition in HostContainer [v2]

2023-07-20 Thread Prasanta Sadhukhan
On Thu, 20 Jul 2023 09:17:37 GMT, Marius Hanl wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add lock for read/write of scenePeer/stagePeer and added system test > > modules/javafx.swing/src/main/java/javafx

Re: RFR: 8255248: NullPointerException in JFXPanel due to race condition in HostContainer [v3]

2023-07-20 Thread Prasanta Sadhukhan
> Due to transient datatype of scenePeer, it can become null which can result > in NPE in scenarios where scene is continuously been reset and set, which > warrants a null check, as is done in other places for the same variable. Prasanta Sadhukhan has updated the pull request incrementally with

Re: RFR: 8255248: NullPointerException in JFXPanel due to race condition in HostContainer [v2]

2023-07-20 Thread Marius Hanl
On Wed, 19 Jul 2023 06:02:13 GMT, Prasanta Sadhukhan wrote: >> Due to transient datatype of scenePeer, it can become null which can result >> in NPE in scenarios where scene is continuously been reset and set, which >> warrants a null check, as is done in other places for the same variable. >

Re: RFR: 8285700: [TreeTableView] graphic property of TreeItem is still visible after collapsing tree [v4]

2023-07-20 Thread Marius Hanl
On Thu, 20 Jul 2023 06:54:14 GMT, Karthik P K wrote: >> In `TreeTableRowSkin`, graphic was not updated along with tree item update. >> >> Made changes to update graphics of TreeTableView row in `updateTreeItem()` >> method. >> >> Added options in monkey tester to add graphics and subnodes to

Re: RFR: 8285700: [TreeTableView] graphic property of TreeItem is still visible after collapsing tree

2023-07-20 Thread Karthik P K
On Sat, 8 Jul 2023 10:15:47 GMT, Marius Hanl wrote: >> In `TreeTableRowSkin`, graphic was not updated along with tree item update. >> >> Made changes to update graphics of TreeTableView row in `updateTreeItem()` >> method. >> >> Added options in monkey tester to add graphics and subnodes to >