I think this is another step in the right direction. The
Platform.getPreferences() method would then document that the returned
map is an "unmodifiable map" (as defined by the Map interface docs).
-- Kevin
On 6/16/2023 6:36 AM, Michael Strauß wrote:
It might indeed be useful to split read-on
On Thu, 15 Jun 2023 16:21:35 GMT, Thiago Milczarek Sayao
wrote:
>> I replicated the fix on #1054 on Linux.
>>
>> Also fixes [Monocle: Stage no longer gets focus after fix for
>> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
>
> Thiago Milczarek Sayao has updated the pull request in
+1 for getPaint()
+1 for modena dark css
-andy
From: openjfx-dev on behalf of Michael Strauß
Date: Friday, June 16, 2023 at 08:56
To: Thiago Milczarek Sayão
Cc: openjfx-dev
Subject: Re: Platform preferences API
Maybe the Preferences API should have a convenience method like
Optional get
On Thu, 15 Jun 2023 16:21:35 GMT, Thiago Milczarek Sayao
wrote:
>> I replicated the fix on #1054 on Linux.
>>
>> Also fixes [Monocle: Stage no longer gets focus after fix for
>> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
>
> Thiago Milczarek Sayao has updated the pull request in
Maybe the Preferences API should have a convenience method like
Optional getPaint(String key);
instead of getColor, to allow for cases when an OS defines complex
paint instead of solid colors.
I like your idea of shipping a Modena Dark variant. We should consider
this as a potential follow-up
On Sat, 22 Apr 2023 12:55:05 GMT, Thiago Milczarek Sayao
wrote:
> I replicated the fix on #1054 on Linux.
>
> Also fixes [Monocle: Stage no longer gets focus after fix for
> JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
This pull request has now been integrated.
Changeset: 7eb9a1
I was thinking mostly about colors. Those will be hard because the tendency
to have css styles. Might not even be a solid color.
Light and Dark mode could be useful and seems like a hardened feature
everywhere. Maybe a Modena dark css should be shipped together (for optimal
use)?
-- Thiago
On Fri, 16 Jun 2023 08:34:29 GMT, Karthik P K wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> tests/system/src/test/java/test/robot/javafx/scene/TextSurrogatePairInsertionIndexTest.java
> lin
> A recent change in JDK-8304831 ensured that insertionIndex is always computed
> prior to HitInfo construction, making it possible to remove buggy logic in
> HitInfo. This change also allows for removal of the 'text' field.
>
> There should be no impact since the constructor is package protec
I completely disagree. Being able to adjust the applications appearance to the
OS has been a topic for me and many others for quite some time. Thanks for
people like Gerrit Grunwald I have been able to partially solve dark mode
support but it is very OS specific and requires execution of batch c
My perception is entirely different. In the last few years, most
operating systems seem to have embraced the light/dark mode concept.
More and more applications (as well as web applications) support dark
mode in addition to the default light mode, and many try to adapt to
the OS.
That is certainly
See also Andy's question:
> Is high contrast mode encoded as another attribute, or does it need two more
> values in Appearance (high contrast light, high contrast dark)?
LIGHT and DARK are the only two appearances afforded by Windows
(starting with Windows 10), macOS, and iOS. I think it's safe
It might indeed be useful to split read-only platform preferences from
mutable application preferences.
I've updated the API doc [1]; here is the summary:
1. Have `Platform.getPreferences()` return the same interface as
before, minus the mutation methods.
2. Have `Application.getPreferences()` retu
On Fri, 5 May 2023 15:56:40 GMT, Florian Weimer wrote:
> Related to:
>
> * https://fedoraproject.org/wiki/Changes/PortingToModernC
> * https://fedoraproject.org/wiki/Toolchain/PortingToModernC
This pull request has now been integrated.
Changeset: 42321838
Author:Florian Weimer
Committer:
Hi,
As far as I know, no one is working on this bug, so if you'd like to
contribute a fix based on the initial patch, that would be fine. In
addition to adding tests, we would want to see an evaluation that
explains why the fix is correct, especially since the comment in the JDK
bug says: "It
On Wed, 14 Jun 2023 17:00:41 GMT, Florian Weimer wrote:
>> @prrace @kevinrushforth Any chance to get this reviewed? Thanks.
>
>> @fweimer-rh Please do not rebase or force-push to an active PR as it
>> invalidates existing review comments. Note for future reference, the bots
>> always squash all
Hi all,
I know that this a bit off topic but it could be interesting for many
JavaFX users.
I recently noted that java.awt.TrayIcon.displayMessage() method does not
work really well in Windows 11 anymore.
My notifications are shown with a strange icon and the notification is
not persistent
On Fri, 16 Jun 2023 09:42:45 GMT, John Hendrikx wrote:
>> I think the three newly added methods are a good choice. I wonder if we can
>> some up with better names, though. without some verb like "add" or
>> "subscribe" in the name, the name doesn't really indicate that it is adding
>> a new li
On Wed, 14 Jun 2023 19:26:01 GMT, Kevin Rushforth wrote:
>> Yeah I'm aware they want to add this, but it doesn't really invalidate my
>> point as that syntax is terrible still. Method references are far preferred
>> whenever possible.
>>
>> I stand by my point that using the observable parame
> Makes `Subscription` public (removing some of its methods that are
> unnecessary), and adds methods that can provide `Subscription`s in
> `ObservableValue`.
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Use forEach
---
> Makes `Subscription` public (removing some of its methods that are
> unnecessary), and adds methods that can provide `Subscription`s in
> `ObservableValue`.
John Hendrikx has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains six commits:
> Makes `Subscription` public (removing some of its methods that are
> unnecessary), and adds methods that can provide `Subscription`s in
> `ObservableValue`.
John Hendrikx has updated the pull request incrementally with three additional
commits since the last revision:
- Improve javadoc
- A
On Thu, 15 Jun 2023 18:38:14 GMT, Andy Goryachev wrote:
>> A recent change in JDK-8304831 ensured that insertionIndex is always
>> computed prior to HitInfo construction, making it possible to remove buggy
>> logic in HitInfo. This change also allows for removal of the 'text' field.
>>
>> Th
On Tue, 13 Jun 2023 14:53:39 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> small changes based on code review
>
> tests/system/src/test/java/test/javafx/stage/SystemMenuBarTest.java line
On Fri, 16 Jun 2023 07:24:51 GMT, Florian Kirmaier
wrote:
>> Fixing JDK-8309935 and providing a test for it.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> small changes based on code review
I've tested it on Mac.
O
> Fixing JDK-8309935 and providing a test for it.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
small changes based on code review
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1152/files
- new: https://gi
26 matches
Mail list logo
