Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows

2023-05-28 Thread Hima Bindu Meda
On Fri, 26 May 2023 11:13:31 GMT, Joeri Sykora wrote: >> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides >> the needed C++20 support for the next WebKit update. >> >> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 >> 17.5.0 -- see [JDK-8303

Re: RFR: 8273379: GTK3 stops sending key events during drag and drop [v32]

2023-05-28 Thread Thiago Milczarek Sayao
On Sat, 27 May 2023 17:34:39 GMT, Martin Fox wrote: > I don't think the original bug should be fixed as written. On both Mac and > Windows the platform drag-and-drop system consumes all key events (well, on > the Mac we see some `keyUp:` events but not for modifiers). That's a good > thing, it

Re: RFR: 8303038: Glass gtk3 sends scroll events with delta(x, y) = 0 [v9]

2023-05-28 Thread Thiago Milczarek Sayao
> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this > scroll event type, deltas are sent to java with the value equal to zero. > > Here's whats happening: > > We include all event masks, so when using gtk3 (>= 3.4.0) it includes > `GDK_SMOOTH_SCROLL_MASK` meaning we

Integrated: 8091153: Customize the Table Button Menu

2023-05-28 Thread Marius Hanl
On Sat, 13 May 2023 19:11:26 GMT, Marius Hanl wrote: > This PR implements a way to override the table column menu. > When the `cornerRegion` is pressed, it will now call the `showColumnMenu` > method. This new method is protected and therefore can be overidden by > developers. If not overridde

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v5]

2023-05-28 Thread Jose Pereda
On Sat, 27 May 2023 22:41:06 GMT, Thiago Milczarek Sayao wrote: >> Thanks, @tsayao >> >> I'm running these tests now on Linux (Ubuntu 20.04) and MacOS (13.3.1): >> >> - controls:test >> - Manual/ StartIconified >> - System/Robot test.robot.javafx.stage.IconifyTest >> - System/Robot test.robot

A consumed event is being delivered to handler, that's a bug right?

2023-05-28 Thread John Hendrikx
When I add an onKeyPressed event handler that consumes all keys, and a EventType.ROOT handler that monitors events, this 2nd handler still sees KEY_PRESSED events which are consumed.  Note the 3rd line in the output where a consumed = true event is being delivered. Output: KeyPressedHandler K

Implementation not following documentation regarding when event handler gets called

2023-05-28 Thread John Hendrikx
When looking at the code for Scene#setOnKeyPressed, I noticed that it calls Scene#setEventHandler.  This is documented as:     /** * Sets the handler to use for this event type. There can only be one such * handler specified at a time. This handler is guaranteed to be called * f