Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v5]

2023-05-27 Thread Thiago Milczarek Sayao
On Sat, 27 May 2023 17:57:21 GMT, Jose Pereda wrote: >> @jperedadnr added. > > Thanks, @tsayao > > I'm running these tests now on Linux (Ubuntu 20.04) and MacOS (13.3.1): > > - controls:test > - Manual/ StartIconified > - System/Robot test.robot.javafx.stage.IconifyTest > - System/Robot test.r

Withdrawn: JDK-8269921 Text in Textflow and listeners on bounds can cause endless loop/crash and other performance issues

2023-05-27 Thread duke
On Tue, 6 Jul 2021 14:53:24 GMT, Florian Kirmaier wrote: > It's "a bit" complicated. > In some situations, getRuns get's called because listeners on bounds are set. > This causes TextFlow to layout to compute the runs. > Afterward, the bounds of the parents get updated. > This triggers a call to

Withdrawn: 8278021: Fix warnings in macOS glass native code and treat warnings as errors

2023-05-27 Thread duke
On Wed, 1 Dec 2021 17:44:21 GMT, Martin Fox wrote: > Turning on warnings-as-errors for the macOS glass native code. Deprecated > declarations are excluded and still appear as warnings. > > In the code that tries to locate the application's dock icon there were three > instances where `NO` was

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v5]

2023-05-27 Thread Jose Pereda
On Sun, 14 May 2023 12:43:49 GMT, Thiago Milczarek Sayao wrote: >> If not as system test, then could you add `WinIconified` as manual test, >> with some javadoc as quick instructions on how to check that it works as >> expected? > > @jperedadnr added. Thanks, @tsayao I'm running these tests

Re: RFR: 8273379: GTK3 stops sending key events during drag and drop [v32]

2023-05-27 Thread Martin Fox
On Sat, 6 May 2023 21:20:59 GMT, Thiago Milczarek Sayao wrote: >> This PR fixes 8273379. >> >> I reverted back to use GDK (from >> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the >> events. >> >> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383). >

Withdrawn: JDK-8298060: Fix precision bug in gesture recognizer classes

2023-05-27 Thread duke
On Sat, 3 Dec 2022 22:17:55 GMT, John Hendrikx wrote: > This includes a fix for the precision problem we've found as part of the > graphics warnings clean ups. > > I've included two commits, one with just the minimal fix, and one with the > clean ups. I can drop off the 2nd commit if it is dee

Re: RFR: 8223373: Remove IntelliJ IDEA specific files from the source code repository [v6]

2023-05-27 Thread Thiago Milczarek Sayao
On Tue, 23 May 2023 15:00:27 GMT, Ambarish Rapte wrote: > I am testing with IntelliJ IDEA 2023.1.2 (Community Edition). Made some > changes in a java file, added empty line with spaces, trailing spaces, added > tabs at random places. All the spaces on empty line, trailing spaces were > correct

Re: RFR: 8303038: Glass gtk3 sends scroll events with delta(x, y) = 0 [v8]

2023-05-27 Thread Thiago Milczarek Sayao
On Sat, 6 May 2023 21:22:28 GMT, Thiago Milczarek Sayao wrote: >> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore >> this scroll event type, deltas are sent to java with the value equal to zero. >> >> Here's whats happening: >> >> We include all event masks, so when u

Re: RFR: 8273379: GTK3 stops sending key events during drag and drop [v9]

2023-05-27 Thread Thiago Milczarek Sayao
On Wed, 4 Jan 2023 00:17:03 GMT, Kevin Rushforth wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Simplify DragView paint > > This will need a lot of careful testing. > > Can you provide more information

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v6]

2023-05-27 Thread Thiago Milczarek Sayao
On Mon, 1 May 2023 12:33:10 GMT, Lukasz Kostyra wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 46 >> additiona

Re: RFR: 8299756: Minor updates in CSS Reference

2023-05-27 Thread Marius Hanl
On Fri, 26 May 2023 22:26:49 GMT, Andy Goryachev wrote: > Minor fixes and addition of missing sections: > > - The 'system' font is missing from the list of generic font family names in > the section. ✓ > - Explicitly add text color property -fx-fill to Text section, so as not to > confuse wit

Re: RFR: 8308306: Update to Xcode 14.3 on macOS [v2]

2023-05-27 Thread Ambarish Rapte
On Thu, 25 May 2023 16:30:38 GMT, Kevin Rushforth wrote: >> Update the compiler on macOS to Xcode 14.3. In addition to providing the >> needed C++20 support for the next WebKit update, initial testing by the JDK >> team shows that this fixes a reproducible builds problem, so it might help >> a