On Wed, 17 May 2023 23:53:14 GMT, John Hendrikx wrote:
> Do you think this needs to be changed as part of this PR?
I'll answer this part of your question: No.
It seems out of scope for this particular bug fix, which is aimed at fixing an
API and impl problem with `Match`, and should limit the
On Wed, 17 May 2023 08:50:23 GMT, Lukasz Kostyra wrote:
>> Crashes started happening due to macOS DnD API change from macOS 10.14
>> onwards. 10.14 incrodues some [DnD
>> constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop
On Wed, 17 May 2023 23:17:30 GMT, Andy Goryachev wrote:
>> This is also solved in #1076:
>>
>> if (obj instanceof BitSet bitSet &&
>> getElementType().equals(bitSet.getElementType()))
>>
>> But since that requires pulling in even more changes (`getElementType`) I've
>> left it there.
>>
On Wed, 17 May 2023 08:50:23 GMT, Lukasz Kostyra wrote:
>> Crashes started happening due to macOS DnD API change from macOS 10.14
>> onwards. 10.14 incrodues some [DnD
>> constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop
On Wed, 17 May 2023 22:37:27 GMT, John Hendrikx wrote:
>> Since it's an internal class, and both PseudoClassState and StyleClassSet
>> are final, checking for class == class is probably sufficient.
>> Do you think we should add a warning to BitSet, it is not a problem since
>> no-one will ever
On Wed, 17 May 2023 16:40:01 GMT, Lukasz Kostyra wrote:
> As a small note, the issue is solved with current patches, however I think
> the best solution would be what I mentioned in the original PR message - an
> interface in `VetoableListDecorator` which would let us "roll-back" any
> changes
On Wed, 17 May 2023 15:22:57 GMT, Lukasz Kostyra wrote:
>> This issue happened because `childSet` member of Parent was modified during
>> `onProposedChange()` call - that call did not recognize negative indexes as
>> invalid, which caused an exception when actually adding the Node to a List.
>>
On Wed, 17 May 2023 22:08:53 GMT, Andy Goryachev wrote:
>> We did, in #1076. However, I would like to not pull in all the `BitSet`
>> fixes into this PR as this has nothing to do with `BitSet` and its many
>> problems.
>
> Since it's an internal class, and both PseudoClassState and StyleClassSe
On Wed, 17 May 2023 21:59:58 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line
>> 266:
>>
>>> 264: @Override
>>> 265: public boolean addAll(Collection c) {
>>> 266: if (this.getClass() != c.getClass()) {
>>
>> same, handling
On Wed, 17 May 2023 21:39:10 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Override hashCode with a comment explaining why
>> - Fix style issues
>> - Restore removed public method
>
> m
On Wed, 17 May 2023 21:22:15 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Override hashCode with a comment explaining why
>> - Fix style issues
>> - Restore removed public method
>
> m
On Wed, 17 May 2023 22:03:31 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line
>> 532:
>>
>>> 530: return true;
>>> 531: }
>>> 532: if (obj instanceof BitSet bitSet) { // fast path if other
>>> is a BitSet
>>
>>
On Wed, 17 May 2023 21:20:28 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Override hashCode with a comment explaining why
>> - Fix style issues
>> - Restore removed public method
>
> m
On Wed, 17 May 2023 21:13:46 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Override hashCode with a comment explaining why
>> - Fix style issues
>> - Restore removed public method
>
> m
On Wed, 17 May 2023 21:12:48 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Override hashCode with a comment explaining why
>> - Fix style issues
>> - Restore removed public method
>
> m
On Fri, 12 May 2023 23:40:03 GMT, John Hendrikx wrote:
>> The class `PseudoClassState` is private API, but was exposed erroneously in
>> the CSS API. Instead, `Set` should have been used. This PR
>> corrects this.
>
> John Hendrikx has updated the pull request incrementally with three
> additi
On Sat, 8 Apr 2023 14:36:30 GMT, Kevin Rushforth wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Properly use NSObject instead of the GlassAccessible type.
>
> modules/javafx.graphics/src/main/native-glass/mac/a1
> Add the common base component for all the new implementing native classes
> Change native peer creation to use the new base component The new code will
> instantiate new protocol implementation for the given role if it exists or
> an old one if it does not exist
> Added BUTTON role implementi
> Add the common base component for all the new implementing native classes
> Change native peer creation to use the new base component The new code will
> instantiate new protocol implementation for the given role if it exists or
> an old one if it does not exist
> Added BUTTON role implementi
On Sat, 8 Apr 2023 14:31:01 GMT, Kevin Rushforth wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed situation when performAction throws an exception on Java side - now
>> we are properly
>> returning FALSE
On Wed, 17 May 2023 19:35:41 GMT, Andy Goryachev wrote:
> I wish the default implementation did not hide the popup on mouse click, to
> allow for toggling multiple columns, but it is out of scope for this PR.
I agree that this behavior is rather uncomfortable.
The problem is that we are changin
On Wed, 17 May 2023 19:29:13 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>> developers. If not overr
On Wed, 17 May 2023 13:09:09 GMT, Kevin Rushforth wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8091153: Improve javadoc to match the CSR
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/Tab
> This PR implements a way to override the table column menu.
> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
> method. This new method is protected and therefore can be overidden by
> developers. If not overridden, the known default column 'ContextMenu' is
> created
> This PR implements a way to override the table column menu.
> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
> method. This new method is protected and therefore can be overidden by
> developers. If not overridden, the known default column 'ContextMenu' is
> created
As a heads-up, I have filed the following JBS issues to bump the
compiler versions used to build JavaFX production builds:
Mac: JDK-8308306 [1] : Update to Xcode 14.3 on macOS
Linux : JDK-8308307 [2] : Update to gcc 12.2.0 on Linux
Windows: JDK-8308308 [3] : Update to Visual Studio 2022 version
On Wed, 10 May 2023 02:11:19 GMT, Alexander Matveev
wrote:
> - libFFI updated to 3.4.4.
> - No additional changes are done to the code.
> - Tested on Linux, Windows x64 and macOS x64/aarch64.
> - Windows x86 config files are updated, but no build/testing was done for
> 32-bit.
This pull reques
On Wed, 12 Apr 2023 15:13:25 GMT, Ambarish Rapte wrote:
> Issue:
> CheckBoxTreeItem extends TreeItem and adds a CheckBox.
> The state of this CheckBox is not visible to an accessibility client
> application.
> If we analyze a simple program that contains a CheckBoxTreeItem using a
> windows app
On Tue, 11 Oct 2022 09:05:34 GMT, Marius Hanl wrote:
> The problem here is, that the `AnchorPane` does not use its snapped insets.
> Therefore, the fix is to replace all `getInsets().getXXX` calls with their
> corresponding `snappedXXXInset()` methods.
>
> Note: The reason the `AnchorPane` insi
On Wed, 17 May 2023 15:22:57 GMT, Lukasz Kostyra wrote:
>> This issue happened because `childSet` member of Parent was modified during
>> `onProposedChange()` call - that call did not recognize negative indexes as
>> invalid, which caused an exception when actually adding the Node to a List.
>>
On Tue, 16 May 2023 10:27:05 GMT, Ambarish Rapte wrote:
>> Issue:
>> CheckBoxTreeItem extends TreeItem and adds a CheckBox.
>> The state of this CheckBox is not visible to an accessibility client
>> application.
>> If we analyze a simple program that contains a CheckBoxTreeItem using a
>> windo
> This issue happened because `childSet` member of Parent was modified during
> `onProposedChange()` call - that call did not recognize negative indexes as
> invalid, which caused an exception when actually adding the Node to a List.
>
> This seemed like the simplest solution which doesn't rewor
On Mon, 15 May 2023 22:39:52 GMT, Marius Hanl wrote:
>> This PR implements a way to override the table column menu.
>> When the `cornerRegion` is pressed, it will now call the `showColumnMenu`
>> method. This new method is protected and therefore can be overidden by
>> developers. If not overr
On Thu, 11 May 2023 20:25:49 GMT, Marius Hanl wrote:
>> The problem here is, that the `AnchorPane` does not use its snapped insets.
>> Therefore, the fix is to replace all `getInsets().getXXX` calls with their
>> corresponding `snappedXXXInset()` methods.
>>
>> Note: The reason the `AnchorPane`
> Updated ICU to v73.1. Verified build and sanity. No issues seen.
Hima Bindu Meda has updated the pull request incrementally with one additional
commit since the last revision:
update license
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1138/files
- new: https://git.op
> Crashes started happening due to macOS DnD API change from macOS 10.14
> onwards. 10.14 incrodues some [DnD
> constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop)
> which our DnD code happened to trigger on some occasions
36 matches
Mail list logo
