Re: RFR: 8301312: Create implementation of NSAccessibilityButton protocol

On Wed, 12 Apr 2023 07:22:54 GMT, Ambarish Rapte wrote: > I noticed two behavioral change, when VoiceOver is running. > > * Focus Rectangle: A Black (focus) rectangle is drawn around a focused > control, or an item that has Accessibility focus. This seems correct and > offers more visual info

Re: ObservableValue.map special-cases the null value

Hi Michael, As you're only trying to map to true/false, it is a bit ugly to do this I suppose:   nullableValue.map(x -> true).orElse(false); I've encountered situations like these before, where you only want to know about the presence of a value, and don't care what the value is.  If th

Re: RFR: 8233955: VM crashes if more than one file are added to ClipboardContent via drag and drop [v2]

On Wed, 10 May 2023 22:31:53 GMT, Kevin Rushforth wrote: >> Lukasz Kostyra has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 10 additional >> comm

ObservableValue.map special-cases the null value

I'm trying to map an ObservableValue such that `null` is mapped to `false` and any other value is mapped to `true`. The following line of code should do the trick: ObservableValue mappedValue = nullableValue.map(x -> x != null); It turns out that this doesn't work, since `map` doesn't pass `null`

Re: RFR: 8301312: Create implementation of NSAccessibilityButton protocol [v2]

> Add the common base component for all the new implementing native classes > Change native peer creation to use the new base component The new code will > instantiate new protocol implementation for the given role if it exists or > an old one if it does not exist > Added BUTTON role implementi

Integrated: 8308114: Bump minimum version of macOS for x64 to 11.0 (matching aarch64)

On Mon, 15 May 2023 18:13:00 GMT, Kevin Rushforth wrote: > This PR bumps the minimum deployment target for JavaFX to macOS 11.0 (Big > Sur) on x64 platforms, matching the current minimum on aarch64. > > As a follow-on to this, I will file a (low-priority) cleanup issue to remove > any `@availa

Re: RFR: 8304831: TextFlow.hitTest.insertionIndex incorrect with surrogate pairs [v5]

On Tue, 16 May 2023 10:32:00 GMT, Karthik P K wrote: >> Since surrogate pairs are internally considered as 2 characters and text >> field is null in `HitInfo` when `getInsertionIndex` is invoked from >> `TextFlow`, wrong insertion index was returned. >> >> Updated code to calculate insertion i

Re: RFR: 8304831: TextFlow.hitTest.insertionIndex incorrect with surrogate pairs [v4]

On Tue, 16 May 2023 10:31:57 GMT, Karthik P K wrote: > I couldn't create the scenario to hit line 473. If you have any suggestions > please let me know. I can't seem to trigger this code path (I wonder if it's possible to hit it at all). Anyway, the code there looks correct to me, even if thi

Re: RFR: 8304831: TextFlow.hitTest.insertionIndex incorrect with surrogate pairs [v5]

On Tue, 16 May 2023 10:32:00 GMT, Karthik P K wrote: >> Since surrogate pairs are internally considered as 2 characters and text >> field is null in `HitInfo` when `getInsertionIndex` is invoked from >> `TextFlow`, wrong insertion index was returned. >> >> Updated code to calculate insertion i

Re: RFR: 8306329 : Update ICU4C to 73 [v2]

> Updated ICU to v73.1. Verified build and sanity. No issues seen. Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision: update copyright year - Changes: - all: https://git.openjdk.org/jfx/pull/1138/files - new: https:/

Re: Customizable Table Button Menu

This looks to me like a good solution, with a rather small probability of breaking the existing application code. -andy From: openjfx-dev on behalf of Marius Hanl Date: Monday, May 15, 2023 at 15:05 To: openjfx-dev Subject: Customizable Table Button Menu In https://github.com/openjdk/jfx/p

Re: RFR: 8307316: Let JavaFX be built on unknown architectures

On Wed, 3 May 2023 16:02:34 GMT, John Neffenger wrote: > Please review these changes to the Gradle build files and the dependency > verification file. The initial version of this pull request extends the > permitted build platforms for Linux to the Java architectures `arm`, > `ppc64le`, and `s

Re: RFR: 8284542: [Accessibility] [Win] Missing attribute for toggle state of CheckBox in CheckBoxTreeItem [v4]

On Tue, 16 May 2023 10:27:05 GMT, Ambarish Rapte wrote: >> Issue: >> CheckBoxTreeItem extends TreeItem and adds a CheckBox. >> The state of this CheckBox is not visible to an accessibility client >> application. >> If we analyze a simple program that contains a CheckBoxTreeItem using a >> windo

Re: Improvements for Focus Traversal code

I agree that focus management is one of the less developed parts of JavaFX. In addition to all the scenarios listed by John and Chuck, there is a case where input is accepted by two controls at the same time * JDK-8292933 Multiple focused compo

Re: RFR: 8284542: [Accessibility] [Win] Missing attribute for toggle state of CheckBox in CheckBoxTreeItem [v3]

On Fri, 12 May 2023 22:30:27 GMT, Kevin Rushforth wrote: > Definitely unrelated, but it should be filed as a bug. I remember seeing this > before, but I don't see a bug for it. created [JDK-8308191](https://bugs.openjdk.org/browse/JDK-8308191) [macOS] VoiceOver decorations are shifted on second

Re: RFR: 8284542: [Accessibility] [Win] Missing attribute for toggle state of CheckBox in CheckBoxTreeItem [v4]

On Tue, 16 May 2023 10:27:05 GMT, Ambarish Rapte wrote: >> Issue: >> CheckBoxTreeItem extends TreeItem and adds a CheckBox. >> The state of this CheckBox is not visible to an accessibility client >> application. >> If we analyze a simple program that contains a CheckBoxTreeItem using a >> windo

Re: RFR: 8223373: Remove IntelliJ IDEA specific files from the source code repository [v6]

On Sun, 14 May 2023 12:29:01 GMT, Thiago Milczarek Sayao wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update .gitignore >> - Remove unrelated gitignore > > @arapte Would you take a look when you ha

Re: RFR: 8233955: VM crashes if more than one file are added to ClipboardContent via drag and drop [v2]

On Wed, 10 May 2023 22:31:53 GMT, Kevin Rushforth wrote: >> Lukasz Kostyra has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 10 additional >> comm

Re: RFR: 8306328: Update libFFI to 3.4.4 [v2]

On Thu, 11 May 2023 01:09:53 GMT, Alexander Matveev wrote: >> - libFFI updated to 3.4.4. >> - No additional changes are done to the code. >> - Tested on Linux, Windows x64 and macOS x64/aarch64. >> - Windows x86 config files are updated, but no build/testing was done for >> 32-bit. > > Alexande

Re: Improvements for Focus Traversal code

One of the things I really miss about Swing was the ease with which we could move focus programmatically. All we had to do was call the focus object (don't remember the name) and call focus.next() or focus.previous(). Having to get the next Control and call Control.requestFocus() is a hack. Whil

Improvements for Focus Traversal code

Hi list, I've gone down another rabbit hole in JavaFX, this time related to focus traversal. # Navigation keys are not handled universally for all controls Some controls install custom behaviors, and some don't.  The custom behaviors often include direct handling of navigation keys (getFocu

Re: RFR: 8304831: TextFlow.hitTest.insertionIndex incorrect with surrogate pairs [v4]

On Mon, 15 May 2023 15:50:06 GMT, Andy Goryachev wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Initialize insertion index in PrismTextLayout > > modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextL

Re: RFR: 8304831: TextFlow.hitTest.insertionIndex incorrect with surrogate pairs [v5]

> Since surrogate pairs are internally considered as 2 characters and text > field is null in `HitInfo` when `getInsertionIndex` is invoked from > `TextFlow`, wrong insertion index was returned. > > Updated code to calculate insertion index in `getHitInfo` method of > `PrismTextLayout` class wh

Re: RFR: 8284542: [Accessibility] [Win] Missing attribute for toggle state of CheckBox in CheckBoxTreeItem [v3]

On Fri, 12 May 2023 22:07:31 GMT, Andy Goryachev wrote: >> I usually prefer to avoid these sort of unrelated changes to minimize the >> diffs. Either way is fine. > > in this particular case, with many fall-throughs, I think the code would > benefit from reformatting. Minimal diff eases in tra

Re: RFR: 8284542: [Accessibility] [Win] Missing attribute for toggle state of CheckBox in CheckBoxTreeItem [v3]

On Fri, 12 May 2023 18:20:37 GMT, Andy Goryachev wrote: >> Ambarish Rapte has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> co

Re: RFR: 8284542: [Accessibility] [Win] Missing attribute for toggle state of CheckBox in CheckBoxTreeItem [v4]

> Issue: > CheckBoxTreeItem extends TreeItem and adds a CheckBox. > The state of this CheckBox is not visible to an accessibility client > application. > If we analyze a simple program that contains a CheckBoxTreeItem using a > windows application "Accessibility Insights for Window", we can notic

Re: RFR: 8284542: [Accessibility] [Win] Missing attribute for toggle state of CheckBox in CheckBoxTreeItem [v3]

On Sat, 13 May 2023 13:20:26 GMT, Kevin Rushforth wrote: >> In Eclipse, only this works: >> >> {@link AccessibleAttribute#TOGGLE_STATE} > > Then I think Eclipse has a bug. `TOGGLE_STATE` is a field (enum value) in the > outer enum class, `AccessibleAttribute`, so can be referenced from the nest

Re: RFR: 8301763: Adding children to wrong index leaves inconsistent state in Parent#childrenSet

On Mon, 15 May 2023 12:49:41 GMT, Lukasz Kostyra wrote: > This issue happened because `childSet` member of Parent was modified during > `onProposedChange()` call - that call did not recognize negative indexes as > invalid, which caused an exception when actually adding the Node to a List. > >