On Wed, 3 May 2023 20:13:42 GMT, Marius Hanl wrote:
> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
> `vgap`.
> As also written in the ticket, this is a small enhancement to improve the
> creation of a layout involving a `GridPane` without FXML.
> In my experience, th
On Fri, 5 May 2023 19:45:53 GMT, John Hendrikx wrote:
>> Note: the Java-side changes in this PR are also in #694 which fixes the same
>> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
>> making it difficult to test on that platform (see #718).
>>
>> KeyCharacterCo
On Fri, 5 May 2023 19:38:36 GMT, Martin Fox wrote:
> I'm not quite sold on having `notifyKey` and `notifyKeyEx` be two separate
> methods. Why not just have one? Not changing the existing call sites doesn't
> seem to be a sufficient reason to expand the toolkit API surface.
I also think it isn
On Thu, 4 May 2023 17:18:21 GMT, Martin Fox wrote:
> Note: the Java-side changes in this PR are also in #694 which fixes the same
> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
> making it difficult to test on that platform (see #718).
>
> KeyCharacterCombinatio
On Fri, 5 May 2023 16:35:38 GMT, Michael Strauß wrote:
> I'm not quite sold on having `notifyKey` and `notifyKeyEx` be two separate
> methods. Why not just have one? Not changing the existing call sites doesn't
> seem to be a sufficient reason to expand the toolkit API surface.
The long term g
On Fri, 5 May 2023 08:08:30 GMT, John Hendrikx wrote:
>> Region has floor and ceiling functions that ensure that calling them twice
>> in a row will yield the same result:
>>
>> ceil(x) = ceil(ceil(x))
>>
>> However, due to use of a constant `EPSILON` which is added/subtracted before
>>
On Thu, 4 May 2023 17:18:21 GMT, Martin Fox wrote:
> Note: the Java-side changes in this PR are also in #694 which fixes the same
> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
> making it difficult to test on that platform (see #718).
>
> KeyCharacterCombinatio
On Thu, 4 May 2023 17:18:21 GMT, Martin Fox wrote:
> Note: the Java-side changes in this PR are also in #694 which fixes the same
> issue (and more) on Linux. Unfortunately the Linux Robot code is not working
> making it difficult to test on that platform (see #718).
>
> KeyCharacterCombinatio
On Fri, 5 May 2023 13:40:39 GMT, Lukasz Kostyra wrote:
>> Verified these changes on all platforms and saw no abnormalities in test
>> execution.
>>
>> This change is based on a preliminary patch done by @aghaisas , with some
>> minor changes and the addition of one Leak-related web test.
>> E
On Fri, 5 May 2023 15:56:40 GMT, Florian Weimer wrote:
> Related to:
>
> * https://fedoraproject.org/wiki/Changes/PortingToModernC
> * https://fedoraproject.org/wiki/Toolchain/PortingToModernC
@prrace Can you review this?
-
PR Comment: https://git.openjdk.org/jfx/pull/1128#issueco
Related to:
* https://fedoraproject.org/wiki/Changes/PortingToModernC
* https://fedoraproject.org/wiki/Toolchain/PortingToModernC
-
Commit messages:
- 8307542: Call to FcConfigAppFontAddFile uses wrong prototype, arguments
Changes: https://git.openjdk.org/jfx/pull/1128/files
Webre
On Wed, 3 May 2023 18:15:34 GMT, Andy Goryachev wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor review updates
>>
>> * Changed ArrayList<> to Collection<> in one of assertCollectable-s
>> * Updated L
On Fri, 5 May 2023 13:40:39 GMT, Lukasz Kostyra wrote:
>> Verified these changes on all platforms and saw no abnormalities in test
>> execution.
>>
>> This change is based on a preliminary patch done by @aghaisas , with some
>> minor changes and the addition of one Leak-related web test.
>> E
On Fri, 5 May 2023 13:03:35 GMT, Kevin Rushforth wrote:
>> Interesting, I will add a `runAndWait()` noop and a test thread sleep then.
>
> I think you mean `SwingUtilities::invokeAndWait`, right?
>
> Btw, I also got a similar one-time failure in `SwingNodeDnDMemoryLeakTest`,
> so perhaps the sa
> Verified these changes on all platforms and saw no abnormalities in test
> execution.
>
> This change is based on a preliminary patch done by @aghaisas , with some
> minor changes and the addition of one Leak-related web test.
> EventListenerLeak test was not touched, as it is a separate manu
On Fri, 5 May 2023 12:41:03 GMT, Lukasz Kostyra wrote:
>> tests/system/src/test/java/test/javafx/embed/swing/SwingNodeMemoryLeakTest.java
>> line 80:
>>
>>> 78: });
>>> 79:
>>> 80: JMemoryBuddy.assertCollectable(weakRefArrSN);
>>
>> On my Mac (MacBook Pro x64 running macOS 13.
On Fri, 5 May 2023 12:22:03 GMT, Kevin Rushforth wrote:
>> Lukasz Kostyra has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - JMemoryBuddy: Add javadoc comments
>> - Remove thread sleeps before JMemoryBuddy calls
>>
>>JMemoryBuddy
On Fri, 5 May 2023 10:37:23 GMT, Lukasz Kostyra wrote:
>> Verified these changes on all platforms and saw no abnormalities in test
>> execution.
>>
>> This change is based on a preliminary patch done by @aghaisas , with some
>> minor changes and the addition of one Leak-related web test.
>> E
On Wed, 3 May 2023 21:22:10 GMT, Marius Hanl wrote:
>> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
>> `vgap`.
>> As also written in the ticket, this is a small enhancement to improve the
>> creation of a layout involving a `GridPane` without FXML.
>> In my experienc
On Thu, 4 May 2023 08:21:15 GMT, Lukasz Kostyra wrote:
>> Verified these changes on all platforms and saw no abnormalities in test
>> execution.
>>
>> This change is based on a preliminary patch done by @aghaisas , with some
>> minor changes and the addition of one Leak-related web test.
>> E
> Verified these changes on all platforms and saw no abnormalities in test
> execution.
>
> This change is based on a preliminary patch done by @aghaisas , with some
> minor changes and the addition of one Leak-related web test.
> EventListenerLeak test was not touched, as it is a separate manu
On Fri, 5 May 2023 08:46:03 GMT, Daniel wrote:
> Hi John, thank you for this information. I couldn't find any instances of
> `ConcurrentModificationException`, but about an hour ago before the NPE, we
> did have an `IllegalStateException`.
No, I don't think that is it. The check there preven
On Wed, 3 May 2023 11:46:50 GMT, buedi wrote:
> A null pointer exception occurs on the ScenePulseListener when iterating
> through the dirty node list.
> A null check is needed on the node before calling node.getScene().
>
> The error occurs occasionally and causes the application to crash.
Hi
> Region has floor and ceiling functions that ensure that calling them twice in
> a row will yield the same result:
>
> ceil(x) = ceil(ceil(x))
>
> However, due to use of a constant `EPSILON` which is added/subtracted before
> doing the rounding, this only works for small numbers (in the r
On Thu, 4 May 2023 23:16:38 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix NaN returns when using Math.ulp
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/layout/ScaledMath.
On Tue, 18 Apr 2023 12:17:53 GMT, John Hendrikx wrote:
>> Fix bug in CSS caching code that could reset values on unrelated nodes.
>>
>> The bug occurs due to a cache entry being constructed incorrectly when the
>> initial node that triggered the cache entry creation has user set values.
>> The
On Wed, 3 May 2023 11:46:50 GMT, buedi wrote:
> A null pointer exception occurs on the ScenePulseListener when iterating
> through the dirty node list.
> A null check is needed on the node before calling node.getScene().
>
> The error occurs occasionally and causes the application to crash.
I'
27 matches
Mail list logo
