Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

2023-03-29 Thread John Hendrikx
On Wed, 29 Mar 2023 10:20:12 GMT, John Hendrikx wrote: >>> @andy-goryachev-oracle raises a good point about perhaps wanting to solve >>> this in a similar way for the various places where we need to do some sort >>> of iterative adjustment (such as here and in the eventual solution for >>> JDK

jfx20u now open for JavaFX 20.0.2 backports

2023-03-29 Thread Kevin Rushforth
All, The jfx20u repo is now open for JavaFX 20.0.2 backports, with prior approval. The general criteria is that we want to backport fixes for regressions introduced in JavaFX 20, third-party library updates, and a limited number of other important bug fixes. In most cases we'd like to see the

[jfx20u] Integrated: 8305108: Change JavaFX release version to 20.0.2 in jfx20u

2023-03-29 Thread Kevin Rushforth
On Tue, 28 Mar 2023 21:29:34 GMT, Kevin Rushforth wrote: > Updates for the beginning of the 20.0.2 release. This pull request has now been integrated. Changeset: f16c1211 Author:Kevin Rushforth URL: https://git.openjdk.org/jfx20u/commit/f16c12116439afe8ec4e992270c77207b8944691 Stats

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

2023-03-29 Thread Andy Goryachev
On Tue, 3 Jan 2023 06:31:37 GMT, Michael Strauß wrote: >> The children of HBox/VBox don't always pixel-snap to the same value as the >> container itself when a render scale other than 1 is used. This can lead to >> a visual glitch where the content bounds don't line up with the container >> bo

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

2023-03-29 Thread Michael Strauß
On Wed, 29 Mar 2023 10:20:12 GMT, John Hendrikx wrote: >>> @andy-goryachev-oracle raises a good point about perhaps wanting to solve >>> this in a similar way for the various places where we need to do some sort >>> of iterative adjustment (such as here and in the eventual solution for >>> JDK

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

2023-03-29 Thread Andy Goryachev
On Tue, 3 Jan 2023 06:31:37 GMT, Michael Strauß wrote: >> The children of HBox/VBox don't always pixel-snap to the same value as the >> container itself when a render scale other than 1 is used. This can lead to >> a visual glitch where the content bounds don't line up with the container >> bo

Re: RFR: JDK-8304960: ObservableListBase should defer constructing ListChangeBuilder

2023-03-29 Thread John Hendrikx
On Wed, 29 Mar 2023 15:31:49 GMT, Andy Goryachev wrote: > the only place where this code might fail is when it gets accessed from > multiple threads. `ListChangeBuilder` itself is not thread safe :) - PR Comment: https://git.openjdk.org/jfx/pull/1075#issuecomment-1488939702

Re: [jfx20u] RFR: 8305108: Change JavaFX release version to 20.0.2 in jfx20u

2023-03-29 Thread Ambarish Rapte
On Tue, 28 Mar 2023 21:29:34 GMT, Kevin Rushforth wrote: > Updates for the beginning of the 20.0.2 release. Marked as reviewed by arapte (Reviewer). - PR Review: https://git.openjdk.org/jfx20u/pull/10#pullrequestreview-1363539495

Re: RFR: JDK-8304960: ObservableListBase should defer constructing ListChangeBuilder

2023-03-29 Thread Andy Goryachev
On Wed, 29 Mar 2023 12:15:02 GMT, John Hendrikx wrote: > A 1200 Node application sees a 2/3rds reduction of ListChangeBuilder's > created. Every `Node` for example has an `ObservableList` for style classes, > and every `Parent` has one for stylesheets, which rarely if ever change. the only pl

Re: RFR: JDK-8304960: ObservableListBase should defer constructing ListChangeBuilder

2023-03-29 Thread Andy Goryachev
On Wed, 29 Mar 2023 12:15:02 GMT, John Hendrikx wrote: > A 1200 Node application sees a 2/3rds reduction of ListChangeBuilder's > created. Every `Node` for example has an `ObservableList` for style classes, > and every `Parent` has one for stylesheets, which rarely if ever change. a good idea

RFR: JDK-8304960: ObservableListBase should defer constructing ListChangeBuilder

2023-03-29 Thread John Hendrikx
A 1200 Node application sees a 2/3rds reduction of ListChangeBuilder's created. Every `Node` for example has an `ObservableList` for style classes, and every `Parent` has one for stylesheets, which rarely if ever change. - Commit messages: - Defer initialization of ListChangeBuild

Re: RFR: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore

2023-03-29 Thread Kevin Rushforth
On Tue, 28 Mar 2023 02:08:27 GMT, Jay Bhaskar wrote: > Issue: Error copying file (if different) from > Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py" > to > "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py". > > Root

Re: RFR: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore

2023-03-29 Thread Jay Bhaskar
On Wed, 29 Mar 2023 11:09:52 GMT, Lukasz Kostyra wrote: >> do you mean as >> if(copy_result) >> message(WARNING "Failed to copy ${_file} to >> ${JavaScriptCore_SCRIPTS_DIR}/${_script}: ${copy_output}") >> should be as >> >> if(copy_result) >> message(WARNING "${copy_res

Re: RFR: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore

2023-03-29 Thread Lukasz Kostyra
On Wed, 29 Mar 2023 10:46:05 GMT, Jay Bhaskar wrote: >> modules/javafx.web/src/main/native/Source/JavaScriptCore/CMakeLists.txt line >> 198: >> >>> 196: ) >>> 197: if(copy_result) >>> 198: message(WARNING "Failed to copy ${_file} to >>> ${JavaScriptCore_SCRIPTS_DIR}

Re: RFR: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore

2023-03-29 Thread Jay Bhaskar
On Wed, 29 Mar 2023 08:46:53 GMT, Lukasz Kostyra wrote: >> Issue: Error copying file (if different) from >> Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py" >> to >> "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py". >>

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

2023-03-29 Thread John Hendrikx
On Wed, 29 Mar 2023 07:33:19 GMT, Marius Hanl wrote: > > @andy-goryachev-oracle raises a good point about perhaps wanting to solve > > this in a similar way for the various places where we need to do some sort > > of iterative adjustment (such as here and in the eventual solution for > > JDK-8

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

2023-03-29 Thread John Hendrikx
On Tue, 3 Jan 2023 06:31:37 GMT, Michael Strauß wrote: >> The children of HBox/VBox don't always pixel-snap to the same value as the >> container itself when a render scale other than 1 is used. This can lead to >> a visual glitch where the content bounds don't line up with the container >> bo

Re: RFR: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore

2023-03-29 Thread Lukasz Kostyra
On Tue, 28 Mar 2023 02:08:27 GMT, Jay Bhaskar wrote: > Issue: Error copying file (if different) from > Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py" > to > "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py". > > Root

Re: RFR: 8264591: HBox/VBox child widths pixel-snap to wrong value [v7]

2023-03-29 Thread Marius Hanl
On Thu, 16 Mar 2023 19:41:07 GMT, Kevin Rushforth wrote: > @andy-goryachev-oracle raises a good point about perhaps wanting to solve > this in a similar way for the various places where we need to do some sort of > iterative adjustment (such as here and in the eventual solution for > JDK-82997