Re: RFR: 8090123: Items are no longer visible when collection is changed [v2]

2023-02-20 Thread Karthik P K
On Mon, 20 Feb 2023 15:05:03 GMT, Lukasz Kostyra wrote: > I verified the changes on macOS and Windows - on both platforms > `testChoicBoxScrollOnCollectionChange` passes when it's run as the only test > (with `--tests '*testChoicBoxScrollOnCollectionChange'` option) but fails > when you run al

Re: RFR: 8090123: Items are no longer visible when collection is changed [v3]

2023-02-20 Thread Karthik P K
> When a large number of items were scrolled in the `ChoiceBox`, the scrolled > offset was carried forward when the list is replaced with small number of > items. Hence the scroll up arrow was displayed with empty popup. > > Changed code to scroll to top before popup display when content height

Re: RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v7]

2023-02-20 Thread Thiago Milczarek Sayao
> Simple PR to remove gtk2 library compilation and loading. Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Improve exception - Changes: - all: https://git.openjdk.org/jfx/pull/999/files - new: https://git.

CSS styling of Shape in TextFlow causes flickering

2023-02-20 Thread Scott Palmer
I'm seeing an odd issue with using CSS to colour a Shape when I have it as a child of a TextFlow. My use case is a "rich" text Cell in a tree or list. I want to have the text portion in multiple colours and so instead of using the graphic and text parts of a typical Cell, I'm using only the Graph

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v7]

2023-02-20 Thread John Hendrikx
On Mon, 20 Feb 2023 15:56:15 GMT, Kevin Rushforth wrote: >> John Hendrikx has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Ensure change listeners are not called recursively (single and generic) >> - Remove left over System.out.print

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v7]

2023-02-20 Thread Kevin Rushforth
On Mon, 20 Feb 2023 05:42:43 GMT, John Hendrikx wrote: >> This contains the following: >> - Nested changes or invalidations using ExpressionHelper are delayed until >> the current emission completes >> - This fixes odd change events being produced (with incorrect oldValue) >> - Also fixes a

Re: RFR: 8173321: TableView: Click on right trough has no effect when cell height is higher than viewport height [v9]

2023-02-20 Thread Kevin Rushforth
On Sat, 18 Feb 2023 15:32:48 GMT, JoachimSchriek wrote: >> This is my (joachim.schr...@gmx.de) first contribution to openjfx. My >> Contributor Agreement is signed but still in review. >> So please be patient with an absolute beginner as contributor ... . >> The work of this pull request was ful

Re: RFR: 8090123: Items are no longer visible when collection is changed [v2]

2023-02-20 Thread Lukasz Kostyra
On Mon, 20 Feb 2023 10:34:58 GMT, Karthik P K wrote: >> When a large number of items were scrolled in the `ChoiceBox`, the scrolled >> offset was carried forward when the list is replaced with small number of >> items. Hence the scroll up arrow was displayed with empty popup. >> >> Changed cod

RFR: 8300872: WebView's ColorChooser fails to initialize when running in security context

2023-02-20 Thread Jose Pereda
This PR removes an unnecessary check that was added as part of [JDK-8267551](https://bugs.openjdk.org/browse/JDK-8267551). As commented in the [issue](https://bugs.openjdk.org/browse/JDK-8300872), there were no failing/passing tests before/after these lines were added, and there are no actual t

Re: RFR: 8090123: Items are no longer visible when collection is changed [v2]

2023-02-20 Thread Karthik P K
On Fri, 17 Feb 2023 16:22:44 GMT, Karthik P K wrote: >> Yes it should be `downArrow.isVisible()`. I'll update the code. > > While this is a simple change, I thought of adding more checks on the > visibility of both up and down arrow in the test to avoid these types of > error in code. I'm seein

Re: RFR: 8090123: Items are no longer visible when collection is changed [v2]

2023-02-20 Thread Karthik P K
> When a large number of items were scrolled in the `ChoiceBox`, the scrolled > offset was carried forward when the list is replaced with small number of > items. Hence the scroll up arrow was displayed with empty popup. > > Changed code to scroll to top before popup display when content height