Re: RFR: 8090123: Items are no longer visible when collection is changed

2023-02-17 Thread Andy Goryachev
On Fri, 17 Feb 2023 12:33:31 GMT, Karthik P K wrote: > When a large number of items were scrolled in the `ChoiceBox`, the scrolled > offset was carried forward when the list is replaced with small number of > items. Hence the scroll up arrow was displayed with empty popup. > > Changed code to

Re: RFR: 8090123: Items are no longer visible when collection is changed

2023-02-17 Thread Karthik P K
On Fri, 17 Feb 2023 14:19:15 GMT, Karthik P K wrote: >> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ContextMenuContent.java >> line 827: >> >>> 825: >>> 826: boolean isDownArrowVisible() { >>> 827: return upArrow.isVisible(); >> >> Just to double-check, shou

Integrated: 8284662: [Win][Accessibility][ListCell] Screen reader fails to read ListView/ComboBox item count if > 100

2023-02-17 Thread Ambarish Rapte
On Thu, 16 Feb 2023 08:56:58 GMT, Ambarish Rapte wrote: > Accessibility client applications like Windows Narrator and JAWS read > positions of the items in a ListView/ComboBox as "index of total-item-count". > For example, in an ComboBox with 10 items, first item "Item1" would be read > as "Ite

Re: RFR: 8284662: [Win][Accessibility][ListCell] Screen reader fails to read ListView/ComboBox item count if > 100

2023-02-17 Thread Ajit Ghaisas
On Thu, 16 Feb 2023 08:56:58 GMT, Ambarish Rapte wrote: > Accessibility client applications like Windows Narrator and JAWS read > positions of the items in a ListView/ComboBox as "index of total-item-count". > For example, in an ComboBox with 10 items, first item "Item1" would be read > as "Ite

Re: RFR: 8090123: Items are no longer visible when collection is changed

2023-02-17 Thread Karthik P K
On Fri, 17 Feb 2023 13:37:51 GMT, Lukasz Kostyra wrote: >> When a large number of items were scrolled in the `ChoiceBox`, the scrolled >> offset was carried forward when the list is replaced with small number of >> items. Hence the scroll up arrow was displayed with empty popup. >> >> Changed

Re: RFR: 8284662: [Win][Accessibility][ListCell] Screen reader fails to read ListView/ComboBox item count if > 100

2023-02-17 Thread Kevin Rushforth
On Thu, 16 Feb 2023 08:56:58 GMT, Ambarish Rapte wrote: > Accessibility client applications like Windows Narrator and JAWS read > positions of the items in a ListView/ComboBox as "index of total-item-count". > For example, in an ComboBox with 10 items, first item "Item1" would be read > as "Ite

Re: RFR: 8090123: Items are no longer visible when collection is changed

2023-02-17 Thread Lukasz Kostyra
On Fri, 17 Feb 2023 12:33:31 GMT, Karthik P K wrote: > When a large number of items were scrolled in the `ChoiceBox`, the scrolled > offset was carried forward when the list is replaced with small number of > items. Hence the scroll up arrow was displayed with empty popup. > > Changed code to

Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v48]

2023-02-17 Thread Thiago Milczarek Sayao
On Fri, 17 Feb 2023 03:19:55 GMT, Thiago Milczarek Sayao wrote: >> This cleans size and positioning code, reducing special cases, code >> complexity and size. >> >> Changes: >> >> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different >> sizes. It does not assume any si

Re: [jfx17u] RFR: 8302470: Change JBS version in .jcheck/conf to jfxNN[.0.MM]

2023-02-17 Thread Ambarish Rapte
On Wed, 15 Feb 2023 12:57:39 GMT, Kevin Rushforth wrote: > In support of the JBS version change from "openjfxNN[.0.MM]" to > "jfxNN[.0.MM]", we need to update the JBS version in .jcheck/conf in each > active code line. > > The planned cut-over date is Tuesday, Feb 28. I will integrate this PR

Re: RFR: 8302470: Change JBS version in .jcheck/conf to jfxNN[.0.MM]

2023-02-17 Thread Ambarish Rapte
On Wed, 15 Feb 2023 12:57:22 GMT, Kevin Rushforth wrote: > In support of the JBS version change from "openjfxNN[.0.MM]" to > "jfxNN[.0.MM]", we need to update the JBS version in .jcheck/conf in each > active code line. > > The planned cut-over date is Tuesday, Feb 28. I will integrate this PR

Re: [jfx11u] RFR: 8302470: Change JBS version in .jcheck/conf to jfxNN[.0.MM]

2023-02-17 Thread Ambarish Rapte
On Wed, 15 Feb 2023 12:59:47 GMT, Kevin Rushforth wrote: > In support of the JBS version change from "openjfxNN[.0.MM]" to > "jfxNN[.0.MM]", we need to update the JBS version in .jcheck/conf in each > active code line. > > The planned cut-over date is Tuesday, Feb 28. I will integrate this PR

Re: [jfx20] RFR: 8302470: Change JBS version in .jcheck/conf to jfxNN[.0.MM]

2023-02-17 Thread Ambarish Rapte
On Wed, 15 Feb 2023 12:56:57 GMT, Kevin Rushforth wrote: > In support of the JBS version change from "openjfxNN[.0.MM]" to > "jfxNN[.0.MM]", we need to update the JBS version in .jcheck/conf in each > active code line. > > The planned cut-over date is Tuesday, Feb 28. I will integrate this PR

Integrated: 8302684 : Cherry-pick WebKit 615.1 stabilization fixes (2)

2023-02-17 Thread Hima Bindu Meda
On Thu, 16 Feb 2023 19:29:26 GMT, Hima Bindu Meda wrote: > Stabilization fixes from Webkitgtk-2.38.5. > Verified drt and unit tests. No issues observed. This pull request has now been integrated. Changeset: 67c2b7a1 Author:Hima Bindu Meda Committer: Kevin Rushforth URL: https://git

RFR: 8090123: Items are no longer visible when collection is changed

2023-02-17 Thread Karthik P K
When a large number of items were scrolled in the `ChoiceBox`, the scrolled offset was carried forward when the list is replaced with small number of items. Hence the scroll up arrow was displayed with empty popup. Changed code to scroll to top before popup display when content height of `Choic

Re: RFR: 8302684 : Cherry-pick WebKit 615.1 stabilization fixes (2)

2023-02-17 Thread Joeri Sykora
On Thu, 16 Feb 2023 19:29:26 GMT, Hima Bindu Meda wrote: > Stabilization fixes from Webkitgtk-2.38.5. > Verified drt and unit tests. No issues observed. Building and testing completed without issues. - Marked as reviewed by sykora (Author). PR: https://git.openjdk.org/jfx/pull/103

Re: CFV: New OpenJFX Reviewer: Jose Pereda

2023-02-17 Thread Jeanette Winzenburg
Vote: yes Zitat von Kevin Rushforth : I hereby nominate Jose Pereda [1] to OpenJFX Reviewer. Jose is an OpenJFX community member, who has contributed 59 commits [2][3] to OpenJFX. Votes are due by March 2, 2023 at 23:59 UTC. Only current OpenJFX Reviewers [4] are eligible to vote on this

Re: RFR: 8302472 WebColorFieldSkin should use precompiled Pattern

2023-02-17 Thread Ajit Ghaisas
On Tue, 14 Feb 2023 16:12:29 GMT, John Hendrikx wrote: > Split off from https://github.com/openjdk/jfx/pull/837 > > This uses a precompiled regex pattern and cleans up the code in > WebColorFieldSkin a bit. This looks good! - Marked as reviewed by aghaisas (Reviewer). PR: https:

Re: CFV: New OpenJFX Reviewer: Jose Pereda

2023-02-17 Thread John Hendrikx
Vote: Yes On 17/02/2023 00:24, Kevin Rushforth wrote: I hereby nominate Jose Pereda [1] to OpenJFX Reviewer. Jose is an OpenJFX community member, who has contributed 59 commits [2][3] to OpenJFX. Votes are due by March 2, 2023 at 23:59 UTC. Only current OpenJFX Reviewers [4] are eligible to

Re: CFV: New OpenJFX Reviewer: Jose Pereda

2023-02-17 Thread Ajit Ghaisas
Vote : YES Regards, Ajit > On 17-Feb-2023, at 4:54 AM, Kevin Rushforth > wrote: > > I hereby nominate Jose Pereda [1] to OpenJFX Reviewer. > > Jose is an OpenJFX community member, who has contributed 59 commits [2][3] to > OpenJFX. > > Votes are due by March 2, 2023 at 23:59 UTC. > > Only

Re: CFV: New OpenJFX Reviewer: Jose Pereda

2023-02-17 Thread Johan Vos
Vote: Yes On Fri, Feb 17, 2023 at 12:25 AM Kevin Rushforth wrote: > I hereby nominate Jose Pereda [1] to OpenJFX Reviewer. > > Jose is an OpenJFX community member, who has contributed 59 commits > [2][3] to OpenJFX. > > Votes are due by March 2, 2023 at 23:59 UTC. > > Only current OpenJFX Review

Re: CFV: New OpenJFX Reviewer: Jose Pereda

2023-02-17 Thread Nir Lisker
Vote: Yes On Fri, Feb 17, 2023, 04:54 Philip Race wrote: > Vote: yes > > -phil > >