On Fri, 10 Feb 2023 05:39:33 GMT, Karthik P K wrote:
>> When Text width was more than TextField width, the logic to update
>> `textTranslateX` in `updateCaretOff` method was causing the issue of
>> unexpected behavior for Right and Center alignment.
>>
>> Made changes to update `textTranslateX
On Mon, 13 Feb 2023 00:15:04 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any si
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on t
On Thu, 16 Feb 2023 19:29:26 GMT, Hima Bindu Meda wrote:
> Stabilization fixes from Webkitgtk-2.38.5.
> Verified drt and unit tests. No issues observed.
Looks good. Testing is green.
@tiainen or @johanvos could one of you be the second reviewer?
-
Marked as reviewed by kcr (Lead).
Vote: yes
-phil
Vote: YES
-- Kevin
On 2/16/2023 3:24 PM, Kevin Rushforth wrote:
I hereby nominate Jose Pereda [1] to OpenJFX Reviewer.
I hereby nominate Jose Pereda [1] to OpenJFX Reviewer.
Jose is an OpenJFX community member, who has contributed 59 commits
[2][3] to OpenJFX.
Votes are due by March 2, 2023 at 23:59 UTC.
Only current OpenJFX Reviewers [4] are eligible to vote on this
nomination. Votes must be cast in the ope
On Thu, 16 Feb 2023 18:54:18 GMT, Kevin Rushforth wrote:
>> @prrace What is your preference here?
>> Since `enterNestedEventLoop` and `exitNestedEventLoop` throw an exception
>> when not on the fx user thread, I feel like it makes sense to also add it
>> here as well.
>
> Phil's comment got me
On Thu, 16 Feb 2023 21:48:08 GMT, Marius Hanl wrote:
>> This PR adds the last missing method for dealing with nested event loops.
>> As also written in the ticket, there is currently no (public) way to find
>> out whether it is safe to start an event loop now or not.
>> Classes like `Dialog` che
On Wed, 15 Feb 2023 21:39:02 GMT, Kevin Rushforth wrote:
>> Should I also adjust the `Toolkit` javadoc or only the `Platform` one?
>
> It might be a good idea to also adjust the Toolkit docs; it doesn't get
> generated as javadoc, but could be useful for someone looking at the code. If
> you do
On Thu, 16 Feb 2023 18:25:23 GMT, Marius Hanl wrote:
>> So someone is asking a question when they call this.
>> Throwing an Exception could be considered an unfriendly way of answering it.
>> It only makes sense if you think the programmer will have enough information
>> to be sure that if S/HE
On Thu, 16 Feb 2023 03:45:28 GMT, Phil Race wrote:
>> It might be a good idea to also adjust the Toolkit docs; it doesn't get
>> generated as javadoc, but could be useful for someone looking at the code.
>> If you do, it wouldn't be part of the CSR, since Toolkit isn't API.
>
> So someone is as
> This PR adds the last missing method for dealing with nested event loops.
> As also written in the ticket, there is currently no (public) way to find out
> whether it is safe to start an event loop now or not.
> Classes like `Dialog` check via
> `Toolkit.getToolkit().canStartNestedEventLoop()`
On Fri, 10 Feb 2023 05:39:33 GMT, Karthik P K wrote:
>> When Text width was more than TextField width, the logic to update
>> `textTranslateX` in `updateCaretOff` method was causing the issue of
>> unexpected behavior for Right and Center alignment.
>>
>> Made changes to update `textTranslateX
On Fri, 10 Feb 2023 05:39:33 GMT, Karthik P K wrote:
>> When Text width was more than TextField width, the logic to update
>> `textTranslateX` in `updateCaretOff` method was causing the issue of
>> unexpected behavior for Right and Center alignment.
>>
>> Made changes to update `textTranslateX
Stabilization fixes from Webkitgtk-2.38.5.
Verified drt and unit tests. No issues observed.
-
Commit messages:
- white space correction
- Cherry-pick stabilisation fixes till 2.38.5
Changes: https://git.openjdk.org/jfx/pull/1038/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&
On Thu, 16 Feb 2023 08:56:58 GMT, Ambarish Rapte wrote:
> Accessibility client applications like Windows Narrator and JAWS read
> positions of the items in a ListView/ComboBox as "index of total-item-count".
> For example, in an ComboBox with 10 items, first item "Item1" would be read
> as "Ite
On Tue, 14 Feb 2023 16:12:29 GMT, John Hendrikx wrote:
> Split off from https://github.com/openjdk/jfx/pull/837
>
> This uses a precompiled regex pattern and cleans up the code in
> WebColorFieldSkin a bit.
modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/WebColorFieldSk
Each time a menu would change scenes, a new set of ListChangeListeners would be
added to the items in the menu. The bigger problem however is that these list
change listeners have a strong reference to the scene which is potentially a
much bigger leak.
The first commit was more straightforward,
On Wed, 15 Feb 2023 22:24:41 GMT, John Hendrikx wrote:
>> This fix hides mnemonics when the Scene's Window loses focus.
>>
>> Before integration, we need to make sure this is correct behavior for Mac
>> and Linux as well. It is correct for Windows.
>>
>> How to test:
>>
>> - Create a control
On Tue, 31 Jan 2023 10:30:22 GMT, Jose Pereda wrote:
> This PR simply applies the patch from
> [JDK-8218914](https://bugs.openjdk.org/browse/JDK-8218914) that solved the
> same issue for the JDK.
>
> I've tested it on Windows 11 (Version 22H2 Build 22621.1105).
>
> I have the Roboto font ins
On Tue, 31 Jan 2023 10:30:22 GMT, Jose Pereda wrote:
> This PR simply applies the patch from
> [JDK-8218914](https://bugs.openjdk.org/browse/JDK-8218914) that solved the
> same issue for the JDK.
>
> I've tested it on Windows 11 (Version 22H2 Build 22621.1105).
>
> I have the Roboto font ins
Accessibility client applications like Windows Narrator and JAWS read positions
of the items in a ListView/ComboBox as "index of total-item-count".
For example, in an ComboBox with 10 items, first item "Item1" would be read as
"Item one, one of ten". Similarly it appends the of
for all items.
On Mon, 23 Jan 2023 20:40:23 GMT, Jose Pereda wrote:
> Given a TableView with multiple and cell selection modes enabled, three
> different but closely related issues are tackled with this PR:
>
> - Selection history, that is used to backtrack deselection of cells, removes
> deselected cells, s
24 matches
Mail list logo
