Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v5]

2023-02-14 Thread Ambarish Rapte
On Tue, 14 Feb 2023 16:03:52 GMT, John Hendrikx wrote: >> This contains the following: >> - Nested changes or invalidations using ExpressionHelper are delayed until >> the current emission completes >> - This fixes odd change events being produced (with incorrect oldValue) >> - Also fixes a

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v5]

2023-02-14 Thread John Hendrikx
On Tue, 14 Feb 2023 16:03:52 GMT, John Hendrikx wrote: >> This contains the following: >> - Nested changes or invalidations using ExpressionHelper are delayed until >> the current emission completes >> - This fixes odd change events being produced (with incorrect oldValue) >> - Also fixes a

Re: RFR: 8281327: JavaFX does not support fonts installed per-user on Windows 10/11

2023-02-14 Thread Phil Race
On Tue, 31 Jan 2023 10:30:22 GMT, Jose Pereda wrote: > This PR simply applies the patch from > [JDK-8218914](https://bugs.openjdk.org/browse/JDK-8218914) that solved the > same issue for the JDK. > > I've tested it on Windows 11 (Version 22H2 Build 22621.1105). > > I have the Roboto font ins

Re: RFR: 8302294 : Cherry-pick WebKit 615.1 stabilization fixes

2023-02-14 Thread Kevin Rushforth
On Tue, 14 Feb 2023 18:19:17 GMT, Hima Bindu Meda wrote: > Cherry-pick stabilisation fixes till 2.38.4. > Verified unit tests and drt. No issue observed. Reviewers: @kevinrushforth and @johanvos or @tiainen @jaybhaskar Can you also take a look? - PR: https://git.openjdk.org/jfx/p

RFR: 8302294 : Cherry-pick WebKit 615.1 stabilization fixes

2023-02-14 Thread Hima Bindu Meda
Cherry-pick stabilisation fixes till 2.38.4. Verified unit tests and drt. No issue observed. - Commit messages: - Cherry-pick WebKit 614.1 stabilization fixes till 2.38.4 Changes: https://git.openjdk.org/jfx/pull/1033/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1033&rang

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v2]

2023-02-14 Thread Nir Lisker
On Sun, 5 Feb 2023 20:11:35 GMT, John Hendrikx wrote: > I don't think we should care about depth-first, breadth-first. The only thing > that I think is important here is that the contract of ChangeListener is > respected. I think that that contract should be: ... I'll be more concrete. Here is

RFR: 8302472 WebColorFieldSkin should use precompiled Pattern

2023-02-14 Thread John Hendrikx
Split off from https://github.com/openjdk/jfx/pull/837 This uses a precompiled regex pattern and cleans up the code in WebColorFieldSkin a bit. - Commit messages: - Use a precompiled Pattern and simplify code Changes: https://git.openjdk.org/jfx/pull/1032/files Webrev: https://we

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v5]

2023-02-14 Thread John Hendrikx
> This contains the following: > - Nested changes or invalidations using ExpressionHelper are delayed until > the current emission completes > - This fixes odd change events being produced (with incorrect oldValue) > - Also fixes a bug in ExpressionHelper where a nested change would unlock >

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v3]

2023-02-14 Thread John Hendrikx
On Tue, 14 Feb 2023 14:35:23 GMT, Ambarish Rapte wrote: >> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Add copyright header >> - Merge branch 'master' of https://git.openjdk.org/jfx into

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v4]

2023-02-14 Thread John Hendrikx
> This contains the following: > - Nested changes or invalidations using ExpressionHelper are delayed until > the current emission completes > - This fixes odd change events being produced (with incorrect oldValue) > - Also fixes a bug in ExpressionHelper where a nested change would unlock >

Integrated: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages

2023-02-14 Thread John Hendrikx
On Sun, 11 Dec 2022 20:12:17 GMT, John Hendrikx wrote: > Packages fixed: > - com.sun.javafx.binding > - com.sun.javafx.collections > - javafx.beans > - javafx.beans.binding > - javafx.collections > - javafx.collections.transformation This pull request has now been integrated. Changeset: d1572f4

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v3]

2023-02-14 Thread Ambarish Rapte
On Wed, 8 Feb 2023 14:54:52 GMT, John Hendrikx wrote: >> This contains the following: >> - Nested changes or invalidations using ExpressionHelper are delayed until >> the current emission completes >> - This fixes odd change events being produced (with incorrect oldValue) >> - Also fixes a b

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages [v5]

2023-02-14 Thread Ambarish Rapte
On Sun, 12 Feb 2023 21:49:11 GMT, John Hendrikx wrote: >> Packages fixed: >> - com.sun.javafx.binding >> - com.sun.javafx.collections >> - javafx.beans >> - javafx.beans.binding >> - javafx.collections >> - javafx.collections.transformation > > John Hendrikx has updated the pull request increment

Re: RFR: JDK-8302355: Public API for Toolkit.canStartNestedEventLoop()

2023-02-14 Thread Marius Hanl
On Tue, 14 Feb 2023 09:54:19 GMT, John Hendrikx wrote: > Okay, I found the use case you had, apparently you want to be able to show > dialogs from an uncaught exception handler which could trigger when an > exception occurs during layout. When it returns `false` you use > `Platform.runLater`,

Re: RFR: 8300893: Wrong state after deselecting two or more cells of a TableView selection

2023-02-14 Thread Ajit Ghaisas
On Mon, 23 Jan 2023 20:40:23 GMT, Jose Pereda wrote: > Given a TableView with multiple and cell selection modes enabled, three > different but closely related issues are tackled with this PR: > > - Selection history, that is used to backtrack deselection of cells, removes > deselected cells, s

Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v47]

2023-02-14 Thread Thiago Milczarek Sayao
On Mon, 13 Feb 2023 00:15:04 GMT, Thiago Milczarek Sayao wrote: >> This cleans size and positioning code, reducing special cases, code >> complexity and size. >> >> Changes: >> >> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different >> sizes. It does not assume any si

Re: RFR: 8260528: Clean glass-gtk sizing and positioning code [v47]

2023-02-14 Thread Thiago Milczarek Sayao
On Mon, 13 Feb 2023 00:15:04 GMT, Thiago Milczarek Sayao wrote: >> This cleans size and positioning code, reducing special cases, code >> complexity and size. >> >> Changes: >> >> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different >> sizes. It does not assume any si

Re: RFR: 8088998: XYChart: duplicate child added exception when remove & add a series in several charts [v4]

2023-02-14 Thread Ajit Ghaisas
On Fri, 10 Feb 2023 05:28:07 GMT, Karthik P K wrote: >> While checking for duplicate series addition to the line chart, >> `setToRemove` value was not considered before throwing exception. Hence code >> to handling the case of adding the removed series was never run. >> >> Added condition to c

Integrated: 8088998: XYChart: duplicate child added exception when remove & add a series in several charts

2023-02-14 Thread Karthik P K
On Mon, 30 Jan 2023 12:21:38 GMT, Karthik P K wrote: > While checking for duplicate series addition to the line chart, `setToRemove` > value was not considered before throwing exception. Hence code to handling > the case of adding the removed series was never run. > > Added condition to check

Re: RFR: JDK-8302355: Public API for Toolkit.canStartNestedEventLoop()

2023-02-14 Thread John Hendrikx
On Mon, 13 Feb 2023 19:31:56 GMT, Marius Hanl wrote: > This PR adds the last missing method for dealing with nested event loops. > As also written in the ticket, there is currently no (public) way to find out > whether it is safe to start an event loop now or not. > Classes like `Dialog` check v

Re: RFR: JDK-8302355: Public API for Toolkit.canStartNestedEventLoop()

2023-02-14 Thread John Hendrikx
On Mon, 13 Feb 2023 19:31:56 GMT, Marius Hanl wrote: > This PR adds the last missing method for dealing with nested event loops. > As also written in the ticket, there is currently no (public) way to find out > whether it is safe to start an event loop now or not. > Classes like `Dialog` check v