> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on t
On Mon, 23 Jan 2023 03:51:33 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any si
I'm seeing a hard crash in native code that brings down the JVM when I
accidentally called removeChild on an element from a WebView Document while
not on the Platform thread. While I know it's my error, bringing down the
JVM instead of throwing an exception seems wrong.
Should this be considered
On Sun, 12 Feb 2023 21:49:11 GMT, John Hendrikx wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> John Hendrikx has updated the pull request increment
Well, it is not a permanent solution, just a way to test to see if it
actually solves your problem.
--John
On 12/02/2023 23:23, Pedro Duque Vieira wrote:
.. all in all of course, I'd prefer a solution that properly fixes
this bug and not have to rely on hacks that are prone to break in the
fu
.. all in all of course, I'd prefer a solution that properly fixes this bug
and not have to rely on hacks that are prone to break in the future or code
that needs to circumvent encapsulation or the module system. So either one
is unlikely to be a fix I'm happy with.
Thanks for considering submitti
This fix hides mnemonics when the Scene's Window loses focus.
Before integration, we need to make sure this is correct behavior for Mac and
Linux as well. It is correct for Windows.
How to test:
- Create a control with a mnemonic
- Alt-tab to another window (mnemonics appear when alt is pressed
John,
Thank you very much for submitting a work around. Unfortunately, since
there were other higher priority bugs and features and we're very close to
a release, I wasn't allocated time to work on this much more than sending a
message to this mailing list to warn of the existence of this bug.
Not
I'm not sure if you are able to test this yourself, but I made a fix for
this problem.
You could potentially test it by copying the class `javafx.scene.Scene`
in your project (without changing the package -- and if modules will
allow it, I don't use them personally) and then using this piece o
On Sun, 12 Feb 2023 21:49:11 GMT, John Hendrikx wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> John Hendrikx has updated the pull request increment
> Packages fixed:
> - com.sun.javafx.binding
> - com.sun.javafx.collections
> - javafx.beans
> - javafx.beans.binding
> - javafx.collections
> - javafx.collections.transformation
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Fix re
On Sun, 12 Feb 2023 18:35:40 GMT, Nir Lisker wrote:
>> Can make these consistent if the approach is agreed upon.
>
> So let's make the list and the set use an instance singleton pattern, like
> the empty list does.
Fixed
-
PR: https://git.openjdk.org/jfx/pull/972
On Sun, 12 Feb 2023 16:31:35 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>> commits
On Sun, 1 Jan 2023 15:25:01 GMT, John Hendrikx wrote:
>> modules/javafx.base/src/main/java/javafx/collections/FXCollections.java line
>> 1640:
>>
>>> 1638: @Override
>>> 1639: public Iterator iterator() {
>>> 1640: return new Iterator<>() {
>>
>> Here the empty `Set
On Wed, 8 Feb 2023 15:05:46 GMT, John Hendrikx wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> John Hendrikx has updated the pull request with a new
>
> The behavior on Windows is all over the place for different
> applications.? I tested a few I've got running:
Notepad, Notepad++, Eclipse:
- Alt-down: Shows mnemonics on menu bar
> - Alt-up: Highlights file menu on alt release
> - Alt-tab: Shows mnemonics but doesn't highlight menu when it
Hi,
For jfree.FXGraphics2D, I implemented the proposed approach in the new
GCHandler:
https://github.com/jfree/fxgraphics2d/blob/1994b9cb3a9bff93bf95100d398756d7f9f626c2/src/main/java/org/jfree/fx/GCStateHandler.java
It boosts fxG2D performance & correctness.
Ideally, such methods getSavePoint()
17 matches
Mail list logo
