Re: [External] : Re: Q: missing APIs needed for implementation of a rich text control

2023-01-27 Thread Andy Goryachev
Martin: I am trying to collect the JBS tickets that might impact a rich text control. I am not sure why Windows does not go through InputMethodEvents, but it looks like there is enough inconsistency in the behavior on Linux to warrant a defect. Looks like someone was working on a fix and then

Re: RFR: 8290765: Remove parent disabled/treeVisible listeners [v2]

2023-01-27 Thread John Hendrikx
On Fri, 26 Aug 2022 00:22:54 GMT, Michael Strauß wrote: > It's true that `Parent.getChildren()` must not return `null`, and that we > shouldn't add null checks to protect against bugs. > > However, in this specific instance, `Node.setTreeVisible` is called from the > constructor of `Node`. At

Re: Q: missing APIs needed for implementation of a rich text control

2023-01-27 Thread Martin Fox
Andy, Could you elaborate on why you want to see KeyEvents for dead keys on Linux? https://bugs.openjdk.org/browse/JDK-8172867 On Windows dead keys are delivered as KeyEvents. The dead keys generate KEY_PRESSED events and the final composed character is delivered in a KEY_TYPED event. This ref

Re: Q: missing APIs needed for implementation of a rich text control

2023-01-27 Thread Scott Palmer
When I was experimenting with a program to generate titles for videos the ability to control the spacing between letters (not kerning, but tracking) would have been helpful. E.g. animating something like this: Title T i t l e T i t l e T i t l e I don't recall everything I encountered i

Re: Q: missing APIs needed for implementation of a rich text control

2023-01-27 Thread Andy Goryachev
> More control of kerning and general spacing might be nice. What properties, besides kerning, are you referring to? Also, a question for the wider audience: is there a need to have caretBlinkRate property for each control, or a single global one would suffice? In other words, are there use c

Re: StageStyle.TOOLKIT_DECORATED

2023-01-27 Thread Thiago Milczarek Sayão
Looking further into it, seems this is the way to go: https://github.com/openjdk/jfx/pull/594 Em qui., 26 de jan. de 2023 às 21:08, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > I have begun to implement a StageStyle variation called TOOLKIT_DECORATED > (better naming welcome). >

Re: [External] : Re: Q: missing APIs needed for implementation of a rich text control

2023-01-27 Thread Andy Goryachev
Thank you. Added the project to the list. -andy From: Mike Hearn Date: Friday, January 27, 2023 at 06:05 To: Andy Goryachev Cc: openjfx-dev@openjdk.org Subject: [External] : Re: Q: missing APIs needed for implementation of a rich text control I'm sure you're aware already, but there is this:

Re: [jfx20] RFR: 8300013: Node.focusWithin doesn't account for nested focused nodes

2023-01-27 Thread Kevin Rushforth
On Thu, 12 Jan 2023 12:38:51 GMT, Kevin Rushforth wrote: >> I think this should go into JavaFX 20. > >> I think this should go into JavaFX 20. > > I agree. In the (very likely) case it doesn't get reviewed before the fork, > I'll ask you to retarget it to the `jfx20` branch. > @kevinrushforth

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v7]

2023-01-27 Thread John Hendrikx
On Thu, 26 Jan 2023 09:54:25 GMT, Florian Kirmaier wrote: >> After thinking about this issue for some time, I've now got a solution. >> I know put the scene in the state it is, before is was shown, when the >> dirtyNodes are unset, the whole scene is basically considered dirty. >> This has the

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v7]

2023-01-27 Thread John Hendrikx
On Thu, 26 Jan 2023 09:54:25 GMT, Florian Kirmaier wrote: >> After thinking about this issue for some time, I've now got a solution. >> I know put the scene in the state it is, before is was shown, when the >> dirtyNodes are unset, the whole scene is basically considered dirty. >> This has the

Re: Q: missing APIs needed for implementation of a rich text control

2023-01-27 Thread Mike Hearn
I'm sure you're aware already, but there is this: https://github.com/gluonhq/rich-text-area It's missing from your list of open source projects in the ticket. It is the most recent, I think, so Gluon would have the most insight into what's required. On Wed, 25 Jan 2023 at 23:40, Andy Goryachev

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v7]

2023-01-27 Thread John Hendrikx
On Thu, 26 Jan 2023 18:04:41 GMT, Michael Strauß wrote: >> Florian Kirmaier has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - JDK-8269907 >>Added missing changes after merge >> - Merge remote-tracking br

Re: RFR: 8269907 memory leak - Dirty Nodes / Parent removed [v7]

2023-01-27 Thread John Hendrikx
On Thu, 26 Jan 2023 09:54:25 GMT, Florian Kirmaier wrote: >> After thinking about this issue for some time, I've now got a solution. >> I know put the scene in the state it is, before is was shown, when the >> dirtyNodes are unset, the whole scene is basically considered dirty. >> This has the