I'm seeing something odd with the alignment of content in a TextFlow and
I'm not sure if I'm doing something wrong, or if there is a bug there.
The getBaselineOffset() method of the StackPane is returning inconsistent
values. If I sub-class it to force a constant offset, everything works.
Since th
On Tue, 24 Jan 2023 09:59:48 GMT, Ajit Ghaisas wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/ListView.java
>> line 152:
>>
>>> 150: * Warning: Nodes should not be inserted directly into the items
>>> list
>>> 151: * ListView allows for the items list to contain element
On Tue, 24 Jan 2023 10:35:36 GMT, Ajit Ghaisas wrote:
> >
>
> @nlisker, Can you please file an issue explaining how exactly you would like
> `ListView` documentation to be restructured?
Yes, I'll probably work on it during RDP 2. It's not the only control I want to
go over.
-
P
On Tue, 24 Jan 2023 10:40:36 GMT, Ajit Ghaisas wrote:
>> This PR adds a warning about inserting Nodes directly into the virtualized
>> containers such as ListView, TreeView, TableView and TreeTableView. It also
>> adds code snippets showing the recommended pattern of using a custom cell
>> fac
> Merge `jfx20` branch into `master`.
Kevin Rushforth has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains five additional
commits since the last revision:
On Tue, 24 Jan 2023 15:01:57 GMT, Kevin Rushforth wrote:
> Merge `jfx20` branch into `master`.
This pull request has now been integrated.
Changeset: e710b558
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx/commit/e710b55812fbddf45e3e8069e91dd646ae397da8
Stats: 25 lines i
Merge `jfx20` branch into `master`.
-
Commit messages:
- Merge jfx20
- 8300664: Missing copyright header in ConditionalBinding.java file
The merge commit only contains trivial merges, so no merge-specific webrevs
have been generated.
Changes: https://git.openjdk.org/jfx/pull/1010
On Tue, 24 Jan 2023 10:40:36 GMT, Ajit Ghaisas wrote:
>> This PR adds a warning about inserting Nodes directly into the virtualized
>> containers such as ListView, TreeView, TableView and TreeTableView. It also
>> adds code snippets showing the recommended pattern of using a custom cell
>> fac
On Fri, 20 Jan 2023 11:16:04 GMT, Ajit Ghaisas wrote:
>> This PR adds a warning about inserting Nodes directly into the virtualized
>> containers such as ListView, TreeView, TableView and TreeTableView. It also
>> adds code snippets showing the recommended pattern of using a custom cell
>> fac
> This PR adds a warning about inserting Nodes directly into the virtualized
> containers such as ListView, TreeView, TableView and TreeTableView. It also
> adds code snippets showing the recommended pattern of using a custom cell
> factory for each of the virtualized control.
Ajit Ghaisas has
On Fri, 20 Jan 2023 12:39:03 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Additional review fixes
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ComboBox.java line
> 147:
>
On Thu, 19 Jan 2023 05:24:06 GMT, Nir Lisker wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove extra spaces
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ListView.java line
> 152:
>
>> 150:
Hi Andy,
see my comments below:
On Mon, Jan 23, 2023 at 10:33 PM Andy Goryachev
wrote:
>
> Let me backtrack a bit and ask a very specific question: what is the problem
> (or problems) you are trying to solve?
> I would like to understand if the problem exists (more on that below), does a
> wo
13 matches
Mail list logo
