On Thu, 12 Jan 2023 08:53:14 GMT, Florian Kirmaier
wrote:
>> Making the initial listener of the ListProperty weak fixes the problem.
>> The same is fixed for Set and Map.
>> Due to a smart implementation, this is done without any performance drawback.
>> (The trick is to have an object, which is
Hi Pedro,
see my comments below.
On Sat, Jan 21, 2023 at 5:19 PM Pedro Duque Vieira
wrote:
> I've been building javafx themes for years now. Started creating JMetro in
> JavaFX version 2. During this time I've been following how other themes are
> being built and I can say that about 90% of t
Hi,
TableView data usually comes from a database and is mapped to java objects
(I don't have actual statistics on this but it's probably a true assertion).
It Would be very useful if we could just copy database mapped objects to
javafx observables and say: Display it on a tableview.
Configuration
> This PR adds style themes as a first-class concept to OpenJFX. A style theme
> is a collection of stylesheets and the logic that governs them. Style themes
> can respond to OS notifications and update their stylesheets dynamically.
> This PR also re-implements Caspian and Modena as style theme
> This PR adds style themes as a first-class concept to OpenJFX. A style theme
> is a collection of stylesheets and the logic that governs them. Style themes
> can respond to OS notifications and update their stylesheets dynamically.
> This PR also re-implements Caspian and Modena as style theme
> This PR adds style themes as a first-class concept to OpenJFX. A style theme
> is a collection of stylesheets and the logic that governs them. Style themes
> can respond to OS notifications and update their stylesheets dynamically.
> This PR also re-implements Caspian and Modena as style theme
On Fri, 20 Jan 2023 19:06:32 GMT, Andy Goryachev wrote:
>> No check was present in `RadioMenuItem` accelerator to see if it is in a
>> `ToggleGroup` or not.
>>
>> Made changes to check if `RadioMenuItem` is part of `ToggleGroup` or not. If
>> it is part of a `ToggleGroup`, then it can not be c
On Mon, 26 Dec 2022 19:08:55 GMT, JoachimSchriek wrote:
> This is my (joachim.schr...@gmx.de) first contribution to openjfx. My
> Contributor Agreement is signed but still in review.
> So please be patient with an absolute beginner as contributor ... .
> The work of this pull request was fully d
On Sat, 21 Jan 2023 15:25:51 GMT, John Hendrikx wrote:
> Added a copyright header.
This pull request has now been integrated.
Changeset: 05a67df6
Author:John Hendrikx
Committer: Kevin Rushforth
URL:
https://git.openjdk.org/jfx/commit/05a67df666bbcfc48299346005aa07b1e9d48ab5
Stats:
Sure, checkboxes allow multiple selection in general, but as I've
said, I've come across lots of examples where applications use
radio-like checkboxes to do precisely what Andy proposed: create a
group of toggles where either one toggle or no toggle can be selected
at any given time. I'm not saying
On Mon, 26 Dec 2022 19:08:55 GMT, JoachimSchriek wrote:
> This is my (joachim.schr...@gmx.de) first contribution to openjfx. My
> Contributor Agreement is signed but still in review.
> So please be patient with an absolute beginner as contributor ... .
> The work of this pull request was fully d
We already have ToggleButton:
Unlike RadioButtons, ToggleButtons in a ToggleGroup do not attempt to force
> at least one selected ToggleButton in the group.
That is, if a ToggleButton is selected, clicking on it will cause it to
> become unselected.
With RadioButton, clicking on the selected but
My expectation with radio groups is that they may start out initially
unselected, but once a selection has been made, no user interaction
can unselect all toggles again.
I don't see any compelling reason to change that. If the group needs
to be reset to its initial state, that's as easy as calling
On Sat, 21 Jan 2023 16:21:53 GMT, Thiago Milczarek Sayao
wrote:
>> This PR fixes 8273379.
>>
>> I reverted back to use GDK (from
>> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the
>> events.
>>
>> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).
On Sat, 21 Jan 2023 15:25:51 GMT, John Hendrikx wrote:
> Added a copyright header.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.org/jfx/pull/1007
I don't see it being especially useful. GUI's tend to work this way. I
remember it was the same in Swing.
On Sat, Jan 21, 2023 at 1:41 AM Kevin Rushforth
wrote:
>
>
> On 1/20/2023 2:57 PM, Andy Goryachev wrote:
>
> I just want to add one thing - the initial state of RadioMenuItems added
> to a m
> This PR fixes 8273379.
>
> I reverted back to use GDK (from
> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events.
>
> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).
>
> There's also some cleaup.
>
> To do general testing (two tests were add
Hi again Michael,
2-
> Currently, the order of precedence is as follows (from highest to lowest):
> 1. Node.style
> 2. Parent.stylesheets
> 3. Scene.stylesheets
> 4. StyleableProperty values set from code
> 5. Application.styleTheme
> 6. Application.userAgentStylesheet
I understand you're sugge
My 2 cents,
I agree with Kevin, I don't see this as a common feature in User Interfaces.
UX wise, like Kevin says, you usually start off with no radio button
selected and then after one is selected the user can't usually deselect the
radio buttons, he can only select another option in the group.
Added a copyright header.
-
Commit messages:
- Add copyright header
Changes: https://git.openjdk.org/jfx/pull/1007/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1007&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8300664
Stats: 25 lines in 1 file changed: 25 ins;
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on t
On Thu, 22 Dec 2022 22:08:15 GMT, Kevin Rushforth wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix redraw bug (black header)
>
> On my system, the latest change you made didn't make any difference. Not
On Tue, 17 Jan 2023 18:52:33 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any si
On Fri, 20 Jan 2023 23:17:01 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/native-glass/gtk/glass_dnd.cpp line 141:
>>
>>> 139: jobjectArray mimes;
>>> 140: gint dx, dy;
>>> 141: } enter_ctx = {NULL, FALSE, FALSE, NULL, 0, 0};
>>
>> it's funny how it's initialized here
24 matches
Mail list logo
