On Tue, 17 Jan 2023 11:40:47 GMT, John Hendrikx wrote:
> The logic of this code seems to have changed more than just the fixing bug.
> Why are the `prefHeight` functions now called with `-1`? Normally these
> should respect the content bias of the node involved.
>
I used `-1` while calling `p
> Ignore text condition was not considered in `computePrefHeight` method while
> calculating the Label height.
>
> Added `isIgnoreText` condition in `computePrefHeight` method while
> calculating Label height.
>
> Tests are present for all the ContentDisplay types. Modified tests which were
>
On Tue, 17 Jan 2023 18:52:33 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any si
On Wed, 18 Jan 2023 00:34:48 GMT, Thiago Milczarek Sayao
wrote:
>> This PR fixes 8273379.
>>
>> I reverted back to use GDK (from
>> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the
>> events.
>>
>> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).
On Wed, 18 Jan 2023 00:04:22 GMT, Thiago Milczarek Sayao
wrote:
>> Simple PR to remove gtk2 library compilation and loading.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Pre-review adjustments
I need to figur
> This PR fixes 8273379.
>
> I reverted back to use GDK (from
> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events.
>
> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).
>
> There's also some cleaup.
>
> To do general testing (two tests were add
On Tue, 17 Jan 2023 23:42:33 GMT, Kevin Rushforth wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Pre-review adjustments
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java
> Simple PR to remove gtk2 library compilation and loading.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Pre-review adjustments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/999/files
- new: https:/
On Tue, 17 Jan 2023 22:57:49 GMT, Thiago Milczarek Sayao
wrote:
> Simple PR to remove gtk2 library compilation and loading.
The changes are what I would expect. I left a few (fairly minor) inline
comments. I haven't tested it yet.
.idea/misc.xml line 4:
> 2:
> 3:
> 4:
This change is
Simple PR to remove gtk2 library compilation and loading.
-
Commit messages:
- Remove gtk2
- Merge branch 'openjdk:master' into master
- Merge branch 'openjdk:master' into master
- Merge branch 'openjdk:master' into master
- Merge branch 'openjdk:master' into master
- Merge bran
I don't disagree. It's a minor thing that I can workaround for now.
I would like to see improved support for CSS standards though. From
the little reading I did, it seems full CSS compliance would be very
complex, so I'm not sure what level of support to expect in JavaFX.
Standard functions for de
On Tue, 17 Jan 2023 19:37:26 GMT, Kevin Rushforth wrote:
> Merge `jfx20` branch into `master`.
This pull request has now been integrated.
Changeset: 89219b70
Author:Kevin Rushforth
URL:
https://git.openjdk.org/jfx/commit/89219b70f8760dc6bd4e827e22c8190fdf3fea99
Stats: 362 lines
> Merge `jfx20` branch into `master`.
Kevin Rushforth has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains two additional
commits since the last revision:
Merge `jfx20` branch into `master`.
-
Commit messages:
- Merge jfx20
- Merge
- 8299628: BMP top-down images fail to load after JDK-8289336
- Merge
- Merge
- Merge
- Merge
- 8294779: Improve FX pages
- 8289336: Better platform image support
- Merge
- ... and 4 more: https://
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on t
approved.
Op di 17 jan. 2023 om 17:56 schreef Kevin Rushforth <
kevin.rushfo...@oracle.com>:
> Hi Johan,
>
> I request approval to sync changes from to the just-released January
> 2023 CPU release into the 'jfx20' branch of the 'jfx' repo. Here is the
> aggregate set of changes for the fixes:
>
>
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on t
I don't think it makes a lot of sense to add even more non-standard
functions to JavaFX CSS. Instead we should work towards bringing our
implementation closer to the web standard.
You wrote that it might not be worth to wait for the standard; does
that mean that you'd get a lot of value from this p
> This PR fixes 8273379.
>
> I reverted back to use GDK (from
> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events.
>
> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).
>
> There's also some cleaup.
>
> To do general testing (two tests were add
Voting for John Hendrikx [1] to OpenJFX Committer [2] is now closed.
Yes: 8
Veto: 0
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this is sufficient
to approve the nomination.
-- Kevin
[1] https://openjdk.java.net/census#jhendrikx
[2] https://mail.openjdk.org/pipermail/op
Hi Johan,
I request approval to sync changes from to the just-released January
2023 CPU release into the 'jfx20' branch of the 'jfx' repo. Here is the
aggregate set of changes for the fixes:
https://github.com/kevinrushforth/jfx/compare/8136b11fdc...cpu-2301-sync
NOTE: Since this is an integ
On Mon, 16 Jan 2023 11:24:46 GMT, Ajit Ghaisas wrote:
>> This PR adds a warning about inserting Nodes directly into the virtualized
>> containers such as ListView, TreeView, TableView and TreeTableView. It also
>> adds code snippets showing the recommended pattern of using a custom cell
>> fac
On Thu, 12 Jan 2023 11:11:23 GMT, Lukasz Kostyra wrote:
> Windows implementation of GlassClipboard.cpp uses IStorage interface in
> `PopImage()` to allocate a temporary file, which is then used to capture
> Image data from system clipboard and move it to JVM side. In order for
> temporary file
On Tue, 17 Jan 2023 13:18:10 GMT, Lukasz Kostyra wrote:
> We could do it this way, my main worry is that during the test some other
> application running in the system will use the Temp directory
I was going to make that same comment. This seems fragile to me.
> If we did this only for Windows
On Thu, 12 Jan 2023 11:11:23 GMT, Lukasz Kostyra wrote:
> Windows implementation of GlassClipboard.cpp uses IStorage interface in
> `PopImage()` to allocate a temporary file, which is then used to capture
> Image data from system clipboard and move it to JVM side. In order for
> temporary file
On Mon, 16 Jan 2023 20:14:25 GMT, Johan Vos wrote:
> Bump JavaFX release version to 19.0.2
This pull request has now been integrated.
Changeset: 2e17f7ae
Author:Johan Vos
URL:
https://git.openjdk.org/jfx/commit/2e17f7ae78bf5d75812f862d0f04941be4222961
Stats: 2 lines in 2 files c
On Mon, 16 Jan 2023 20:14:25 GMT, Johan Vos wrote:
> Bump JavaFX release version to 19.0.2
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.org/jfx/pull/997
On Thu, 12 Jan 2023 11:11:23 GMT, Lukasz Kostyra wrote:
> Windows implementation of GlassClipboard.cpp uses IStorage interface in
> `PopImage()` to allocate a temporary file, which is then used to capture
> Image data from system clipboard and move it to JVM side. In order for
> temporary file
On Fri, 13 Jan 2023 04:04:54 GMT, Michael Strauß wrote:
>> When a scene graph contains multiple nested focused nodes (this can happen
>> with `TableView` and other controls), the `focusWithin` bits that are
>> cleared when a focused node is de-focused must only be cleared when there is
>> no o
On Mon, 16 Jan 2023 10:46:12 GMT, Karthik P K wrote:
> Ignore text condition was not considered in `computePrefHeight` method while
> calculating the Label height.
>
> Added `isIgnoreText` condition in `computePrefHeight` method while
> calculating Label height.
>
> Tests are present for all
On Thu, 12 Jan 2023 11:11:23 GMT, Lukasz Kostyra wrote:
> Windows implementation of GlassClipboard.cpp uses IStorage interface in
> `PopImage()` to allocate a temporary file, which is then used to capture
> Image data from system clipboard and move it to JVM side. In order for
> temporary file
It would be nice to support something like LESS (https://lesscss.org/).
I've integrated a LESS parser in my personal project that takes .less
files and converts them to CSS before giving them to JavaFX. This
allows me to use functions like "fade" and "lighten":
-fx-background-color: fade
32 matches
Mail list logo
