Re: RFR: 8299423: JavaFX Mac system menubar leaks [v5]

> On Jan 16, 2023, at 10:33 PM, Scott Palmer wrote: > > There are third-party libraries for better integration with the Mac menu bar. > > E.g. https://github.com/codecentric/NSMenuFX > > > Though I wish this wasn’t necessary and proper hooks were pre

Re: RFR: 8273379 - GTK3 stops sending key events during drag and drop [v21]

> This PR fixes 8273379. > > I reverted back to use GDK (from > [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events. > > It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383). > > There's also some cleaup. > > To do general testing (two tests were add

Re: RFR: 8273379 - GTK3 stops sending key events during drag and drop [v20]

> This PR fixes 8273379. > > I reverted back to use GDK (from > [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events. > > It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383). > > There's also some cleaup. > > To do general testing (two tests were add

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v5]

Not directly related but I recently was looking at the Mac system menubar for javaFX applications noticing that they do not get an ‘About’ menu item in the Application menu. I filed a bug that was just accepted today. JDK-8300180 : [macos] Default About menu item not shown for javaFX applicatio

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v2]

On Tue, 3 Jan 2023 09:42:05 GMT, John Hendrikx wrote: >> This contains the following: >> - Nested changes or invalidations using ExpressionHelper are delayed until >> the current emission completes >> - This fixes odd change events being produced (with incorrect oldValue) >> - Also fixes a b

Re: RFR: 8299423: JavaFX Mac system menubar leaks [v5]

On Fri, 13 Jan 2023 09:18:56 GMT, Florian Kirmaier wrote: >> This PR fixes the leak in the mac system menu bar. >> >> Inside the native code, NewGlobalRef is called for the callable. >> Which makes it into a "GC-Root" until DeleteGlobalRef is called. >> >> The DeleteGlobalRef is never called f

Re: RFR: 8277848 Binding and Unbinding to List leads to memory leak [v8]

On Thu, 12 Jan 2023 08:53:14 GMT, Florian Kirmaier wrote: >> Making the initial listener of the ListProperty weak fixes the problem. >> The same is fixed for Set and Map. >> Due to a smart implementation, this is done without any performance drawback. >> (The trick is to have an object, which is

Re: Style themes API

Hi Pedro, see my comments below. On Mon, Jan 16, 2023 at 1:10 PM Pedro Duque Vieira wrote: > > No problem, I mentioned those in my first comment but probably got lost in > this conversation. > 2 – I think the ability to specify in the StyleTheme whether it is a user > agent stylesheet, or an a

[jfx19] RFR: 8300226: Change JavaFX release version to 19.0.2

Bump JavaFX release version to 19.0.2 - Commit messages: - Bump JavaFX release version to 19.0.2 Changes: https://git.openjdk.org/jfx/pull/997/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=997&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300226 Stats: 2 lines i

Re: RFR: 8273379 - GTK3 stops sending key events during drag and drop [v19]

> This PR fixes 8273379. > > I reverted back to use GDK (from > [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events. > > It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383). > > There's also some cleaup. > > To do general testing (two tests were add

Re: RFR: 8273379 - GTK3 stops sending key events during drag and drop [v18]

> This PR fixes 8273379. > > I reverted back to use GDK (from > [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events. > > It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383). > > There's also some cleaup. > > To do general testing (two tests were add

Re: RFR: 8273379 - GTK3 stops sending key events during drag and drop [v17]

> This PR fixes 8273379. > > I reverted back to use GDK (from > [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events. > > It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383). > > There's also some cleaup. > > To do general testing (two tests were add

Re: RFR: 8273379 - GTK3 stops sending key events during drag and drop [v16]

> This PR fixes 8273379. > > I reverted back to use GDK (from > [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events. > > It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383). > > There's also some cleaup. > > The most changed part is that I had to mo

Re: RFR: 8273379 - GTK3 stops sending key events during drag and drop [v15]

> This PR fixes 8273379. > > I reverted back to use GDK (from > [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events. > > It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383). > > There's also some cleaup. > > The most changed part is that I had to mo

Re: Style themes API

Hi again Michael, Thanks for taking the time to answer my comments. As always, it's easier to comment on and criticize than to do the actual work of implementing the feature. So thanks again for the patience. My comments below: I don't quite understand this. Can you elaborate on what the > adva

Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list [v2]

> This PR adds a warning about inserting Nodes directly into the virtualized > containers such as ListView, TreeView, TableView and TreeTableView. It also > adds code snippets showing the recommended pattern of using a custom cell > factory for each of the virtualized control. Ajit Ghaisas has

RFR: 8230833: LabeledSkinBase computes wrong height with ContentDisplay.GRAPHIC_ONLY

Ignore text condition was not considered in `computePrefHeight` method while calculating the Label height. Added `isIgnoreText` condition in `computePrefHeight` method while calculating Label height. Tests are present for all the ContentDisplay types. Modified tests which were failing because