Re: [jfx20] RFR: 8290863: Update the documentation of Virtualized controls to include the best practice of not using Nodes directly in the item list

2023-01-15 Thread Ajit Ghaisas
On Fri, 13 Jan 2023 12:32:53 GMT, Ajit Ghaisas wrote: > This PR adds a warning about inserting Nodes directly into the virtualized > containers such as ListView, TreeView, TableView and TreeTableView. It also > adds code snippets showing the recommended pattern of using a custom cell > factory

Re: Style themes API

2023-01-15 Thread Michael Strauß
My comments below: On Sun, Jan 15, 2023 at 1:25 PM Pedro Duque Vieira wrote: > > I think we could add that it has higher precedence than a user agent > stylesheets but that's it's not an author stylesheet. We can also possibly > briefly say what a user agent stylesheet and author stylesheet are

Re: Style themes API

2023-01-15 Thread Pedro Duque Vieira
Hi Michael, Thanks again for taking the time to answer my questions/comments and for your efforts in coming forward with this new API proposal. And also thanks for your patience as I can be a bit annoying at times. :) There's of course a bunch of things I liked about your API proposal but for the