Re: RFR: 8298167: Opacity in WebView not working anymore

2023-01-10 Thread Roman Marchenko
On Wed, 11 Jan 2023 07:32:20 GMT, Roman Marchenko wrote: > There was refactoring in WebKit's GraphicsContext class (nativecode) > https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63 > > > GraphicsContextJava's methods begin/endPlatformTransparencyLayers weren't

Re: RFR: 8298167: Opacity in WebView not working anymore [v2]

2023-01-10 Thread Roman Marchenko
> There was refactoring in WebKit's GraphicsContext class (nativecode) > https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63 > > > GraphicsContextJava's methods begin/endPlatformTransparencyLayers weren't > adapted after GraphicsContext's refactoring integration in

RFR: 8298167: Opacity in WebView not working anymore

2023-01-10 Thread Roman Marchenko
There was refactoring in WebKit's GraphicsContext class (nativecode) https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63 GraphicsContextJava's methods begin/endPlatformTransparencyLayers weren't adapted after GraphicsContext's refactoring integration into JFX. As t

Re: Windows build fails at MediaCapabilities.cpp(323): error C2327

2023-01-10 Thread John Neffenger
modules\javafx.web\src\main\native\Source\WebCore\Modules/mediacapabilities/MediaCapabilities.cpp(323): error C2327: 'WebCore::MediaCapabilities::m_encodingTasks': is not a type name, static, or enumerator Looking into it a bit more, it looks as if the compiler is failing to pick up the 'Medi

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v11]

2023-01-10 Thread Nir Lisker
On Sun, 25 Dec 2022 04:04:40 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time in order to confine the scope of >> th

Re: RFR: 8277848 Binding and Unbinding to List leads to memory leak [v7]

2023-01-10 Thread Michael Strauß
On Fri, 19 Aug 2022 10:40:01 GMT, Florian Kirmaier wrote: >> Making the initial listener of the ListProperty weak fixes the problem. >> The same is fixed for Set and Map. >> Due to a smart implementation, this is done without any performance drawback. >> (The trick is to have an object, which is

Re: RFR: 8267546: Add CSS themes as a first-class concept [v2]

2023-01-10 Thread Michael Strauß
On Fri, 11 Nov 2022 01:11:36 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/application/PlatformPreferences.java >> line 117: >> >>> 115: * @since 20 >>> 116: */ >>> 117: public interface PlatformPreferences extends Map { >> >> Are you sure it is a good idea to ex

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v9]

2023-01-10 Thread John Neffenger
> This pull request allows for reproducible builds of JavaFX on Linux, macOS, > and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For > example, the following commands create a reproducible build: > > > $ export SOURCE_DATE_EPOCH=$(git log -1 --pretty=%ct) > $ bash gradlew s

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v8]

2023-01-10 Thread John Neffenger
On Tue, 3 Jan 2023 00:21:53 GMT, John Neffenger wrote: >> This pull request allows for reproducible builds of JavaFX on Linux, macOS, >> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For >> example, the following commands create a reproducible build: >> >> >> $ export

Re: RFR: 8299681: Change JavaFX release version to 21

2023-01-10 Thread Andy Goryachev
On Tue, 10 Jan 2023 00:37:24 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 21. I will integrate this to `master` as > part of forking the `jfx20` stabilization branch, which is scheduled for > Thursday, January 12, 2023 at 16:00 UTC. checked against the older PR https://gi

Integrated: 8293119: Additional constrained resize policies for Tree/TableView

2023-01-10 Thread Andy Goryachev
On Mon, 12 Sep 2022 21:58:47 GMT, Andy Goryachev wrote: > The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in > [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810). > > We propose to address all these issues by replacing the old column resize > algorithm with a

Integrated: 8217853: Cleanup in the D3D native pipeline

2023-01-10 Thread Nir Lisker
On Mon, 2 May 2022 16:05:08 GMT, Nir Lisker wrote: > Refactoring and renaming changes to some of the D3D pipeline files and a few > changes on the Java side. These are various "leftovers" from previous issues > that we didn't want to touch at the time in order to confine the scope of the > cha

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v11]

2023-01-10 Thread Ambarish Rapte
On Sun, 25 Dec 2022 04:04:40 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time in order to confine the scope of >> th

Re: RFR: 8299681: Change JavaFX release version to 21

2023-01-10 Thread Ambarish Rapte
On Tue, 10 Jan 2023 00:37:24 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 21. I will integrate this to `master` as > part of forking the `jfx20` stabilization branch, which is scheduled for > Thursday, January 12, 2023 at 16:00 UTC. Marked as reviewed by arapte (Reviewer)

Re: RFR: 8293119: Additional constrained resize policies for Tree/TableView [v33]

2023-01-10 Thread Ajit Ghaisas
On Mon, 9 Jan 2023 23:08:02 GMT, Andy Goryachev wrote: >> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in >> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810). >> >> We propose to address all these issues by replacing the old column resize >> algorithm wit

Integrated: 8282386: JavaFX media stubs rely on libav.org

2023-01-10 Thread Johan Vos
On Thu, 5 Jan 2023 14:11:10 GMT, Johan Vos wrote: > Retrieve libav sources from github. > Fix JDK-8282386 This pull request has now been integrated. Changeset: 357cd856 Author:Johan Vos URL: https://git.openjdk.org/jfx/commit/357cd8563bd6ca47afd28dd1481afbe2d2458827 Stats: 21 li