> Based on previous discussions, this PR attempts to improve the JavaFX
> property system by enforcing correct API usage in several cases that are
> outlined below. It also streamlines the API by deprecating untyped APIs in
> favor of typed APIs that better express intent.
>
> ### 1. Behavioral
On Sun, 1 Jan 2023 16:08:15 GMT, John Hendrikx wrote:
>> Packages fixed:
>> - com.sun.javafx.binding
>> - com.sun.javafx.collections
>> - javafx.beans
>> - javafx.beans.binding
>> - javafx.collections
>> - javafx.collections.transformation
>
> John Hendrikx has updated the pull request incrementa
> Based on previous discussions, this PR attempts to improve the JavaFX
> property system by enforcing correct API usage in several cases that are
> outlined below. It also streamlines the API by deprecating untyped APIs in
> favor of typed APIs that better express intent.
>
> ### 1. Behavioral
> This PR adds style themes as a first-class concept to OpenJFX. A style theme
> is a collection of stylesheets and the logic that governs them. Style themes
> can respond to OS notifications and update their stylesheets dynamically.
> This PR also re-implements Caspian and Modena as style theme
> This PR adds style themes as a first-class concept to OpenJFX. A style theme
> is a collection of stylesheets and the logic that governs them. Style themes
> can respond to OS notifications and update their stylesheets dynamically.
> This PR also re-implements Caspian and Modena as style theme
On Mon, 2 Jan 2023 09:26:14 GMT, Florian Kirmaier wrote:
>> This PR fixes the leak in the mac system menu bar.
>>
>> Inside the native code, NewGlobalRef is called for the callable.
>> Which makes it into a "GC-Root" until DeleteGlobalRef is called.
>>
>> The DeleteGlobalRef is never called for
> This PR fixes 8273379.
>
> I reverted back to use GDK (from
> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events.
>
> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).
>
> There's also some cleaup.
>
> The most changed part is that I had to mo
On Tue, 3 Jan 2023 23:29:13 GMT, Thiago Milczarek Sayao
wrote:
>> This PR fixes 8273379.
>>
>> I reverted back to use GDK (from
>> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the
>> events.
>>
>> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).
>
On Mon, 2 Jan 2023 09:26:14 GMT, Florian Kirmaier wrote:
>> This PR fixes the leak in the mac system menu bar.
>>
>> Inside the native code, NewGlobalRef is called for the callable.
>> Which makes it into a "GC-Root" until DeleteGlobalRef is called.
>>
>> The DeleteGlobalRef is never called for
On Tue, 3 Jan 2023 23:56:12 GMT, Nir Lisker wrote:
>> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
>> expand/collapse events. The graphics node needs to be released from the
>> previous checkbox so that it doesn't serve as the graphics of more than one
>> checkbox at
On Tue, 3 Jan 2023 23:56:12 GMT, Nir Lisker wrote:
>> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
>> expand/collapse events. The graphics node needs to be released from the
>> previous checkbox so that it doesn't serve as the graphics of more than one
>> checkbox at
> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
> expand/collapse events. The graphics node needs to be released from the
> previous checkbox so that it doesn't serve as the graphics of more than one
> checkbox at once. If it does, only one checkbox (its skin) can actua
On Tue, 3 Jan 2023 23:39:36 GMT, Andy Goryachev wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added copyright header and changed package name
>
> tests/performance/checkboxTreeView/src/main/java/main/CheckBoxTreeEd
On Tue, 3 Jan 2023 23:38:10 GMT, Nir Lisker wrote:
>> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
>> expand/collapse events. The graphics node needs to be released from the
>> previous checkbox so that it doesn't serve as the graphics of more than one
>> checkbox at
On Tue, 3 Jan 2023 23:34:06 GMT, Nir Lisker wrote:
>> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
>> expand/collapse events. The graphics node needs to be released from the
>> previous checkbox so that it doesn't serve as the graphics of more than one
>> checkbox at
On Tue, 3 Jan 2023 23:38:10 GMT, Nir Lisker wrote:
>> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
>> expand/collapse events. The graphics node needs to be released from the
>> previous checkbox so that it doesn't serve as the graphics of more than one
>> checkbox at
> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
> expand/collapse events. The graphics node needs to be released from the
> previous checkbox so that it doesn't serve as the graphics of more than one
> checkbox at once. If it does, only one checkbox (its skin) can actua
On Tue, 3 Jan 2023 23:19:16 GMT, Andy Goryachev wrote:
>> I wasn't sure exactly where to put it, but it's going to be used in a fix
>> for a performance issue I found when a node has many children.
>>
>> If it will fit into a larger app, I don't mind.
>
> I'll move it there as a part of JDK-829
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote:
> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
> expand/collapse events. The graphics node needs to be released from the
> previous checkbox so that it doesn't serve as the graphics of more than one
> checkbox at onc
> This PR fixes 8273379.
>
> I reverted back to use GDK (from
> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events.
>
> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).
>
> There's also some cleaup.
>
> The most changed part is that I had to mo
On Tue, 3 Jan 2023 23:13:52 GMT, Nir Lisker wrote:
>> tests/performance/checkboxTreeView/.classpath line 1:
>>
>>> 1:
>>
>> minor: should this project be moved to manual tests hierarchy?
>>
>> BTW, I am planning to create a monkey tester application which will include
>> many tests, to simpl
On Tue, 3 Jan 2023 23:11:08 GMT, John Hendrikx wrote:
> Looks good to me, releasing the graphic for empty cells. I'm left wondering
> if it should also be releasing the bindings it makes in that case, although
> that's less likely to cause (visible) issues.
I could make that change. I don't se
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote:
> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
> expand/collapse events. The graphics node needs to be released from the
> previous checkbox so that it doesn't serve as the graphics of more than one
> checkbox at onc
On Tue, 3 Jan 2023 23:07:19 GMT, Andy Goryachev wrote:
>> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
>> expand/collapse events. The graphics node needs to be released from the
>> previous checkbox so that it doesn't serve as the graphics of more than one
>> checkbo
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote:
> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
> expand/collapse events. The graphics node needs to be released from the
> previous checkbox so that it doesn't serve as the graphics of more than one
> checkbox at onc
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote:
> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
> expand/collapse events. The graphics node needs to be released from the
> previous checkbox so that it doesn't serve as the graphics of more than one
> checkbox at onc
On Tue, 3 Jan 2023 22:56:22 GMT, Kevin Rushforth wrote:
> I am seeing a new behavior,
could you check the latest version please?
I think the latest version works as expected, except for one scenario with
fractional size, where both AUTO_RESIZE_FLEX_LAST_COLUMN and
AUTO_RESIZE_FLEX_NEXT_COLUMN
On Tue, 3 Jan 2023 19:02:20 GMT, Andy Goryachev wrote:
>> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
>> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>>
>> We propose to address all these issues by replacing the old column resize
>> algorithm wit
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker wrote:
> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after
> expand/collapse events. The graphics node needs to be released from the
> previous checkbox so that it doesn't serve as the graphics of more than one
> checkbox at onc
Vote: YES
Op di 3 jan. 2023 om 16:17 schreef Kevin Rushforth <
kevin.rushfo...@oracle.com>:
> I hereby nominate John Hendrikx [1] to OpenJFX Committer.
>
> John is an OpenJFX community member, who has contributed 16 commits [2]
> to OpenJFX.
>
> Votes are due by January 17, 2023 at 16:00 UTC.
>
>
> - added test to ensure no exception is thrown from
> Control.queryAccessibleAttribute() for all accessible attributes values
> - fixed null focus model case in Tree/TableView
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now con
On Mon, 2 Jan 2023 11:42:47 GMT, Ambarish Rapte wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 29 commits:
>>
>> - 8296413: 2023
>> - Merge remote-tracking branch 'origin/master' into 8296413.query.acce
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
Vote: YES
Em ter., 3 de jan. de 2023 às 12:17, Kevin Rushforth <
kevin.rushfo...@oracle.com> escreveu:
> I hereby nominate John Hendrikx [1] to OpenJFX Committer.
>
> John is an OpenJFX community member, who has contributed 16 commits [2]
> to OpenJFX.
>
> Votes are due by January 17, 2023 at 16:
Vote: YES
On Tue, Jan 3, 2023 at 4:17 PM Kevin Rushforth
wrote:
>
> I hereby nominate John Hendrikx [1] to OpenJFX Committer.
>
> John is an OpenJFX community member, who has contributed 16 commits [2]
> to OpenJFX.
>
> Votes are due by January 17, 2023 at 16:00 UTC.
>
> Only current OpenJFX Comm
Vote: YES
-andy
From: openjfx-dev on behalf of Kevin Rushforth
Date: Tuesday, 2023/01/03 at 07:17
To: John Hendrikx , openjfx-dev
Subject: CFV: New OpenJFX Committer: John Hendrikx
I hereby nominate John Hendrikx [1] to OpenJFX Committer.
John is an OpenJFX community member, who has contri
Vote: Yes
Regards,
Ajit
> On 03-Jan-2023, at 8:47 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate John Hendrikx [1] to OpenJFX Committer.
>
> John is an OpenJFX community member, who has contributed 16 commits [2] to
> OpenJFX.
>
> Votes are due by January 17, 2023 at 16:00 UTC.
>
> On
Vote: YES
On 1/3/23 7:17 AM, Kevin Rushforth wrote:
I hereby nominate John Hendrikx [1] to OpenJFX Committer.
Vote: YES
On Tue, Jan 3, 2023 at 5:18 PM Kevin Rushforth
wrote:
> Vote: YES
>
> On 1/3/2023 7:17 AM, Kevin Rushforth wrote:
> > I hereby nominate John Hendrikx [1] to OpenJFX Committer.
>
>
Vote: YES
On 1/3/2023 7:17 AM, Kevin Rushforth wrote:
I hereby nominate John Hendrikx [1] to OpenJFX Committer.
I hereby nominate John Hendrikx [1] to OpenJFX Committer.
John is an OpenJFX community member, who has contributed 16 commits [2]
to OpenJFX.
Votes are due by January 17, 2023 at 16:00 UTC.
Only current OpenJFX Committers [3] are eligible to vote on this
nomination. Votes must be cast in the
On Tue, 3 Jan 2023 00:24:25 GMT, Nir Lisker wrote:
>> What would go wrong if they're not the same type? `ListContentBinding`
>> doesn't (and can't) enforce it and doesn't care either way. The whole
>> function fails silently if types don't match. Also `ListContentBinding` is
>> a private cl
On Tue, 20 Dec 2022 17:49:13 GMT, Johan Vos wrote:
>> When recalculating sizes, we often don't want the current index and/or
>> offset to change.
>>
>> Allow to fix the index/offset when doing recalculations.
>>
>> Fix JDK-8298728
>
> Johan Vos has updated the pull request incrementally with o
On Tue, 3 Jan 2023 00:26:21 GMT, Nir Lisker wrote:
>> Yes, looks like this is quite broken. This wouldn't have gone unnoticed so
>> long if unbind would just throw an exception when nothing could be unbound;
>> silently failing is never a good idea.
>
> Can you file an issue for this if it's no
On Wed, 28 Dec 2022 20:16:51 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Clean up expression classes repeated null checks
>> - Use instanceof with pattern matching in a few spots
>
> modules
On Tue, 3 Jan 2023 09:46:51 GMT, Ambarish Rapte wrote:
> Looks good to me. Tested on Windows10 and verified that not setting
> `observer` to `null` does not lead to any leak. Please merge with latest
> master to trigger a GitHub build and test.
Thanks, I've merged in master.
> Under a differe
On Tue, 12 May 2020 22:41:14 GMT, Nir Lisker wrote:
> > I'm fine with doing a fix, but I need to know which one. Avoiding NPE's and
> > silently doing nothing is IMHO not very desirable as this will give the
> > user of the API no feedback that something went wrong.
> > So I would prefer to fix
> This fixes a bug where the first call to unbind would clear the internal
> invalidation listener used, resulting in subsequent unbind calls to be
> no-ops, unless bind was called again first.
>
> I had to rewrite the parameterized test slightly as Parameterized will only
> call the parameters
On Mon, 27 Apr 2020 11:43:28 GMT, John Hendrikx wrote:
> This fixes a bug where the first call to unbind would clear the internal
> invalidation listener used, resulting in subsequent unbind calls to be
> no-ops, unless bind was called again first.
>
> I had to rewrite the parameterized test s
> This contains the following:
> - Nested changes or invalidations using ExpressionHelper are delayed until
> the current emission completes
> - This fixes odd change events being produced (with incorrect oldValue)
> - Also fixes a bug in ExpressionHelper where a nested change would unlock
>
51 matches
Mail list logo
