Re: RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode [v10]

2022-09-13 Thread Andy Goryachev
On Tue, 6 Sep 2022 10:38:44 GMT, Jeanette Winzenburg wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8292353: whitespace > > modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlUtils.java > l

[jfx19] Integrated: 8293615: Create release notes for JavaFX 19

2022-09-13 Thread Kevin Rushforth
On Tue, 13 Sep 2022 19:20:30 GMT, Kevin Rushforth wrote: > Clean backport of JavaFX 19 release notes to `jfx19` branch. This pull request has now been integrated. Changeset: 0db91abc Author:Kevin Rushforth URL: https://git.openjdk.org/jfx/commit/0db91abc0d97d45b05cc543bff024c9b36d53

Re: [jfx19] RFR: 8293615: Create release notes for JavaFX 19

2022-09-13 Thread Andy Goryachev
On Tue, 13 Sep 2022 19:20:30 GMT, Kevin Rushforth wrote: > Clean backport of JavaFX 19 release notes to `jfx19` branch. Marked as reviewed by angorya (Author). - PR: https://git.openjdk.org/jfx/pull/898

[jfx19] RFR: 8293615: Create release notes for JavaFX 19

2022-09-13 Thread Kevin Rushforth
Clean backport of JavaFX 19 release notes to `jfx19` branch. - Commit messages: - 8293615: Create release notes for JavaFX 19 Changes: https://git.openjdk.org/jfx/pull/898/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=898&range=00 Issue: https://bugs.openjdk.org/browse/J

Re: Link to Release Notes is broken

2022-09-13 Thread Kevin Rushforth
Ah. I know why. The PR was targeted to master, which I missed when reviewing the PR, and noticed it only earlier this morning. We can get this fixed. -- Kevin On 9/13/2022 10:57 AM, Scott Palmer wrote: The link to the Release Notes at https://openjfx.io/ goes to https://github.com/openjdk/jf

Re: Virtual Flow enhancements

2022-09-13 Thread John Hendrikx
I think it would be very good to add high level tests for those general use cases -- I've always found the VirtualFlow code quite complicated, but most of that comes from the need to allow different heights. Not sure if this is relevant, but perhaps it is one of those "common sense" cases: one

Link to Release Notes is broken

2022-09-13 Thread Scott Palmer
The link to the Release Notes at https://openjfx.io/ goes to https://github.com/openjdk/jfx/blob/jfx19/doc-files/release-notes-19.md which is giving me a 404 error. It seems the release note files at https://github.com/openjdk/jfx/tree/jfx19/doc-files only go up to v18. The same folder on the

Provide Quit handler for system menu bar

2022-09-13 Thread Florian Kirmaier
Hi Everyone, In one project, we have to handle the quit-logic for MacOS ourselves, when the menu entry is used. As background information - this menu entry is set in the class com.sun.glass.ui.mac.MacApplication. It's basically hard coded. Currently, in this project, the menu entry doesn't work i

Re: RFR: 8279640: ListView with null SelectionModel/FocusModel throws NPE [v5]

2022-09-13 Thread Thiago Milczarek Sayao
On Mon, 12 Sep 2022 16:27:06 GMT, Marius Hanl wrote: >> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` >> is set on a `ListView`. >> >> The following NPEs are fixed (all are also covered by exactly one test case): >> NPEs with null selection model: >> - Mouse click o

Re: RFR: 8289357: (Tree)TableView is null in (Tree)TableRowSkin during autosize [v6]

2022-09-13 Thread Ajit Ghaisas
On Wed, 10 Aug 2022 08:14:13 GMT, Marius Hanl wrote: >> Initialize the `(Tree)TableView` when creating the measure row. >> This will guarantee, that we can access the `(Tree)TableView` in the >> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It >> is always set otherw

Re: RFR: 8279640: ListView with null SelectionModel/FocusModel throws NPE [v5]

2022-09-13 Thread Marius Hanl
On Tue, 13 Sep 2022 12:16:28 GMT, Thiago Milczarek Sayao wrote: > Just updated to JavaFX 19 (without this fix) and noticed this NPE: > > Exception in thread "JavaFX Application Thread" > java.lang.NullPointerException: Cannot invoke > "javafx.scene.control.TableView$TableViewSelectionModel.ge

Re: RFR: 8279640: ListView with null SelectionModel/FocusModel throws NPE [v5]

2022-09-13 Thread Thiago Milczarek Sayao
On Mon, 12 Sep 2022 16:27:06 GMT, Marius Hanl wrote: >> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` >> is set on a `ListView`. >> >> The following NPEs are fixed (all are also covered by exactly one test case): >> NPEs with null selection model: >> - Mouse click o

Re: RFR: 8279640: ListView with null SelectionModel/FocusModel throws NPE [v5]

2022-09-13 Thread Ajit Ghaisas
On Mon, 12 Sep 2022 16:27:06 GMT, Marius Hanl wrote: >> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` >> is set on a `ListView`. >> >> The following NPEs are fixed (all are also covered by exactly one test case): >> NPEs with null selection model: >> - Mouse click o

Virtual Flow enhancements

2022-09-13 Thread Johan Vos
Hi, OpenJFX 17 contains a fix for JDK-8089589 [1] ([ListView] ScrollBar content moves toward-backward during scrolling.) Before this fix, the scrollbar in the VirtualFlow backing List/Table/TreeTableView controls was treating every cell of equal height. That generated an awkward scrolling experie

Integrated: 8293615: Create release notes for JavaFX 19

2022-09-13 Thread Johan Vos
On Mon, 12 Sep 2022 09:10:25 GMT, Johan Vos wrote: > Create the release notes for JavaFX 19 This pull request has now been integrated. Changeset: 205b7211 Author:Johan Vos URL: https://git.openjdk.org/jfx/commit/205b7211bde0e468e81a135fe37952b7f2b11d45 Stats: 88 lines in 1 file