On Thu, 4 Aug 2022 11:24:34 GMT, Jeanette Winzenburg
wrote:
> To clean this up completely, we could also change the of
> MultipleSelectionModel and move the old `isSelected(int) ==
> getSelectedIndices().contains(int)` into the spec of its isSelected. Probably
> could be done in a follow-up i
On Wed, 3 Aug 2022 23:28:24 GMT, Andy Goryachev wrote:
>> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect
>> statement "Is functionally equivalent to calling
>> getSelectedIndices().contains(index)."
>> 2. reimplement TableView.TableViewSelectionModel.isSelected(int) metho
On Thu, 4 Aug 2022 22:19:40 GMT, Kevin Rushforth wrote:
> Can you check it as part of fixing
> [JDK-8187145](https://bugs.openjdk.org/browse/JDK-8187145) and expand that
> issue to cover TreeTableView if needed?
Absolutely. Just checked - we have the same problem there.
Should it be a differe
On Sat, 8 Jan 2022 00:17:36 GMT, Marius Hanl wrote:
> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` is
> set on a `ListView`.
>
> The following NPEs are fixed (all are also covered by exactly one test case):
> NPEs with null selection model:
> - Mouse click on a `Li
On Thu, 4 Aug 2022 08:22:29 GMT, Paul wrote:
> Thinking about it, is there merit in changing the scalex and scaley checks to
> be != 0, as The main reason for checking at all is to prevent a division by
> zero. Although unlikely, could fractional values < 1 reach this code?
I doubt that a scal
On Sat, 8 Jan 2022 00:17:36 GMT, Marius Hanl wrote:
> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` is
> set on a `ListView`.
>
> The following NPEs are fixed (all are also covered by exactly one test case):
> NPEs with null selection model:
> - Mouse click on a `Li
On Thu, 4 Aug 2022 21:47:15 GMT, Andy Goryachev wrote:
> So no CSR is needed, I think.
Probably you are right if all we end up doing is clarifying existing behavior.
For example, if we add a sentence to the effect that "a null selection model
disables selection", and that is what already happe
On Thu, 4 Aug 2022 21:29:49 GMT, Kevin Rushforth wrote:
>> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel`
>> is set on a `ListView`.
>>
>> The following NPEs are fixed (all are also covered by exactly one test case):
>> NPEs with null selection model:
>> - Mouse clic
On Sat, 8 Jan 2022 00:17:36 GMT, Marius Hanl wrote:
> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` is
> set on a `ListView`.
>
> The following NPEs are fixed (all are also covered by exactly one test case):
> NPEs with null selection model:
> - Mouse click on a `Li
On Sat, 8 Jan 2022 00:17:36 GMT, Marius Hanl wrote:
> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` is
> set on a `ListView`.
>
> The following NPEs are fixed (all are also covered by exactly one test case):
> NPEs with null selection model:
> - Mouse click on a `Li
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request with a
To: OpenJFX Developers
As a reminder, JavaFX 19 is now in Rampdown Phase Two (RDP2). [1]
P1-P2 bugs, and test or doc bugs of any priority, can be fixed during
RDP2. Explicit approval is needed for bug fixes (except for doc and test
fixes), and all enhancements to go in to the jfx19 branch [2].
On Thu, 4 Aug 2022 16:41:20 GMT, Jeanette Winzenburg
wrote:
>> @kleopatra :
>> thank you for your feedback! a couple of questions:
>> 1. which tests are failing?
>> 2. are you testing on windows?
>
> the tests are fine - it happens if I have a separate project and let that
> depend on the con
On Thu, 4 Aug 2022 15:33:11 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/.classpath line 5:
>>
>>> 3:
>>> 4:
>>> 5:
>>
>> these two seem not enough for running projects that depend on the graphics
>> project, without the other two (from the original before the [PR
>> 804](https
On Thu, 4 Aug 2022 10:53:07 GMT, Jeanette Winzenburg
wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 pr
When calculating the viewportOffset, we now already take into account that
cells will have to shift.
This prevents the creation of temporary empty cells in the layout phase.
One test needed to be fixed, since the number of invocations to updateItem()
was hardcoded (and it
is decreased by this co
On Wed, 27 Jul 2022 05:47:56 GMT, Ajit Ghaisas wrote:
>> thank you for your comments, Ajit! below are responses, please let me know
>> if you agree or not:
>>
>> 1. javadoc for TableSelectionModel.isSelected(int, TablecolumnBase) already
>> describes the logic:
>> `
>>/**
>> * Conven
On Mon, 1 Aug 2022 16:53:29 GMT, Andy Goryachev wrote:
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .sett
On Wed, 3 Aug 2022 15:11:31 GMT, Kevin Rushforth wrote:
>> Thanks for all the feedback. I've updated as per your suggestions
>> @jperedadnr and @kevinrushforth. Let me know how this looks to you - I'm
>> learning a lot here :-)
>>
>> I ran the tests as per your example and got `802 tests compl
19 matches
Mail list logo
