Re: [Openerp-community] Proposal to add W0402 to Travis Style checking

2014-11-14 Thread Leonardo Pistone
Thanks Sandy for the initiative. I agree we should find a way to be a bit more careful changing the linting rules, and your proposal looks good to me in general. A remark on a detail: do we need the extra organization? We could work the way we do for day-to-day pull requests: a simple PR from a p

Re: [Openerp-community] Proposal to add W0402 to Travis Style checking

2014-11-13 Thread Georges Racinet
On 11/13/2014 06:32 PM, Moises Lopez wrote: > Hello Georges, > > Sentence import pdb, import pudb, import ipdb (and maybe print) is > usefully to debug local. > If you need use this sentence in stable branch you will can add a > comment of this type: > > import pdb # pylint: disable=W0402 > and tha

Re: [Openerp-community] Proposal to add W0402 to Travis Style checking

2014-11-13 Thread Sandy Carter
I think the PR could be expanded to add/remove deprecated modules from the .travis file. The reason for this is that for certain branches openerp.osv.osv is acceptable and on the newer ones, they have become deprecated. There may be truth that the call to set_trace should be the one blocked. Plea

Re: [Openerp-community] Proposal to add W0402 to Travis Style checking

2014-11-13 Thread Moises Lopez
Hello Georges, Sentence import pdb, import pudb, import ipdb (and maybe print) is usefully to debug local. If you need use this sentence in stable branch you will can add a comment of this type: import pdb # pylint: disable=W0402 2014-11-13 11:21 GMT-06:00 Georges Racinet : > Hi Sandy, > > On

Re: [Openerp-community] Proposal to add W0402 to Travis Style checking

2014-11-13 Thread Georges Racinet
On 11/13/2014 06:21 PM, Georges Racinet wrote: > Hi Sandy, > > On 11/13/2014 06:13 PM, Sandy Carter wrote: >> Following my proposed procedure, I am informing the community that we >> intend to add a new style restriction [1]. >> >> >> W0402 deprecated-module:Used a module marked as deprecated is im

Re: [Openerp-community] Proposal to add W0402 to Travis Style checking

2014-11-13 Thread Georges Racinet
Hi Sandy, On 11/13/2014 06:13 PM, Sandy Carter wrote: > Following my proposed procedure, I am informing the community that we > intend to add a new style restriction [1]. > > > W0402 deprecated-module:Used a module marked as deprecated is imported. > > Modules marked as deprecated: pdb,pudb,ipdb >