Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-fix-search-no-lot-attributes-lep/+merge/204296
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes/6.1.
__
Here are various occurences of regular expressions looking very strongly
like email matching regexps I found with grep in the trunk branches:
ack --type=python 're\.(compile|search|match).*@' server/trunk addons/trunk
web/trunk/
server/trunk/openerp/addons/base/ir/ir_mail_server.py
123:name_with_
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-fix-1259975-migration-lep/+merge/198592
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes.
___
Mailing l
Above commit follows Olivier Dony's suggestions
--
https://code.launchpad.net/~openerp-community/openobject-server/7.0_improve_tree_view_doc-afe/+merge/183382
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/openobject-server/7.0_improve_tree_view_doc-afe.
_
Alexandre Fayolle - camptocamp has proposed merging
lp:~openerp-community/openobject-server/7.0_improve_tree_view_doc-afe into
lp:openobject-server/7.0.
Requested reviews:
OpenERP Core Team (openerp)
For more details, see:
https://code.launchpad.net/~openerp-community/openobject-server
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~openerp-community/openerp-mgmtsystem/7.0-web_color/+merge/156951
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/openerp-mgmtsystem/7.0-web_color.
___
M
Raphael, Guewen, what is the status of this MP ?
--
https://code.launchpad.net/~akretion-team/openerp-product-attributes/mixin-extraction/+merge/151333
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes.
___
Mailing list:
Review: Needs Fixing
there seem to be a conflict after the merge of the previous branch.
Unfortunately, I cannot update your branch. Could you please fix the conflict
and resubmit?
Thanks
--
https://code.launchpad.net/~akretion-team/openerp-product-attributes/no-stock-dep/+merge/148417
Your
Alexandre Fayolle - camptocamp has proposed merging
lp:~akretion-team/openerp-product-attributes/no-stock-dep into
lp:openerp-product-attributes.
Requested reviews:
Product Core Editors (product-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/openerp-product
Can you submit a MP for the other related branch please?
--
https://code.launchpad.net/~akretion-team/openerp-product-attributes/no-stock-dep/+merge/147797
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes.
___
Mailing l
Review: Approve
you are right
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-product_images-migr/+merge/145630
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes.
___
Mailing list: https://launc
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-product_sequence-migr/+merge/145627
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes.
___
Mailing list:
Review: Needs Fixing code review, no test
version in __openerp__.py : I'm not too fond of Sébastien's choice of using
6.1.0 in other related modules. I'd rather have a normal increment here.
s/add images against/add images to/
in field description:
s/Local mounted path on OpenERP server wheree
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-product_m2mcategories-migr/+merge/145601
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes.
___
Mailing
guewen: for the record, it is legal to have *args after a kw argument in a
function definition in Python
--
https://code.launchpad.net/~openerp-community/openerp-mgmtsystem/nc-extend/+merge/140259
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/openerp-mgmtsystem/nc-ext
For improved readability I suggest rewriting the state value line as
'state': 'structured' if line.invoice and line.invoice.reference_type !=
'none' else 'normal',
I don't know that part of the code to comment more on the MP.
--
https://code.launchpad.net/~openerp-community/openobject-addo
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bugfix-1092044/+merge/144663
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/openobject-addons/trunk-bugfix-1092044.
_
Review: Needs Information
is the comment "#recompute the membership_state of those partners" still
meaningful once the next line is removed? I think it should be removed.
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bugfix-1092044/+merge/144663
Your team OpenERP Comm
Review: Approve
This is unfortunate but I think this is the only way to go... :-/
--
https://code.launchpad.net/~product-core-editors/openerp-product-attributes/new6.1/+merge/143657
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes/6.1.
__
> There are some things on the move in the official addons in trunk. I
> submitted a merge proposal to clean up modules but it has not been
> proposed so far
s/proposed/processed/
--
https://code.launchpad.net/~openerp-community/openerp-mgmtsystem/nc-extend/+merge/139534
Your team OpenERP Commu
On 14/12/2012 11:24, Daniel Reis (SECURITAS SA) wrote:
> Guewen: Thanks for the review; fixes are in progress.
>
> I'd like to know a little more about your remark «On the usage of namespaces,
> classes and instanciation of models».
> I did some browsing on the official addons, and found some case
Hello,
I've never worked with EDI in openerp so far, so the whole thing is not quite
clear to me.
* shouldn't that module declare a dependency on the edi addon ?
* the implementation of edi_export looks strange, does not seem to be doing
anything (but then again, that part of the framework is
Review: Needs Fixing
ligne 77: je mettrais des guillemets autour des de colonnes (sinon on a
l'impression d'une faute d'accord)
ligne 426: s/Vous avez saisit/Vous avez saisi/
ligne 466: s/être définit/être définie/
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-member
Review: Needs Information
Hello,
The module product_gs1_128 has been proposed for inclusion in the stock and
logistic barcode project
(https://code.launchpad.net/~numerigraphe/stock-logistic-barcode/6.1-gs1-128-barcodes/+merge/134657)
We really don't want the same module to live in 2 different
Review: Needs Fixing
s/en -tête/en-tête/
Il reste une espace avant la virgule ligne 381.
--
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-mail-trans-fr/+merge/135455
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/openobject-addons/trunk-mail-t
25 matches
Mail list logo
