Hi Lionel,
I have no problem adding those tags and forwarding them to trunk, but
it may take me quite a while if I have to locate the revisions to tag.
I would definitely appreciate if someone can help with that :-)
Cheers,
OK sure. For the moment I'm not sure how to find them because I nee
On 03/14/2014 10:42 AM, Lionel Sausin wrote:
Do you think you could do the following, at least for the supported
releases?
- find the earliest revision of the release-branch (ie.
openobject-addons/7.0) which runs green on runbot (I can help with this
if you want)
- tag it with something like "7.0
Review: Approve code review, no test
OK, sorry about the misunderstanding.
Nevertheless, I would prefer to see some assertions, gets and tries as this
function looks likely to throw an IndexError.
But I see you've take them into account (removal of redundant checks, values
checking, etc)
--
htt
@Sandy, This code relies on the constructed view which guarantees that when
selection_fieldname occurs in vals, then so does 'fieldname'. In the case of
m2m, it's value is guaranteed to be in the form [(6, 0, list)], so accessing
the list through vals[model_field][0][2] should be fine.
--
https
Review: Needs Fixing code review
@Stefan: I thin you missed the point of vals[model_field]:
There is a chance of a KeyError if model_field not in val and a chance of index
error if len(vals[model_field]) < 1 or len(vals[model_field][0]) < 3
--
https://code.launchpad.net/~therp-nl/server-env-tool
l.550: when the user makes a selection of m2m values to remove, the code
executes a [(5, 0, [])]. This removes all values. My branch executes a [(3,
value) for each value].
--
https://code.launchpad.net/~openerp-community/server-env-tools/6.1-mass_editing/+merge/161619
Your team OpenERP Communi
Thanks for the comments. Now using vals[model_field][0][2] or [], taking
Francesco's response on the mailing list into account. Changing some variable
names after complaints by pylint.
--
https://code.launchpad.net/~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss/+merge/201321
Your tea
7 matches
Mail list logo
