Re: [OE-core] [PATCH V2] sanity: add function to check for git config user

2016-10-03 Thread Richard Purdie
On Sun, 2016-10-02 at 17:43 -0700, Stephano Cetola wrote: > If attempting to patch a git repo without a proper git config setup, > an error will occur saying user.name/user.email are needed by git > am/apply. After some code was removed from kernel-yocto, it was > simple enough to reproduce this er

Re: [OE-core] [PATCH V2] sanity: add function to check for git config user

2016-10-03 Thread Stephano Cetola
On 10/03, Burton, Ross wrote: > On 3 October 2016 at 01:43, Stephano Cetola > wrote: > > > +# If the user hasn't set up their name/email, set some defaults > > +check_git_config() { > > + if [ -z "$1" ]; then > > + name="OE" > > + else > > + name="$1" > > +

Re: [OE-core] [PATCH V2] sanity: add function to check for git config user

2016-10-03 Thread Burton, Ross
On 3 October 2016 at 01:43, Stephano Cetola wrote: > +# If the user hasn't set up their name/email, set some defaults > +check_git_config() { > + if [ -z "$1" ]; then > + name="OE" > + else > + name="$1" > + fi > + if ! git config user.email > /